From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96222C4361B for ; Thu, 17 Dec 2020 23:28:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 332EE23434 for ; Thu, 17 Dec 2020 23:28:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732054AbgLQX2S (ORCPT ); Thu, 17 Dec 2020 18:28:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726721AbgLQX2R (ORCPT ); Thu, 17 Dec 2020 18:28:17 -0500 Received: from yawp.biot.com (yawp.biot.com [IPv6:2a01:4f8:10a:8e::fce2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A5C1C0617A7 for ; Thu, 17 Dec 2020 15:27:37 -0800 (PST) Received: from debian-spamd by yawp.biot.com with sa-checked (Exim 4.93) (envelope-from ) id 1kq2gJ-008RFB-PO for linux-mips@vger.kernel.org; Fri, 18 Dec 2020 00:27:35 +0100 Received: from [2a02:578:460c:1:ae1f:6bff:fed1:9ca8] by yawp.biot.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1kq2gG-008REv-Ge; Fri, 18 Dec 2020 00:27:32 +0100 Subject: Re: [PATCH] Add support for Realtek RTL838x/RTL839x switch SoCs To: Oleksij Rempel , tsbogend@alpha.franken.de, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org References: <20201215183557.646034-1-bert@biot.com> From: Bert Vermeulen Message-ID: Date: Fri, 18 Dec 2020 00:27:32 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On 12/15/20 11:11 PM, Oleksij Rempel wrote: > Hello Bert, > > thank you for your work. Here are some comments.. Thanks for reviewing. I will send in a V2 with your comments all handled. > I assume, after applying all needed changes, there will be no files within > arch/mips/include/asm/mach-realtek :) I wish! Unfortunately I need somewhere to put the early printk init call, and the SoC family ID checks -- as they are heavily used in various drivers. -- Bert Vermeulen bert@biot.com