From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 846A9C54EBD for ; Fri, 13 Jan 2023 11:30:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238205AbjAMLaQ (ORCPT ); Fri, 13 Jan 2023 06:30:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240683AbjAML3u (ORCPT ); Fri, 13 Jan 2023 06:29:50 -0500 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E62008B53C for ; Fri, 13 Jan 2023 03:19:37 -0800 (PST) Received: by mail-ej1-x636.google.com with SMTP id u9so51615129ejo.0 for ; Fri, 13 Jan 2023 03:19:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nNpoWQlOxVCjJNH1/tWYzE33AytIwBJrxcIw+MQAk1E=; b=YAc09V0LuRBCbE9h978g2eWv0ESqP6iDhWXWiOscMziFrCnja1+oAglJvYPWVXDyep XnO+MwuT5Ni/nHQCK7FFduQEUsnuvZAYGSK9/yXWTieTtQHtpzzTVA1Ml55m7VmWx+6P zRAHT+4BEEdL4DuvH6N76tG9ubYIa2nC+/SyiBjNTB/QvLy/Ht16vTaHzU21TNNWDF3W yqo2S6QLzNOSk0lYNkTLXTJDC2Lo334xt+c13cr7mlnKkn/BDwY9ugO573ETe1C10mhb F5U35mauKmu0s76EfuaWK1vLqXfytEy/OI65pMShir1XBDs9PP0RyWsXN/sPkE+qxNgk KN0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nNpoWQlOxVCjJNH1/tWYzE33AytIwBJrxcIw+MQAk1E=; b=WZwLN58FOwEpFWuZEnjaGMLWL6ycaL/LGdUNIOryZrensvUYhsmMcYvngV85jLb82R SY/kJtZatUTNXeWFBidusagJwULDv/euVCxGfDhItpZI4Tt7hm0/BpfIO6X8parRSq8x ybRZ4wu+WOXQ7yMAYis+s/BY4tWqjAst+tF0DoTdP7xqE2LS6ozdzPmQODU0eNQCMxz8 +s0KFZkCsaIoKiTr1OrrkMcV4SOZ9idCZEKy2iWVlwOj915PsbGuyENH46FwaUlEQg/z PDL6ktUAP5NxtL1mCfZSKuZjWhxrNIo5DYH3sa+Axpd1/H3KOSk6MySnj73xuIq8CvSn OAsw== X-Gm-Message-State: AFqh2ko2eOLA4MdrHgXoP3E35lb90DLZUXN132/COPFvC/UyTtZSpIFs dXCs3uXeftloEsmoqQrGBGW7sAA4p0qtA3iK X-Google-Smtp-Source: AMrXdXspYZjcBS1Yz9eGU+zh+BZTR4yIsg9PI+y6cZKg1n5HF52+7JotiGtPdug5EZcV7LcflFtXKQ== X-Received: by 2002:a17:907:6d26:b0:857:b916:94c1 with SMTP id sa38-20020a1709076d2600b00857b91694c1mr17660684ejc.61.1673608776266; Fri, 13 Jan 2023 03:19:36 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id 17-20020a170906059100b007c16f120aacsm8356105ejn.121.2023.01.13.03.19.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Jan 2023 03:19:35 -0800 (PST) Message-ID: Date: Fri, 13 Jan 2023 12:19:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 2/2] clk: loongson1: Refactor to add devicetree support Content-Language: en-US To: Keguang Zhang , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski References: <20230113110738.1505973-1-keguang.zhang@gmail.com> <20230113110738.1505973-3-keguang.zhang@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20230113110738.1505973-3-keguang.zhang@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On 13/01/2023 12:07, Keguang Zhang wrote: > This patch refactors Loongson-1 clock driver. > - Use CLK_OF_DECLARE() to declare the "early clocks" > required by of_clk_init() > - Merge clk-loongson1b.c and clk-loongson1c.c into one driver > because most of the differences between them will be moved to DT > - Add set_rate callback for ls1x_clk_divider > - Update the Kconfig/Makefile accordingly > - Update copyright > > Signed-off-by: Keguang Zhang > --- > drivers/clk/Makefile | 2 +- > drivers/clk/clk-loongson1.c | 348 +++++++++++++++++++++++++ No, this is not a refactor. This is removal and re-add. NAK. One change per commit, this is unreviewable. > drivers/clk/loongson1/Makefile | 4 - > drivers/clk/loongson1/clk-loongson1b.c | 118 --------- > drivers/clk/loongson1/clk-loongson1c.c | 95 ------- This is not explained at all. You are pushing some crappy vendor code here instead of merging with upstream code. Otherwise, explain the drop of directory. Why Loongson should be special? Best regards, Krzysztof