From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-mips@vger.kernel.org
Cc: Jonas Gorski <jonas.gorski@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH 1/6] serial: 8250: remove AR7 support
Date: Thu, 21 Sep 2023 12:36:05 +0200 [thread overview]
Message-ID: <a86483c4-9ec2-3435-198b-9773379c67be@linaro.org> (raw)
In-Reply-To: <20230920201035.3445-2-wsa+renesas@sang-engineering.com>
Hi Wolfram,
(Adding Andy for commit 54b45ee8bd42 "serial: core: Remove
unused PORT_* definitions").
On 20/9/23 22:10, Wolfram Sang wrote:
> AR7 is going to be removed from the Kernel, so remove its type
> definition from 8250 code. As with previous removals, I checked with
> Debian Code Search that 'PORT_AR7' is not used in userspace.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> drivers/tty/serial/8250/8250_port.c | 7 -------
> include/uapi/linux/serial_core.h | 1 -
> 2 files changed, 8 deletions(-)
> diff --git a/include/uapi/linux/serial_core.h b/include/uapi/linux/serial_core.h
> index add349889d0a..3b51901926f9 100644
> --- a/include/uapi/linux/serial_core.h
> +++ b/include/uapi/linux/serial_core.h
> @@ -32,7 +32,6 @@
> #define PORT_XSCALE 15
> #define PORT_RM9000 16 /* PMC-Sierra RM9xxx internal UART */
> #define PORT_OCTEON 17 /* Cavium OCTEON internal UART */
> -#define PORT_AR7 18 /* Texas Instruments AR7 internal UART */
I'm a bit surprised definitions are removed from the uAPI, isn't
it expected to be very stable? Shouldn't it be better to keep it
defined but modify the comment, mentioning "obsolete" or "deprecated"?
Regards,
Phil.
> #define PORT_U6_16550A 19 /* ST-Ericsson U6xxx internal UART */
> #define PORT_TEGRA 20 /* NVIDIA Tegra internal UART */
> #define PORT_XR17D15X 21 /* Exar XR17D15x UART */
next prev parent reply other threads:[~2023-09-21 22:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 20:10 [PATCH 0/6] remove AR7 platform and associated drivers Wolfram Sang
2023-09-20 20:10 ` [PATCH 1/6] serial: 8250: remove AR7 support Wolfram Sang
2023-09-20 21:25 ` Florian Fainelli
2023-09-21 7:31 ` Greg Kroah-Hartman
2023-09-21 10:36 ` Philippe Mathieu-Daudé [this message]
2023-09-21 11:16 ` Andy Shevchenko
2023-09-21 11:21 ` Jiri Slaby
2023-09-21 11:30 ` Andy Shevchenko
2023-09-21 12:04 ` Wolfram Sang
2023-09-21 11:18 ` Andy Shevchenko
2023-09-20 20:10 ` [PATCH 2/6] mtd: parsers: ar7: remove support Wolfram Sang
2023-09-20 21:26 ` Florian Fainelli
2023-09-20 20:10 ` [PATCH 3/6] vlynq: remove bus driver Wolfram Sang
2023-09-20 21:26 ` Florian Fainelli
2023-09-21 10:37 ` Philippe Mathieu-Daudé
2023-09-21 12:06 ` Wolfram Sang
2023-09-21 12:32 ` Philippe Mathieu-Daudé
2023-09-20 20:10 ` [PATCH 4/6] watchdog: ar7_wdt: remove driver to prepare for platform removal Wolfram Sang
2023-09-20 20:14 ` Guenter Roeck
2023-09-20 21:26 ` Florian Fainelli
2023-09-20 20:10 ` [PATCH 5/6] net: cpmac: " Wolfram Sang
2023-09-20 21:26 ` Florian Fainelli
2023-09-20 20:10 ` [PATCH 6/6] MIPS: AR7: remove platform Wolfram Sang
2023-09-20 21:28 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a86483c4-9ec2-3435-198b-9773379c67be@linaro.org \
--to=philmd@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=jonas.gorski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).