From: Aleksa Sarai <asarai@suse.de>
To: David Laight <David.Laight@ACULAB.COM>,
'Gleb Fotengauer-Malinovskiy' <glebfm@altlinux.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>,
Valentin Rothberg <vrothberg@suse.com>,
"linux-parisc@vger.kernel.org" <linux-parisc@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
"linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>,
"linux-xtensa@linux-xtensa.org" <linux-xtensa@linux-xtensa.org>,
"linux-alpha@vger.kernel.org" <linux-alpha@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Dmitry V. Levin" <ldv@altlinux.org>,
Jiri Slaby <jslaby@suse.com>,
"sparclinux@vger.kernel.org" <sparclinux@vger.kernel.org>,
Christian Brauner <christian.brauner@ubuntu.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] tty: Fix TIOCGPTPEER ioctl definition
Date: Wed, 12 Jul 2017 00:45:36 +1000 [thread overview]
Message-ID: <a99e301b-05d1-d262-aca2-60e3f3400bc5@suse.de> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6DD003758C@AcuExch.aculab.com>
>> Sent: 11 July 2017 01:12
>> This ioctl does nothing to justify an _IOC_READ or _IOC_WRITE flag
>> because it doesn't copy anything from/to userspace to access the
>> argument.
>>
>> Fixes: 54ebbfb1 ("tty: add TIOCGPTPEER ioctl")
> ...
>> -#define TIOCGPTPEER _IOR('T', 0x41, int) /* Safely open the slave */
>> +#define TIOCGPTPEER _IO('T', 0x41) /* Safely open the slave */
>
> This is a user API change. When was the ioctl added?
It was just pulled this merge window (4.13-rc1).
% git tag --contains 54ebbfb1603415d9953c150535850d30609ef077
%
--
Aleksa Sarai
Software Engineer (Containers)
SUSE Linux GmbH
https://www.cyphar.com/
prev parent reply other threads:[~2017-07-11 14:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 0:12 [PATCH] tty: Fix TIOCGPTPEER ioctl definition Gleb Fotengauer-Malinovskiy
2017-07-11 2:07 ` Aleksa Sarai
2017-07-11 7:30 ` Arnd Bergmann
2017-07-11 10:03 ` James Hogan
2017-07-11 10:03 ` James Hogan
2017-07-11 14:23 ` David Laight
2017-07-11 14:45 ` Aleksa Sarai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a99e301b-05d1-d262-aca2-60e3f3400bc5@suse.de \
--to=asarai@suse.de \
--cc=David.Laight@ACULAB.COM \
--cc=arnd@arndb.de \
--cc=christian.brauner@ubuntu.com \
--cc=glebfm@altlinux.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=ldv@altlinux.org \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=sparclinux@vger.kernel.org \
--cc=vrothberg@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).