* [PATCH] MIPS: loongson2ef: lemote-2f: add missing function prototypes
@ 2025-05-29 3:20 Randy Dunlap
2025-05-30 12:33 ` Thomas Bogendoerfer
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2025-05-29 3:20 UTC (permalink / raw)
To: linux-kernel; +Cc: Randy Dunlap, Jiaxun Yang, linux-mips, Thomas Bogendoerfer
Add several missing function prototypes for lemote-2f to eliminate
build warnings:
arch/mips/loongson2ef/lemote-2f/machtype.c:10:13: warning: no previous prototype for 'mach_prom_init_machtype' [-Wmissing-prototypes]
10 | void __init mach_prom_init_machtype(void)
arch/mips/loongson2ef/common/machtype.c:34:20: warning: no previous prototype for 'mach_prom_init_machtype' [-Wmissing-prototypes]
34 | void __weak __init mach_prom_init_machtype(void)
arch/mips/loongson2ef/lemote-2f/pm.c:52:6: warning: no previous prototype for 'setup_wakeup_events' [-Wmissing-prototypes]
52 | void setup_wakeup_events(void)
arch/mips/loongson2ef/lemote-2f/pm.c:90:5: warning: no previous prototype for 'wakeup_loongson' [-Wmissing-prototypes]
90 | int wakeup_loongson(void)
arch/mips/loongson2ef/lemote-2f/pm.c:137:13: warning: no previous prototype for 'mach_suspend' [-Wmissing-prototypes]
137 | void __weak mach_suspend(void)
arch/mips/loongson2ef/lemote-2f/pm.c:142:13: warning: no previous prototype for 'mach_resume' [-Wmissing-prototypes]
142 | void __weak mach_resume(void)
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: linux-mips@vger.kernel.org
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
---
arch/mips/include/asm/mach-loongson2ef/loongson.h | 9 +++++++++
1 file changed, 9 insertions(+)
--- linux-next-20250522.orig/arch/mips/include/asm/mach-loongson2ef/loongson.h
+++ linux-next-20250522/arch/mips/include/asm/mach-loongson2ef/loongson.h
@@ -18,6 +18,9 @@ extern void bonito_irq_init(void);
extern void mach_prepare_reboot(void);
extern void mach_prepare_shutdown(void);
+/* machine-specific PROM functions */
+extern void __init mach_prom_init_machtype(void);
+
/* environment arguments from bootloader */
extern u32 cpu_clock_freq;
extern u32 memsize, highmemsize;
@@ -45,6 +48,12 @@ extern void __init mach_init_irq(void);
extern void mach_irq_dispatch(unsigned int pending);
extern int mach_i8259_irq(void);
+/* power management functions */
+extern void setup_wakeup_events(void);
+extern int wakeup_loongson(void);
+extern void __weak mach_suspend(void);
+extern void __weak mach_resume(void);
+
/* We need this in some places... */
#define delay() ({ \
int x; \
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] MIPS: loongson2ef: lemote-2f: add missing function prototypes
2025-05-29 3:20 [PATCH] MIPS: loongson2ef: lemote-2f: add missing function prototypes Randy Dunlap
@ 2025-05-30 12:33 ` Thomas Bogendoerfer
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Bogendoerfer @ 2025-05-30 12:33 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-kernel, Jiaxun Yang, linux-mips
On Wed, May 28, 2025 at 08:20:05PM -0700, Randy Dunlap wrote:
> Add several missing function prototypes for lemote-2f to eliminate
> build warnings:
>
> arch/mips/loongson2ef/lemote-2f/machtype.c:10:13: warning: no previous prototype for 'mach_prom_init_machtype' [-Wmissing-prototypes]
> 10 | void __init mach_prom_init_machtype(void)
> arch/mips/loongson2ef/common/machtype.c:34:20: warning: no previous prototype for 'mach_prom_init_machtype' [-Wmissing-prototypes]
> 34 | void __weak __init mach_prom_init_machtype(void)
> arch/mips/loongson2ef/lemote-2f/pm.c:52:6: warning: no previous prototype for 'setup_wakeup_events' [-Wmissing-prototypes]
> 52 | void setup_wakeup_events(void)
> arch/mips/loongson2ef/lemote-2f/pm.c:90:5: warning: no previous prototype for 'wakeup_loongson' [-Wmissing-prototypes]
> 90 | int wakeup_loongson(void)
> arch/mips/loongson2ef/lemote-2f/pm.c:137:13: warning: no previous prototype for 'mach_suspend' [-Wmissing-prototypes]
> 137 | void __weak mach_suspend(void)
> arch/mips/loongson2ef/lemote-2f/pm.c:142:13: warning: no previous prototype for 'mach_resume' [-Wmissing-prototypes]
> 142 | void __weak mach_resume(void)
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>
> Cc: linux-mips@vger.kernel.org
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> ---
> arch/mips/include/asm/mach-loongson2ef/loongson.h | 9 +++++++++
> 1 file changed, 9 insertions(+)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-30 12:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-29 3:20 [PATCH] MIPS: loongson2ef: lemote-2f: add missing function prototypes Randy Dunlap
2025-05-30 12:33 ` Thomas Bogendoerfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).