* [PATCH v1 1/1] firmware/nvram: bcm47xx: Don't use "proxy" headers
@ 2025-06-26 17:59 Andy Shevchenko
2025-06-30 19:03 ` Florian Fainelli
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2025-06-26 17:59 UTC (permalink / raw)
To: Andy Shevchenko, linux-kernel
Cc: linux-mips, Florian Fainelli, bcm-kernel-feedback-list,
Thomas Bogendoerfer
Update header inclusions to follow IWYU (Include What You Use)
principle.
Note that kernel.h is discouraged to be included as it's written
at the top of that file.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
include/linux/bcm47xx_nvram.h | 1 -
include/linux/bcm47xx_sprom.h | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/linux/bcm47xx_nvram.h b/include/linux/bcm47xx_nvram.h
index 7615f8d7b1ed..e4b6ce953ddb 100644
--- a/include/linux/bcm47xx_nvram.h
+++ b/include/linux/bcm47xx_nvram.h
@@ -7,7 +7,6 @@
#include <linux/errno.h>
#include <linux/types.h>
-#include <linux/kernel.h>
#include <linux/vmalloc.h>
#ifdef CONFIG_BCM47XX_NVRAM
diff --git a/include/linux/bcm47xx_sprom.h b/include/linux/bcm47xx_sprom.h
index f8254fd53e15..40a7da3ef50e 100644
--- a/include/linux/bcm47xx_sprom.h
+++ b/include/linux/bcm47xx_sprom.h
@@ -5,8 +5,8 @@
#ifndef __BCM47XX_SPROM_H
#define __BCM47XX_SPROM_H
+#include <linux/errno.h>
#include <linux/types.h>
-#include <linux/kernel.h>
#include <linux/vmalloc.h>
struct ssb_sprom;
--
2.47.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] firmware/nvram: bcm47xx: Don't use "proxy" headers
2025-06-26 17:59 [PATCH v1 1/1] firmware/nvram: bcm47xx: Don't use "proxy" headers Andy Shevchenko
@ 2025-06-30 19:03 ` Florian Fainelli
2025-07-02 11:10 ` Thomas Bogendoerfer
0 siblings, 1 reply; 3+ messages in thread
From: Florian Fainelli @ 2025-06-30 19:03 UTC (permalink / raw)
To: Andy Shevchenko, linux-kernel
Cc: linux-mips, Florian Fainelli, bcm-kernel-feedback-list,
Thomas Bogendoerfer
On 6/26/25 10:59, Andy Shevchenko wrote:
> Update header inclusions to follow IWYU (Include What You Use)
> principle.
>
> Note that kernel.h is discouraged to be included as it's written
> at the top of that file.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Thomas, can you pick this up? Thanks!
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] firmware/nvram: bcm47xx: Don't use "proxy" headers
2025-06-30 19:03 ` Florian Fainelli
@ 2025-07-02 11:10 ` Thomas Bogendoerfer
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Bogendoerfer @ 2025-07-02 11:10 UTC (permalink / raw)
To: Florian Fainelli
Cc: Andy Shevchenko, linux-kernel, linux-mips, Florian Fainelli,
bcm-kernel-feedback-list
On Mon, Jun 30, 2025 at 12:03:46PM -0700, Florian Fainelli wrote:
> On 6/26/25 10:59, Andy Shevchenko wrote:
> > Update header inclusions to follow IWYU (Include What You Use)
> > principle.
> >
> > Note that kernel.h is discouraged to be included as it's written
> > at the top of that file.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
>
> Thomas, can you pick this up? Thanks!
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-07-02 13:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-26 17:59 [PATCH v1 1/1] firmware/nvram: bcm47xx: Don't use "proxy" headers Andy Shevchenko
2025-06-30 19:03 ` Florian Fainelli
2025-07-02 11:10 ` Thomas Bogendoerfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).