From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1CEC029D28B; Thu, 28 Aug 2025 07:38:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.175.24.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756366724; cv=none; b=FOiOiHAUzEaNDbp5+yW7Kj78aFMmqbOEZZCMAYyC48t1kCXtOHlLahUe4NYLXBl56ZpLwqXAcLQlAS+Bq6SrLzvG4d1IoY89J6ddNoIkJIBXxmHGGygZOjqeXViWcURyJS4sq/TJ1f1uNCVcqRhPBu3nKYLFql74E7A8azu5+Gw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756366724; c=relaxed/simple; bh=1FeGWWkpnViziSe6lc+DKmue88Hh0SsFpGyGy5ESXBs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nDLWwlHTXAHERnXRk4Zv4uLjpYZYfy7y/pKmRfLRQ3nBAdPZl2Ffaz0iXldkaimAV4fhSMT3vVhmRvrKRAsCS8zC1K7Olit+K+mDWRkXLf7QsYRGEqxDVKttw06ENebi38baog0rKiFy7sNOjxzSm3dP/K36e8soQH0H9Swz4Sw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de; spf=pass smtp.mailfrom=alpha.franken.de; arc=none smtp.client-ip=193.175.24.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alpha.franken.de Received: from uucp by elvis.franken.de with local-rmail (Exim 3.36 #1) id 1urXDA-0001jz-00; Thu, 28 Aug 2025 09:38:20 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 09775C04FD; Thu, 28 Aug 2025 08:57:33 +0200 (CEST) Date: Thu, 28 Aug 2025 08:57:33 +0200 From: Thomas Bogendoerfer To: Ilpo =?iso-8859-1?Q?J=E4rvinen?= Cc: Andreas Larsson , Bjorn Helgaas , "David S. Miller" , Geert Uytterhoeven , linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-pci@vger.kernel.org, sparclinux@vger.kernel.org, Christian =?iso-8859-1?Q?K=F6nig?= , Yinghai Lu , Igor Mammedov , "Rafael J . Wysocki" , Jonathan Cameron , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , linux-kernel@vger.kernel.org, =?utf-8?Q?Micha=C5=82?= Winiarski , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 03/24] MIPS: PCI: Use pci_enable_resources() Message-ID: References: <20250822145605.18172-1-ilpo.jarvinen@linux.intel.com> <20250822145605.18172-4-ilpo.jarvinen@linux.intel.com> Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250822145605.18172-4-ilpo.jarvinen@linux.intel.com> On Fri, Aug 22, 2025 at 05:55:44PM +0300, Ilpo Järvinen wrote: > pci-legacy.c under MIPS has a copy of pci_enable_resources() named as > pcibios_enable_resources(). Having own copy of same functionality could > lead to inconsistencies in behavior, especially now as > pci_enable_resources() and the bridge window resource flags behavior > are going to be altered by upcoming changes. > > The check for !r->start && r->end is already covered by the more > generic checks done in pci_enable_resources(). > > Call pci_enable_resources() from MIPS's pcibios_enable_device() and > remove pcibios_enable_resources(). > > Signed-off-by: Ilpo Järvinen > --- > arch/mips/pci/pci-legacy.c | 38 ++------------------------------------ > 1 file changed, 2 insertions(+), 36 deletions(-) Acked-by: Thomas Bogendoerfer -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]