From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D91BD277026; Tue, 2 Sep 2025 14:29:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756823375; cv=none; b=c+0B+rQ9f7fAFtS52H2jogNkH+Pwb35EUu4j32ql/N/qE0nPwYydGbubO8DaAb5cxIS180jE4jzeqGi8LlIAplYlg4o1expK8PlFyb44UpwjpVy8d5bzjTmUXyCRBSxkYvtM1kXdSTJKjx5zcK5r6i9RrWABetwth3Im/m9oyDA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756823375; c=relaxed/simple; bh=/di9Z9Q2Z9WifwPEgJy+cghwk2Lex4IcvqCufSkxz1M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Go3NrF4RoGvkq34CYCKAnQ5XY+Zj49tN2+6TY0pENG/Ol9lcIXugHCZQFcV1XQM1t/fE8nXqAzBxyOxNl1wpRZVv+97Lmqx48eDbORPWSuZe4gjjffyBnKQctEEU5zchRLb99gsSlZtsXpXx3L4/OhDmUXeBwGDufMR4xkpv5YU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=jl7O/6eM; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="jl7O/6eM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1756823374; x=1788359374; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=/di9Z9Q2Z9WifwPEgJy+cghwk2Lex4IcvqCufSkxz1M=; b=jl7O/6eMj0EYkH5A3C0sWvbOu9bcGii8IfSK8KMOkerqqByR7S3llwK7 vqSxqViQeE/cNChKfgoayR8YR5k6qbL/Acptp9KSHhf8ROfgn5VTOI+hI cYbX8uxE8m0W2A0S3OmqwArqYky3WYBwZrjQjJeAEwDT+ZP++twUFY/HC obSnFi+la1aqgzlrQv8wiv3PJrkCT53KCTLCcyRmBqTPNljcbJtSmZCL9 TrAGeNyVKqVumKwrYKX62shCoqwOQ9JjN6r4IOctT0D9PLt6L5Uq9o6Vx UAiE4R5pNrNTkNP2nB7gL/5r1I7XFpH+qxjkhiOvsbTnfL1HSkpbzH7Tx Q==; X-CSE-ConnectionGUID: aV0IQkAETCCmDP+AfxjtdQ== X-CSE-MsgGUID: BNXVL0NESNW8e6DoDLSmug== X-IronPort-AV: E=McAfee;i="6800,10657,11541"; a="70480971" X-IronPort-AV: E=Sophos;i="6.18,230,1751266800"; d="scan'208";a="70480971" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2025 07:29:33 -0700 X-CSE-ConnectionGUID: KBB6d1l3TTe5YfjCkl77Bg== X-CSE-MsgGUID: HxnFVIFXRyiIXQcPIZR2Ng== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.18,230,1751266800"; d="scan'208";a="176602640" Received: from fpallare-mobl4.ger.corp.intel.com (HELO stinkbox) ([10.245.245.118]) by orviesa005.jf.intel.com with SMTP; 02 Sep 2025 07:29:15 -0700 Received: by stinkbox (sSMTP sendmail emulation); Tue, 02 Sep 2025 17:29:14 +0300 Date: Tue, 2 Sep 2025 17:29:14 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Maxime Ripard Cc: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, Dmitry Baryshkov , Louis Chauvet , Haneen Mohammed , Melissa Wen , Jyri Sarha , Tomi Valkeinen , Paul Cercueil , linux-mips@vger.kernel.org, Liviu Dudau , Russell King , Manikandan Muralidharan , Dharma Balasubiramani , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , linux-arm-kernel@lists.infradead.org, Inki Dae , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Alim Akhtar , linux-samsung-soc@vger.kernel.org, Liu Ying , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , imx@lists.linux.dev, Laurentiu Palcu , Lucas Stach , Philipp Zabel , Anitha Chrisanthus , Edmund Dea , Paul Kocialkowski , Sui Jingfeng , Chun-Kuang Hu , Matthias Brugger , AngeloGioacchino Del Regno , linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang < Subject: Re: [PATCH v2 00/37] drm/atomic: Get rid of existing states (not really) Message-ID: References: <20250902-drm-no-more-existing-state-v2-0-de98fc5f6d66@kernel.org> Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250902-drm-no-more-existing-state-v2-0-de98fc5f6d66@kernel.org> X-Patchwork-Hint: comment On Tue, Sep 02, 2025 at 11:34:59AM +0200, Maxime Ripard wrote: > Hi, > > Here's a series to get rid of the drm_atomic_helper_get_existing_*_state > accessors. > > The initial intent was to remove the __drm_*_state->state pointer to > only rely on old and new states, but we still need it now to know which > of the two we need to free: if a state has not been committed (either > dropped or checked only), then we need to free the new one, if it has > been committed we need to free the old state. > > Thus, the state pointer is kept (and documented) only to point to the > state we should free eventually. > > All users have been converted to the relevant old or new state > accessors. > > This was tested on tidss. > > Let me know what you think, > Maxime > > Signed-off-by: Maxime Ripard Other than the pre-existing ingenic private state issue that Dmitry spotted I didn't see anything obviously wrong. So apart from that the series is Reviewed-by: Ville Syrjälä > --- > Changes in v2: > - Dropped the first and second patches > - Reworked the recipient list to be nicer with SMTPs > - Link to v1: https://lore.kernel.org/r/20250825-drm-no-more-existing-state-v1-0-f08ccd9f85c9@kernel.org > > --- > Maxime Ripard (37): > drm/atomic: Convert drm_atomic_get_connector_state() to use new connector state > drm/atomic: Remove unused drm_atomic_get_existing_connector_state() > drm/atomic: Document __drm_connectors_state state pointer > drm/atomic: Convert __drm_atomic_get_current_plane_state() to modern accessor > drm/atomic: Convert drm_atomic_get_plane_state() to use new plane state > drm/vkms: Convert vkms_crtc_atomic_check() to use new plane state > drm/tilcdc: crtc: Use drm_atomic_helper_check_crtc_primary_plane() > drm/atomic: Remove unused drm_atomic_get_existing_plane_state() > drm/atomic: Document __drm_planes_state state pointer > drm/atomic: Convert drm_atomic_get_crtc_state() to use new connector state > drm/ingenic: ipu: Switch to drm_atomic_get_new_crtc_state() > drm/arm/malidp: Switch to drm_atomic_get_new_crtc_state() > drm/armada: Switch to drm_atomic_get_new_crtc_state() > drm/atmel-hlcdc: Switch to drm_atomic_get_new_crtc_state() > drm/exynos: Switch to drm_atomic_get_new_crtc_state() > drm/imx-dc: Switch to drm_atomic_get_new_crtc_state() > drm/imx-dcss: Switch to drm_atomic_get_new_crtc_state() > drm/imx-ipuv3: Switch to drm_atomic_get_new_crtc_state() > drm/ingenic: Switch to drm_atomic_get_new_crtc_state() > drm/kmb: Switch to drm_atomic_get_new_crtc_state() > drm/logicvc: Switch to drm_atomic_get_new_crtc_state() > drm/loongson: Switch to drm_atomic_get_new_crtc_state() > drm/mediatek: Switch to drm_atomic_get_new_crtc_state() > drm/msm/mdp5: Switch to drm_atomic_get_new_crtc_state() > drm/omap: Switch to drm_atomic_get_new_crtc_state() > drm/rockchip: Switch to drm_atomic_get_new_crtc_state() > drm/sun4i: Switch to drm_atomic_get_new_crtc_state() > drm/tegra: Switch to drm_atomic_get_new_crtc_state() > drm/tilcdc: Switch to drm_atomic_get_new_crtc_state() > drm/vboxvideo: Switch to drm_atomic_get_new_crtc_state() > drm/vc4: Switch to drm_atomic_get_new_crtc_state() > drm/atomic: Switch to drm_atomic_get_new_crtc_state() > drm/framebuffer: Switch to drm_atomic_get_new_crtc_state() > drm/atomic: Remove unused drm_atomic_get_existing_crtc_state() > drm/atomic: Document __drm_crtcs_state state pointer > drm/atomic: Convert drm_atomic_get_private_obj_state() to use new plane state > drm/atomic: Document __drm_private_objs_state state pointer > > drivers/gpu/drm/arm/malidp_planes.c | 2 +- > drivers/gpu/drm/armada/armada_plane.c | 3 +- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 +- > drivers/gpu/drm/drm_atomic.c | 21 ++-- > drivers/gpu/drm/drm_framebuffer.c | 2 +- > drivers/gpu/drm/exynos/exynos_drm_plane.c | 2 +- > drivers/gpu/drm/imx/dc/dc-plane.c | 2 +- > drivers/gpu/drm/imx/dcss/dcss-plane.c | 4 +- > drivers/gpu/drm/imx/ipuv3/ipuv3-plane.c | 3 +- > drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 3 +- > drivers/gpu/drm/ingenic/ingenic-ipu.c | 4 +- > drivers/gpu/drm/kmb/kmb_plane.c | 3 +- > drivers/gpu/drm/logicvc/logicvc_layer.c | 4 +- > drivers/gpu/drm/loongson/lsdc_plane.c | 2 +- > drivers/gpu/drm/mediatek/mtk_plane.c | 3 +- > drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c | 7 +- > drivers/gpu/drm/omapdrm/omap_plane.c | 2 +- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 6 +- > drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 2 +- > drivers/gpu/drm/sun4i/sun8i_ui_layer.c | 3 +- > drivers/gpu/drm/sun4i/sun8i_vi_layer.c | 3 +- > drivers/gpu/drm/tegra/dc.c | 2 +- > drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 9 +- > drivers/gpu/drm/tilcdc/tilcdc_plane.c | 3 +- > drivers/gpu/drm/vboxvideo/vbox_mode.c | 8 +- > drivers/gpu/drm/vc4/vc4_plane.c | 6 +- > drivers/gpu/drm/vkms/vkms_crtc.c | 4 +- > include/drm/drm_atomic.h | 144 ++++++++++++------------ > 28 files changed, 124 insertions(+), 135 deletions(-) > --- > base-commit: 7fa4d8dc380fbd81a9d702a855c50690c9c6442c > change-id: 20250825-drm-no-more-existing-state-9b3252c1a33b > > Best regards, > -- > Maxime Ripard -- Ville Syrjälä Intel