From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: John Garry <john.g.garry@oracle.com>
Cc: chenhuacai@kernel.org, kernel@xen0n.name,
jiaxun.yang@flygoat.com, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com,
luto@kernel.org, peterz@infradead.org, arnd@arndb.de,
x86@kernel.org, loongarch@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
linux-arch@vger.kernel.org, vulab@iscas.ac.cn,
gregkh@linuxfoundation.org, rafael@kernel.org, dakr@kernel.org
Subject: Re: [PATCH v2 3/4] MIPS: Loongson: Make cpumask_of_node() robust against NUMA_NO_NODE
Date: Fri, 30 Jan 2026 15:34:01 +0100 [thread overview]
Message-ID: <aXzBWUBNtearOrz9@alpha.franken.de> (raw)
In-Reply-To: <20260107094007.966496-4-john.g.garry@oracle.com>
On Wed, Jan 07, 2026 at 09:40:06AM +0000, John Garry wrote:
> The arch definition of cpumask_of_node() cannot handle NUMA_NO_NODE - which
> is a valid index - so add a check for this.
>
> Signed-off-by: John Garry <john.g.garry@oracle.com>
> ---
> arch/mips/include/asm/mach-loongson64/topology.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/include/asm/mach-loongson64/topology.h b/arch/mips/include/asm/mach-loongson64/topology.h
> index 3414a1fd17835..89bb4deab98a6 100644
> --- a/arch/mips/include/asm/mach-loongson64/topology.h
> +++ b/arch/mips/include/asm/mach-loongson64/topology.h
> @@ -7,7 +7,7 @@
> #define cpu_to_node(cpu) (cpu_logical_map(cpu) >> 2)
>
> extern cpumask_t __node_cpumask[];
> -#define cpumask_of_node(node) (&__node_cpumask[node])
> +#define cpumask_of_node(node) ((node) == NUMA_NO_NODE ? cpu_all_mask : &__node_cpumask[node])
>
> struct pci_bus;
> extern int pcibus_to_node(struct pci_bus *);
> --
> 2.43.5
applied to mips-next
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2026-01-30 14:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-07 9:40 [PATCH v2 0/4] Make cpumask_of_node() robust against NUMA_NO_NODE John Garry
2026-01-07 9:40 ` [PATCH v2 1/4] include/asm-generic/topology.h: Remove unused definition of cpumask_of_node() John Garry
2026-01-30 12:24 ` John Garry
2026-01-30 16:12 ` Arnd Bergmann
2026-01-07 9:40 ` [PATCH v2 2/4] LoongArch: Make cpumask_of_node() robust against NUMA_NO_NODE John Garry
2026-01-25 3:55 ` Huacai Chen
2026-01-30 12:20 ` John Garry
2026-01-31 8:50 ` Huacai Chen
2026-01-07 9:40 ` [PATCH v2 3/4] MIPS: Loongson: " John Garry
2026-01-25 3:55 ` Huacai Chen
2026-01-30 12:21 ` John Garry
2026-01-30 12:40 ` Thomas Bogendoerfer
2026-01-30 14:34 ` Thomas Bogendoerfer [this message]
2026-01-07 9:40 ` [PATCH v2 4/4] x86/cpu/topology: " John Garry
2026-01-19 8:38 ` [PATCH v2 0/4] " John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXzBWUBNtearOrz9@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=chenhuacai@kernel.org \
--cc=dakr@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=jiaxun.yang@flygoat.com \
--cc=john.g.garry@oracle.com \
--cc=kernel@xen0n.name \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=tglx@linutronix.de \
--cc=vulab@iscas.ac.cn \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox