public inbox for linux-mips@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Rong Zhang <rongrong@oss.cipunited.com>
Cc: "Jiaxun Yang" <jiaxun.yang@flygoat.com>,
	"Rong Zhang" <i@rong.moe>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] MIPS: Loongson2ef: Use pcibios_align_resource() to block io range
Date: Thu, 5 Feb 2026 10:05:34 +0100	[thread overview]
Message-ID: <aYRdXhSZRrHNJmqs@alpha.franken.de> (raw)
In-Reply-To: <20260131214003.833520-1-rongrong@oss.cipunited.com>

On Sun, Feb 01, 2026 at 05:32:57AM +0800, Rong Zhang wrote:
> Loongson2ef reserves io range below 0x4000 (LOONGSON_PCI_IO_START) while
> ISA-mode only IDE controller on the south bridge still has a hard
> dependency on ISA IO ports.
> 
> The reservation was done by lifting loongson_pci_io_resource.start onto
> 0x4000. Prior to commit ae81aad5c2e1 ("MIPS: PCI: Use
> pci_enable_resources()"), the arch specific pcibios_enable_resources()
> did not check if the resources were claimed, which diverges from what
> PCI core checks, effectively hiding the fact that IDE IO resources were
> not properly within the resource tree. After starting to use
> pcibios_enable_resources() from PCI core, enabling IDE controller fails:
> 
>   pata_cs5536 0000:00:0e.2: BAR 0 [io  0x01f0-0x01f7]: not claimed; can't enable device
>   pata_cs5536 0000:00:0e.2: probe with driver pata_cs5536 failed with error -22
> 
> MIPS PCI code already has support for enforcing lower bounds using
> PCIBIOS_MIN_IO in pcibios_align_resource() without altering the IO
> window start address itself. Register PCI controller in plat_mem_setup()
> instead of arch_initcall() to make it the root of other resources (e.g.,
> i8259) and prevent resource conflicts. Then, make Loongson2ef PCI code
> use PCIBIOS_MIN_IO too.
> 
> Rong Zhang (2):
>   MIPS: Loongson2ef: Register PCI controller in early stage
>   MIPS: Loongson2ef: Use pcibios_align_resource() to block io range
> 
>  .../include/asm/mach-loongson2ef/loongson.h    |  6 ++++++
>  arch/mips/loongson2ef/common/pci.c             | 18 +++++++++++-------
>  arch/mips/loongson2ef/common/setup.c           |  1 +
>  3 files changed, 18 insertions(+), 7 deletions(-)
> 
> 
> base-commit: ad9a728a3388dc5f66eab6b7135e0154249e9403
> -- 
> 2.51.0

series applied to mips-next
Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

      parent reply	other threads:[~2026-02-05  9:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-31 21:32 [PATCH 0/2] MIPS: Loongson2ef: Use pcibios_align_resource() to block io range Rong Zhang
2026-01-31 21:32 ` [PATCH 1/2] MIPS: Loongson2ef: Register PCI controller in early stage Rong Zhang
2026-01-31 21:32 ` [PATCH 2/2] MIPS: Loongson2ef: Use pcibios_align_resource() to block io range Rong Zhang
2026-01-31 21:41 ` [PATCH 0/2] " Jiaxun Yang
2026-02-05  9:05 ` Thomas Bogendoerfer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aYRdXhSZRrHNJmqs@alpha.franken.de \
    --to=tsbogend@alpha.franken.de \
    --cc=i@rong.moe \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jiaxun.yang@flygoat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=rongrong@oss.cipunited.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox