From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B1E3B1DF970; Tue, 10 Feb 2026 15:50:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.175.24.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770738650; cv=none; b=DiFigO+72GyCdq3zpeIOudQB+fkLHcDIHoe2tU9oorxsS6u2cyE1CoihdoOskD1+7cDBK0pCQIhVV0KfRCcJlyxMAERTNAUV56v8uIxWNxZ54l+6u8hma426p5bbFIirE8tKBct/plmVfmW3MRQWCQLXBK02jyeD/BgAo8sPel4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770738650; c=relaxed/simple; bh=7JUi+OMO7WaXxsmWScbHoICpLOvTDMMszEg+PGE+fh0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=af/5fJF/z9o13s6BDHiWFi/O/9WjpTZtPpFvNXwYJsQ/w4j7itDgqlNXwVdXB3Sl+ihlZIWaP4RzejpKS3BU6vnjynBKxhmC5UZbYCAF1DT9jkUZ78OzBejQHqUbuSQSktbttfCvNBR+udpjgbg/xHc+TNwXG+zRc6VvNduL4c4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de; spf=pass smtp.mailfrom=alpha.franken.de; arc=none smtp.client-ip=193.175.24.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alpha.franken.de Received: from uucp by elvis.franken.de with local-rmail (Exim 3.36 #1) id 1vpq0Z-0000iT-00; Tue, 10 Feb 2026 16:50:35 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 07982C0084; Tue, 10 Feb 2026 16:50:20 +0100 (CET) Date: Tue, 10 Feb 2026 16:50:20 +0100 From: Thomas Bogendoerfer To: Brian Masney Cc: Claudiu Beznea , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, Thomas Gleixner , Adrian Hunter , Ulf Hansson , linux-mmc@vger.kernel.org, Linus Walleij , linux-gpio@vger.kernel.org, Alexandre Belloni , linux-rtc@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org, Guenter Roeck , Wim Van Sebroeck , linux-watchdog@vger.kernel.org, Lukas Bulwahn Subject: Re: [PATCH v2 00/16] MIPS: move pic32.h header file from asm to platform_data Message-ID: References: <20260112-mips-pic32-header-move-v2-0-927d516b1ff9@redhat.com> Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Feb 10, 2026 at 07:42:25AM -0500, Brian Masney wrote: > Hi Thomas, > > On Mon, Jan 12, 2026 at 05:47:54PM -0500, Brian Masney wrote: > > There are currently some pic32 MIPS drivers that are in tree, and are > > only configured to be compiled on the MIPS pic32 platform. There's a > > risk of breaking some of these drivers when migrating drivers away from > > legacy APIs. It happened to me with a pic32 clk driver. > > > > Let's go ahead and move the pic32.h from the asm to the platform_data > > include directory in the tree. This will make it easier, and cleaner to > > enable COMPILE_TEST for some of these pic32 drivers. To do this requires > > updating some includes, which I do at the beginning of this series. > > > > This series was compile tested on a centos-stream-10 arm64 host in two > > different configurations: > > > > - native arm64 build with COMPILE_TEST (via make allmodconfig) > > - MIPS cross compile on arm64 with: > > ARCH=mips CROSS_COMPILE=mips64-linux-gnu- make pic32mzda_defconfig > > > > Note that there is a separate MIPS compile error in linux-next, and I > > reported it at https://lore.kernel.org/all/aWVs2gVB418WiMVa@redhat.com/ > > > > I included a patch at the end that shows enabling COMPILE_TEST for a > > pic32 clk driver. > > > > Merge Strategy > > ============== > > - Patches 1-15 can go through the MIPS tree. > > - Patch 16 I can repost to Claudiu after patches 1-15 are in Linus's > > tree after the next merge window. There is a separate patch set that > > fixes a compiler error I unintentionally introduced via the clk tree. > > https://lore.kernel.org/linux-clk/CABx5tq+eOocJ41X-GSgkGy6S+s+Am1yCS099wqP695NtwALTmg@mail.gmail.com/T/ > > Sorry about the duplicate message. I just wanted to reply to the series > with MIPS in the header so this message isn't lost. > > Can you back out these two patches from your tree in linux-next, and not > send these to Linus? > > clk: microchip: core: allow driver to be compiled with COMPILE_TEST > https://git.kernel.org/pub/scm/linux/kernel/git/mips/linux.git/commit/?id=026d70dcfe5de1543bb8edb8e50d22dc16863e6b > > clk: microchip: fix typo in reference to a config option > https://git.kernel.org/pub/scm/linux/kernel/git/mips/linux.git/commit/?id=a6ab150deb4b740334721d18e02ad400a9d888f5 I've reverted both patches in mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]