From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: Sasha Levin <sashal@kernel.org>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Zejiang Tang <tangzejiang@loongson.cn>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-mips@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 4.19 08/60] MIPS: ftrace: Remove redundant #ifdef CONFIG_DYNAMIC_FTRACE
Date: Tue, 27 Oct 2020 10:59:43 +0300 [thread overview]
Message-ID: <ac792f50-7bb9-1234-c38a-1d2e32aaf56c@gmail.com> (raw)
In-Reply-To: <20201027000415.1026364-8-sashal@kernel.org>
Hello!
On 27.10.2020 3:03, Sasha Levin wrote:
> From: Zejiang Tang <tangzejiang@loongson.cn>
>
> [ Upstream commit 39116103a7345927fa99644d08bc0cc9d45fea6f ]
>
> There exists redundant #ifdef CONFIG_DYNAMIC_FTRACE in ftrace.c, remove it.
>
> Signed-off-by: Zejiang Tang <tangzejiang@loongson.cn>
> Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
> arch/mips/kernel/ftrace.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/mips/kernel/ftrace.c b/arch/mips/kernel/ftrace.c
> index b122cbb4aad18..7dd52da55907f 100644
> --- a/arch/mips/kernel/ftrace.c
> +++ b/arch/mips/kernel/ftrace.c
> @@ -37,10 +37,6 @@ void arch_ftrace_update_code(int command)
> ftrace_modify_all_code(command);
> }
>
> -#endif
> -
> -#ifdef CONFIG_DYNAMIC_FTRACE
> -
> #define JAL 0x0c000000 /* jump & link: ip --> ra, jump to target */
> #define ADDR_MASK 0x03ffffff /* op_code|addr : 31...26|25 ....0 */
> #define JUMP_RANGE_MASK ((1UL << 28) - 1)
Are you sure this is neccessary in -stable? What bug does it fix?
MBR, Sergei
prev parent reply other threads:[~2020-10-27 7:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201027000415.1026364-1-sashal@kernel.org>
2020-10-27 0:03 ` [PATCH AUTOSEL 4.19 08/60] MIPS: ftrace: Remove redundant #ifdef CONFIG_DYNAMIC_FTRACE Sasha Levin
2020-10-27 7:59 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac792f50-7bb9-1234-c38a-1d2e32aaf56c@gmail.com \
--to=sergei.shtylyov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tangzejiang@loongson.cn \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).