* [PATCH 12/21] EDAC/octeon-l2c: Convert to platform remove callback returning void
2023-10-04 13:12 [PATCH 00/21] EDAC: Convert to platform remove callback returning void Uwe Kleine-König
@ 2023-10-04 13:12 ` Uwe Kleine-König
2023-10-10 14:03 ` Philippe Mathieu-Daudé
2023-10-04 13:12 ` [PATCH 13/21] EDAC/octeon-lmc: " Uwe Kleine-König
` (4 subsequent siblings)
5 siblings, 1 reply; 12+ messages in thread
From: Uwe Kleine-König @ 2023-10-04 13:12 UTC (permalink / raw)
To: Borislav Petkov, Tony Luck
Cc: Ralf Baechle, James Morse, Mauro Carvalho Chehab, Robert Richter,
linux-edac, linux-mips, kernel
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/edac/octeon_edac-l2c.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/edac/octeon_edac-l2c.c b/drivers/edac/octeon_edac-l2c.c
index c33059e9b0be..4015eb9af6fe 100644
--- a/drivers/edac/octeon_edac-l2c.c
+++ b/drivers/edac/octeon_edac-l2c.c
@@ -184,19 +184,17 @@ static int octeon_l2c_probe(struct platform_device *pdev)
return -ENXIO;
}
-static int octeon_l2c_remove(struct platform_device *pdev)
+static void octeon_l2c_remove(struct platform_device *pdev)
{
struct edac_device_ctl_info *l2c = platform_get_drvdata(pdev);
edac_device_del_device(&pdev->dev);
edac_device_free_ctl_info(l2c);
-
- return 0;
}
static struct platform_driver octeon_l2c_driver = {
.probe = octeon_l2c_probe,
- .remove = octeon_l2c_remove,
+ .remove_new = octeon_l2c_remove,
.driver = {
.name = "octeon_l2c_edac",
}
--
2.40.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 12/21] EDAC/octeon-l2c: Convert to platform remove callback returning void
2023-10-04 13:12 ` [PATCH 12/21] EDAC/octeon-l2c: " Uwe Kleine-König
@ 2023-10-10 14:03 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 12+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-10-10 14:03 UTC (permalink / raw)
To: Uwe Kleine-König, Borislav Petkov, Tony Luck
Cc: Ralf Baechle, James Morse, Mauro Carvalho Chehab, Robert Richter,
linux-edac, linux-mips, kernel
On 4/10/23 15:12, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/edac/octeon_edac-l2c.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 13/21] EDAC/octeon-lmc: Convert to platform remove callback returning void
2023-10-04 13:12 [PATCH 00/21] EDAC: Convert to platform remove callback returning void Uwe Kleine-König
2023-10-04 13:12 ` [PATCH 12/21] EDAC/octeon-l2c: " Uwe Kleine-König
@ 2023-10-04 13:12 ` Uwe Kleine-König
2023-10-10 14:02 ` Philippe Mathieu-Daudé
2023-10-04 13:12 ` [PATCH 14/21] EDAC/octeon-pc: " Uwe Kleine-König
` (3 subsequent siblings)
5 siblings, 1 reply; 12+ messages in thread
From: Uwe Kleine-König @ 2023-10-04 13:12 UTC (permalink / raw)
To: Borislav Petkov, Tony Luck
Cc: Ralf Baechle, James Morse, Mauro Carvalho Chehab, Robert Richter,
linux-edac, linux-mips, kernel
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/edac/octeon_edac-lmc.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/edac/octeon_edac-lmc.c b/drivers/edac/octeon_edac-lmc.c
index aeb222ca3ed1..18615cbcd9ea 100644
--- a/drivers/edac/octeon_edac-lmc.c
+++ b/drivers/edac/octeon_edac-lmc.c
@@ -302,18 +302,17 @@ static int octeon_lmc_edac_probe(struct platform_device *pdev)
return 0;
}
-static int octeon_lmc_edac_remove(struct platform_device *pdev)
+static void octeon_lmc_edac_remove(struct platform_device *pdev)
{
struct mem_ctl_info *mci = platform_get_drvdata(pdev);
edac_mc_del_mc(&pdev->dev);
edac_mc_free(mci);
- return 0;
}
static struct platform_driver octeon_lmc_edac_driver = {
.probe = octeon_lmc_edac_probe,
- .remove = octeon_lmc_edac_remove,
+ .remove_new = octeon_lmc_edac_remove,
.driver = {
.name = "octeon_lmc_edac",
}
--
2.40.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 13/21] EDAC/octeon-lmc: Convert to platform remove callback returning void
2023-10-04 13:12 ` [PATCH 13/21] EDAC/octeon-lmc: " Uwe Kleine-König
@ 2023-10-10 14:02 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 12+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-10-10 14:02 UTC (permalink / raw)
To: Uwe Kleine-König, Borislav Petkov, Tony Luck
Cc: Ralf Baechle, James Morse, Mauro Carvalho Chehab, Robert Richter,
linux-edac, linux-mips, kernel
On 4/10/23 15:12, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/edac/octeon_edac-lmc.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 14/21] EDAC/octeon-pc: Convert to platform remove callback returning void
2023-10-04 13:12 [PATCH 00/21] EDAC: Convert to platform remove callback returning void Uwe Kleine-König
2023-10-04 13:12 ` [PATCH 12/21] EDAC/octeon-l2c: " Uwe Kleine-König
2023-10-04 13:12 ` [PATCH 13/21] EDAC/octeon-lmc: " Uwe Kleine-König
@ 2023-10-04 13:12 ` Uwe Kleine-König
2023-10-10 14:03 ` Philippe Mathieu-Daudé
2023-10-04 13:12 ` [PATCH 15/21] EDAC/octeon-pci: " Uwe Kleine-König
` (2 subsequent siblings)
5 siblings, 1 reply; 12+ messages in thread
From: Uwe Kleine-König @ 2023-10-04 13:12 UTC (permalink / raw)
To: Borislav Petkov, Tony Luck
Cc: Ralf Baechle, James Morse, Mauro Carvalho Chehab, Robert Richter,
linux-edac, linux-mips, kernel
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/edac/octeon_edac-pc.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/edac/octeon_edac-pc.c b/drivers/edac/octeon_edac-pc.c
index 754eced59c32..ea8a8e337b1e 100644
--- a/drivers/edac/octeon_edac-pc.c
+++ b/drivers/edac/octeon_edac-pc.c
@@ -119,19 +119,18 @@ static int co_cache_error_probe(struct platform_device *pdev)
return -ENXIO;
}
-static int co_cache_error_remove(struct platform_device *pdev)
+static void co_cache_error_remove(struct platform_device *pdev)
{
struct co_cache_error *p = platform_get_drvdata(pdev);
unregister_co_cache_error_notifier(&p->notifier);
edac_device_del_device(&pdev->dev);
edac_device_free_ctl_info(p->ed);
- return 0;
}
static struct platform_driver co_cache_error_driver = {
.probe = co_cache_error_probe,
- .remove = co_cache_error_remove,
+ .remove_new = co_cache_error_remove,
.driver = {
.name = "octeon_pc_edac",
}
--
2.40.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 14/21] EDAC/octeon-pc: Convert to platform remove callback returning void
2023-10-04 13:12 ` [PATCH 14/21] EDAC/octeon-pc: " Uwe Kleine-König
@ 2023-10-10 14:03 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 12+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-10-10 14:03 UTC (permalink / raw)
To: Uwe Kleine-König, Borislav Petkov, Tony Luck
Cc: Ralf Baechle, James Morse, Mauro Carvalho Chehab, Robert Richter,
linux-edac, linux-mips, kernel
On 4/10/23 15:12, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/edac/octeon_edac-pc.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 15/21] EDAC/octeon-pci: Convert to platform remove callback returning void
2023-10-04 13:12 [PATCH 00/21] EDAC: Convert to platform remove callback returning void Uwe Kleine-König
` (2 preceding siblings ...)
2023-10-04 13:12 ` [PATCH 14/21] EDAC/octeon-pc: " Uwe Kleine-König
@ 2023-10-04 13:12 ` Uwe Kleine-König
2023-10-10 14:03 ` Philippe Mathieu-Daudé
2023-11-20 16:20 ` [PATCH 00/21] EDAC: " Uwe Kleine-König
2023-11-20 22:36 ` Borislav Petkov
5 siblings, 1 reply; 12+ messages in thread
From: Uwe Kleine-König @ 2023-10-04 13:12 UTC (permalink / raw)
To: Borislav Petkov, Tony Luck
Cc: Ralf Baechle, James Morse, Mauro Carvalho Chehab, Robert Richter,
linux-edac, linux-mips, kernel
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/edac/octeon_edac-pci.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/edac/octeon_edac-pci.c b/drivers/edac/octeon_edac-pci.c
index 28b238eecefc..108ad9493cfb 100644
--- a/drivers/edac/octeon_edac-pci.c
+++ b/drivers/edac/octeon_edac-pci.c
@@ -87,19 +87,17 @@ static int octeon_pci_probe(struct platform_device *pdev)
return res;
}
-static int octeon_pci_remove(struct platform_device *pdev)
+static void octeon_pci_remove(struct platform_device *pdev)
{
struct edac_pci_ctl_info *pci = platform_get_drvdata(pdev);
edac_pci_del_device(&pdev->dev);
edac_pci_free_ctl_info(pci);
-
- return 0;
}
static struct platform_driver octeon_pci_driver = {
.probe = octeon_pci_probe,
- .remove = octeon_pci_remove,
+ .remove_new = octeon_pci_remove,
.driver = {
.name = "octeon_pci_edac",
}
--
2.40.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 15/21] EDAC/octeon-pci: Convert to platform remove callback returning void
2023-10-04 13:12 ` [PATCH 15/21] EDAC/octeon-pci: " Uwe Kleine-König
@ 2023-10-10 14:03 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 12+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-10-10 14:03 UTC (permalink / raw)
To: Uwe Kleine-König, Borislav Petkov, Tony Luck
Cc: Ralf Baechle, James Morse, Mauro Carvalho Chehab, Robert Richter,
linux-edac, linux-mips, kernel
On 4/10/23 15:12, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/edac/octeon_edac-pci.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 00/21] EDAC: Convert to platform remove callback returning void
2023-10-04 13:12 [PATCH 00/21] EDAC: Convert to platform remove callback returning void Uwe Kleine-König
` (3 preceding siblings ...)
2023-10-04 13:12 ` [PATCH 15/21] EDAC/octeon-pci: " Uwe Kleine-König
@ 2023-11-20 16:20 ` Uwe Kleine-König
2023-11-20 17:21 ` Borislav Petkov
2023-11-20 22:36 ` Borislav Petkov
5 siblings, 1 reply; 12+ messages in thread
From: Uwe Kleine-König @ 2023-11-20 16:20 UTC (permalink / raw)
To: Borislav Petkov, Tony Luck
Cc: Tomer Maimon, linux-aspeed, Tali Perry, Shubhrajyoti Datta,
Sai Krishna Potthuri, Khuong Dinh, Benjamin Fair, Dinh Nguyen,
openbmc, Nancy Yuen, Andy Gross, Joel Stanley, linux-arm-msm,
Stanley Chu, Robert Richter, Jan Luebbe, Shravan Kumar Ramani,
Manivannan Sadhasivam, Andre Przywara, Mauro Carvalho Chehab,
Michal Simek, linux-arm-kernel, linux-edac, Johannes Thumshirn,
Tero Kristo, Avi Fishman, Patrick Venture, Bjorn Andersson,
linux-mips, Ralf Baechle, Konrad Dybcio, Andrew Jeffery,
James Morse, kernel, Lei Wang, Stefan Schaeckeler, Marvin Lin
[-- Attachment #1: Type: text/plain, Size: 1418 bytes --]
Hello Boris, hello Tony,
On Wed, Oct 04, 2023 at 03:12:33PM +0200, Uwe Kleine-König wrote:
> this series converts all platform drivers below drivers/edac to use
> .remove_new(). The motivation is to get rid of an integer return code
> that is (mostly) ignored by the platform driver core and error prone on
> the driver side. However none of the edac drivers suffered from the easy
> to make bug, so all drivers are converted in a trivial way.
>
> See commit 5c5a7680e67b ("platform: Provide a remove callback that
> returns no value") for an extended explanation and the eventual goal.
>
> The patch for npcm was already sent back in June
> (https://lore.kernel.org/linux-edac/20230628071354.665300-1-u.kleine-koenig@pengutronix.de)
> but didn't result in enthusiastic review comments and it wasn't picked
> up.
>
> There are no interdependencies between the patches. As there are still
> quite a few drivers to convert, I'm happy about every patch that makes
> it in. So even if there is a merge conflict with one patch until you
> apply, please apply the remainder of this series anyhow. I'll come back
> to the part that you (maybe) skipped at a later point.
Any news on this series? Would a resend help?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 00/21] EDAC: Convert to platform remove callback returning void
2023-11-20 16:20 ` [PATCH 00/21] EDAC: " Uwe Kleine-König
@ 2023-11-20 17:21 ` Borislav Petkov
0 siblings, 0 replies; 12+ messages in thread
From: Borislav Petkov @ 2023-11-20 17:21 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Tony Luck, Tomer Maimon, linux-aspeed, Tali Perry,
Shubhrajyoti Datta, Sai Krishna Potthuri, Khuong Dinh,
Benjamin Fair, Dinh Nguyen, openbmc, Nancy Yuen, Andy Gross,
Joel Stanley, linux-arm-msm, Stanley Chu, Robert Richter,
Jan Luebbe, Shravan Kumar Ramani, Manivannan Sadhasivam,
Andre Przywara, Mauro Carvalho Chehab, Michal Simek,
linux-arm-kernel, linux-edac, Johannes Thumshirn, Tero Kristo,
Avi Fishman, Patrick Venture, Bjorn Andersson, linux-mips,
Ralf Baechle, Konrad Dybcio, Andrew Jeffery, James Morse, kernel,
Lei Wang, Stefan Schaeckeler, Marvin Lin
On Mon, Nov 20, 2023 at 05:20:54PM +0100, Uwe Kleine-König wrote:
> Any news on this series? Would a resend help?
Nah, lemme have a look.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 00/21] EDAC: Convert to platform remove callback returning void
2023-10-04 13:12 [PATCH 00/21] EDAC: Convert to platform remove callback returning void Uwe Kleine-König
` (4 preceding siblings ...)
2023-11-20 16:20 ` [PATCH 00/21] EDAC: " Uwe Kleine-König
@ 2023-11-20 22:36 ` Borislav Petkov
5 siblings, 0 replies; 12+ messages in thread
From: Borislav Petkov @ 2023-11-20 22:36 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Tony Luck, Dinh Nguyen, James Morse, Mauro Carvalho Chehab,
Robert Richter, linux-edac, kernel, Jan Luebbe,
Stefan Schaeckeler, Joel Stanley, Andrew Jeffery,
linux-arm-kernel, linux-aspeed, Shravan Kumar Ramani, Lei Wang,
Andre Przywara, Johannes Thumshirn, Avi Fishman, Tomer Maimon,
Tali Perry, Patrick Venture, Nancy Yuen, Benjamin Fair,
Marvin Lin, Stanley Chu, openbmc, Ralf Baechle, linux-mips,
Manivannan Sadhasivam, Andy Gross, Bjorn Andersson, Konrad Dybcio,
linux-arm-msm, Michal Simek, Tero Kristo, Khuong Dinh,
Shubhrajyoti Datta, Sai Krishna Potthuri
On Wed, Oct 04, 2023 at 03:12:33PM +0200, Uwe Kleine-König wrote:
> Uwe Kleine-König (21):
> EDAC/altera: Convert to platform remove callback returning void
> EDAC/armada_xp: Convert to platform remove callback returning void
> EDAC/aspeed: Convert to platform remove callback returning void
> EDAC/bluefield: Convert to platform remove callback returning void
> EDAC/cell: Convert to platform remove callback returning void
> EDAC/cpc925: Convert to platform remove callback returning void
> EDAC/dmc520: Convert to platform remove callback returning void
> EDAC/highbank_l2: Convert to platform remove callback returning void
> EDAC/highbank_mc: Convert to platform remove callback returning void
> EDAC/mpc85xx: Convert to platform remove callback returning void
> EDAC/npcm: Convert to platform remove callback returning void
> EDAC/octeon-l2c: Convert to platform remove callback returning void
> EDAC/octeon-lmc: Convert to platform remove callback returning void
> EDAC/octeon-pc: Convert to platform remove callback returning void
> EDAC/octeon-pci: Convert to platform remove callback returning void
> EDAC/ppc4xx: Convert to platform remove callback returning void
> EDAC/qcom: Convert to platform remove callback returning void
> EDAC/synopsys: Convert to platform remove callback returning void
> EDAC/ti: Convert to platform remove callback returning void
> EDAC/xgene: Convert to platform remove callback returning void
> EDAC/zynqmp: Convert to platform remove callback returning void
All applied, thanks.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 12+ messages in thread