Re: [resend, PATCH v2 1/1] MIPS: Alchemy: Remove unused forward declaration

Thomas Bogendoerfer
2026-04-13T13:45:20Z

On Fri, Mar 20, 2026 at 09:28:08PM +0100, Andy Shevchenko wrote:
> The 'struct gpio' is not used in the code, remove unneeded forward declaration.
> This seems to be a leftover for a 5 years.
>
> Acked-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>
> v2 (resend): Cc'ed to GPIO maintainers and ML
> v2: collected tags (Thomas)
>
> Bart, it was agreed to take this patch via GPIO tree
> (that's why we have an Ack), can you apply it, please?
>
> arch/mips/include/asm/mach-au1x00/gpio-au1000.h | 2 --
> arch/mips/include/asm/mach-au1x00/gpio-au1300.h | 1 -
> 2 files changed, 3 deletions(-)
>
> diff --git a/arch/mips/include/asm/mach-au1x00/gpio-au1000.h b/arch/mips/include/asm/mach-au1x00/gpio-au1000.h
> index d820b481ac56..e6306f6820e6 100644
> --- a/arch/mips/include/asm/mach-au1x00/gpio-au1000.h
> +++ b/arch/mips/include/asm/mach-au1x00/gpio-au1000.h
> @@ -40,8 +40,6 @@
> #define AU1000_GPIO2_INTENABLE 0x10
> #define AU1000_GPIO2_ENABLE 0x14
>
> -struct gpio;
> -
> static inline int au1000_gpio1_to_irq(int gpio)
> {
> return MAKE_IRQ(1, gpio - ALCHEMY_GPIO1_BASE);
> diff --git a/arch/mips/include/asm/mach-au1x00/gpio-au1300.h b/arch/mips/include/asm/mach-au1x00/gpio-au1300.h
> index 43d44f384f97..b12f37262cfa 100644
> --- a/arch/mips/include/asm/mach-au1x00/gpio-au1300.h
> +++ b/arch/mips/include/asm/mach-au1x00/gpio-au1300.h
> @@ -12,7 +12,6 @@
> #include <asm/io.h>
> #include <asm/mach-au1x00/au1000.h>
>
> -struct gpio;
> struct gpio_chip;
>
> /* with the current GPIC design, up to 128 GPIOs are possible.
> --
> 2.50.1

applied to mips-next

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]