Re: [PATCH v4 2/2] iio: adc: ingenic-adc: use guard()() to handle synchronisation

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Wed, Apr 22, 2026 at 10:18:31PM -0300, Felipe Ribeiro de Souza wrote:
> Replace mutex_lock() and mutex_unlock() calls with guard()()
> in functions ingenic_adc_set_adcmd(), ingenic_adc_set_config(),
> ingenic_adc_enable(), ingenic_adc_capture() and
> ingenic_adc_read_chan_locked().
> 
> This removes the need to call the unlock function, as the lock is
> automatically released when the function return or the scope exits
> for any other case.

...

> static int ingenic_adc_read_chan_locked(struct ingenic_adc *adc,

>  	switch (chan->channel) {
>  	case INGENIC_ADC_AUX0:

>  		break;
>  	}
>  
> -	ret = IIO_VAL_INT;
> -out:
> -	mutex_unlock(&adc->aux_lock);
> -
> -	return ret;
> +	return IIO_VAL_INT;
>  }

Just a side note (it was already like this in the original code).
The switch-case has no default case and in unlikely event of code
modification or run-time flow we will return this instead of some
error code. That said, I think it's better to return directly from
each of the cases and add default case with an error code returned
(probably in a preparatory patch?). In any case it's up to you and
maintainers, since your patch doesn't change the state of affairs.

-- 
With Best Regards,
Andy Shevchenko