Re: [PATCH v5 3/3] iio: adc: ingenic-adc: use guard()() and scoped_guard() to handle synchronisation

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Tue, May 05, 2026 at 11:24:30PM -0300, Felipe Ribeiro de Souza wrote:
> Replace mutex_lock() and mutex_unlock() calls with guard()() in
> functions ingenic_adc_set_adcmd(), ingenic_adc_set_config(),
> ingenic_adc_enable(), ingenic_adc_capture(), and with scoped_guard()
> in function ingenic_adc_read_chan_info_raw().
> 
> This removes the need to call the unlock function, as the lock is
> automatically released when the function return or the scope exits
> for any other case.

...

>  static void ingenic_adc_set_config(struct ingenic_adc *adc,
>  {
>  	uint32_t cfg;

Side note: We use uXX types in the kernel (you can do a separate change
if you want to).

>  
> -	mutex_lock(&adc->lock);
> +	guard(mutex)(&adc->lock);
>  
>  	cfg = readl(adc->base + JZ_ADC_REG_CFG) & ~mask;
>  	cfg |= val;
>  	writel(cfg, adc->base + JZ_ADC_REG_CFG);

Side note (in case you want another patch): this is not so robust against
arbitrary values. The traditional pattern of custom FIELD_MODIFY() is this

	cfg = readl(adc->base + JZ_ADC_REG_CFG);
	cfg = (cfg & ~mask) | (val & mask);
	writel(cfg, adc->base + JZ_ADC_REG_CFG);

> -	mutex_unlock(&adc->lock);
>  }

-- 
With Best Regards,
Andy Shevchenko