Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: DEC: Remove IRQF_ONESHOT reference for IOASIC DMA error IRQs
Date: Tue, 26 May 2026 16:44:52 +0200	[thread overview]
Message-ID: <ahWx5MX00R64nanU@alpha.franken.de> (raw)
In-Reply-To: <alpine.DEB.2.21.2605061142040.46195@angie.orcam.me.uk>

On Wed, May 06, 2026 at 12:15:21PM +0100, Maciej W. Rozycki wrote:
> There is no need for IOASIC DMA error interrupts to use the IRQF_ONESHOT 
> flag, because while they do need to have the source cleared only at the 
> conclusion of handling, the action handler supplied is either run in the 
> hardirq context with interrupts disabled at the CPU level or, where IRQ 
> threading has been forced, the primary handler has the IRQF_ONESHOT flag 
> implicitly added and therefore the original action handler, now run as 
> the thread handler and with interrupts enabled in the CPU, is executed 
> with the originating interrupt line masked.  Therefore no interrupt will 
> retrigger regardless until the original request has been handled.
> 
> Link: https://lore.kernel.org/r/20260127135334.qUEaYP9G@linutronix.de/
> Reported-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Signed-off-by: Maciej W. Rozycki <macro@orcam.me.uk>
> ---
>  arch/mips/dec/ioasic-irq.c |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

applied to mips-next

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

      parent reply	other threads:[~2026-05-26 14:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-06 11:15 [PATCH] MIPS: DEC: Remove IRQF_ONESHOT reference for IOASIC DMA error IRQs Maciej W. Rozycki
2026-05-07  7:37 ` Sebastian Andrzej Siewior
2026-05-26 14:44 ` Thomas Bogendoerfer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ahWx5MX00R64nanU@alpha.franken.de \
    --to=tsbogend@alpha.franken.de \
    --cc=bigeasy@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=macro@orcam.me.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox