From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A52D33FFAC9; Tue, 26 May 2026 14:51:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.175.24.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779807073; cv=none; b=cm9YNnyZFBVst48hkehHlZGGd+mw9909//YRq6sNrnDMLTilHWArvjQoV9Z8i7peTna0N/37cge+zsALosWXaT5UJzgeqFiN0t/KHCcpZmDVYOArDqJX0cxM3eTojpm/5SYk9MBxwyJISGkMcR9paVqoMv1Wll6PghdfTd60RAM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779807073; c=relaxed/simple; bh=BnM24aUmG4hUkWM1tGDWc1bPkuyqU4HNs4flfH0eTCk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UDhtjQXZqW5L18ly+7cHrLVLpLRequL6ZzjAhidgAb/y5HDTOhubJR+AwFk6n7Sy2fAwS/xv9ki7cAEuhDjzmc4n+wQde/AuiDt4o/BgxUtUm7qHwxw3mxnIjTFBBDj2Ax9HFhp2juYL83vBSAgEorg7qtGTl3T06Cp9X+fFnIE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de; spf=pass smtp.mailfrom=alpha.franken.de; arc=none smtp.client-ip=193.175.24.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alpha.franken.de Received: from uucp by elvis.franken.de with local-rmail (Exim 3.36 #1) id 1wRt7c-00015J-00; Tue, 26 May 2026 16:51:08 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 9F760C064C; Tue, 26 May 2026 16:43:47 +0200 (CEST) Date: Tue, 26 May 2026 16:43:47 +0200 From: Thomas Bogendoerfer To: Bartosz Golaszewski Cc: brgl@kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] MIPS: RB532: serial: statify setup_serial_port() Message-ID: References: <20260430112410.65986-1-bartosz.golaszewski@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260430112410.65986-1-bartosz.golaszewski@oss.qualcomm.com> On Thu, Apr 30, 2026 at 01:24:10PM +0200, Bartosz Golaszewski wrote: > This function is not used outside of this compilation unit so make it > static. > > Signed-off-by: Bartosz Golaszewski > --- > arch/mips/rb532/serial.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/mips/rb532/serial.c b/arch/mips/rb532/serial.c > index 70482540b3dbc..228eff07e5e85 100644 > --- a/arch/mips/rb532/serial.c > +++ b/arch/mips/rb532/serial.c > @@ -45,7 +45,7 @@ static struct uart_port rb532_uart = { > .regshift = 2 > }; > > -int __init setup_serial_port(void) > +static int __init setup_serial_port(void) > { > rb532_uart.uartclk = idt_cpu_freq; > > -- > 2.47.3 applied to mips-next Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]