From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Ethan Nelson-Moore <enelsonmoore@gmail.com>
Cc: linux-mips@vger.kernel.org
Subject: Re: [PATCH] MIPS: mm: remove comment referring to removed CONFIG_MIPS_CMP
Date: Tue, 16 Jun 2026 13:01:36 +0200 [thread overview]
Message-ID: <ajEtEMekGrzaJeeG@alpha.franken.de> (raw)
In-Reply-To: <20260610220124.97261-1-enelsonmoore@gmail.com>
On Wed, Jun 10, 2026 at 03:01:22PM -0700, Ethan Nelson-Moore wrote:
> CMP support was removed in commit 7fb6f7b0af67 ("MIPS: Remove
> deprecated CONFIG_MIPS_CMP"), but a comment referring to it remained in
> arch/mips/mm/c-r4k.c. Remove it.
>
> Discovered while searching for CONFIG_* symbols referenced in code but
> not defined in any Kconfig file.
>
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
> ---
> arch/mips/mm/c-r4k.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/arch/mips/mm/c-r4k.c b/arch/mips/mm/c-r4k.c
> index 10413b6f6662..d8aadd3dc057 100644
> --- a/arch/mips/mm/c-r4k.c
> +++ b/arch/mips/mm/c-r4k.c
> @@ -1757,11 +1757,6 @@ void r4k_cache_init(void)
> build_clear_page();
> build_copy_page();
>
> - /*
> - * We want to run CMP kernels on core with and without coherent
> - * caches. Therefore, do not use CONFIG_MIPS_CMP to decide whether
> - * or not to flush caches.
> - */
> local_r4k___flush_cache_all(NULL);
>
> coherency_setup();
> --
> 2.43.0
applied to mips-next
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2026-06-16 11:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 22:01 [PATCH] MIPS: mm: remove comment referring to removed CONFIG_MIPS_CMP Ethan Nelson-Moore
2026-06-16 11:01 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajEtEMekGrzaJeeG@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=enelsonmoore@gmail.com \
--cc=linux-mips@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox