From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Tony Wu <tung7970@gmail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
Steven.Hill@imgtec.com, david.daney@cavium.com,
linux-mips@linux-mips.org
Subject: Re: [PATCH v3 1/3] MIPS: microMIPS: Fix POOL16C minor opcode enum
Date: Mon, 27 May 2013 13:32:03 +0100 (BST) [thread overview]
Message-ID: <alpine.LFD.2.03.1305271329520.18557@linux-mips.org> (raw)
In-Reply-To: <20130527105959.GB31548@hades>
On Mon, 27 May 2013, Tony Wu wrote:
> diff --git a/arch/mips/include/uapi/asm/inst.h b/arch/mips/include/uapi/asm/inst.h
> index 0f4aec2..473a2ac 100644
> --- a/arch/mips/include/uapi/asm/inst.h
> +++ b/arch/mips/include/uapi/asm/inst.h
> @@ -409,10 +409,11 @@ enum mm_32f_73_minor_op {
> enum mm_16c_minor_op {
> mm_lwm16_op = 0x04,
> mm_swm16_op = 0x05,
> - mm_jr16_op = 0x18,
> - mm_jrc_op = 0x1a,
> - mm_jalr16_op = 0x1c,
> - mm_jalrs16_op = 0x1e,
> + mm_jr16_op = 0x0c,
> + mm_jraddiusp_op = 0x18,
> + mm_jrc_op = 0x0d,
> + mm_jalr16_op = 0x1e,
> + mm_jalrs16_op = 0x1f,
> };
Please keep these sorted by value, and also mm_jalr16_op and
mm_jalrs16_op are wrong.
Maciej
next prev parent reply other threads:[~2013-05-27 12:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-27 10:58 [PATCH v3 0/3] MIPS: microMIPS: Refactor get_frame_info support Tony Wu
2013-05-27 10:59 ` [PATCH v3 1/3] MIPS: microMIPS: Fix POOL16C minor opcode enum Tony Wu
2013-05-27 12:32 ` Maciej W. Rozycki [this message]
2013-05-27 11:01 ` [PATCH v3 2/3] MIPS: microMIPS: Add kernel_uses_mmips in cpu-features.h Tony Wu
2013-05-27 11:02 ` [PATCH v3 3/3] MIPS: microMIPS: Refactor get_frame_info support Tony Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.03.1305271329520.18557@linux-mips.org \
--to=macro@linux-mips.org \
--cc=Steven.Hill@imgtec.com \
--cc=david.daney@cavium.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=tung7970@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox