Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: "Steven J. Hill" <Steven.Hill@imgtec.com>
Cc: linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>,
	ddaney.cavm@gmail.com
Subject: Re: [PATCH v4] MIPS: micromips: Fix improper definition of ISA exception bit.
Date: Wed, 5 Jun 2013 20:08:44 +0100 (BST)	[thread overview]
Message-ID: <alpine.LFD.2.03.1306052004030.15274@linux-mips.org> (raw)
In-Reply-To: <1370455529-19621-1-git-send-email-Steven.Hill@imgtec.com>

On Wed, 5 Jun 2013, Steven J. Hill wrote:

> diff --git a/arch/mips/mti-malta/malta-init.c b/arch/mips/mti-malta/malta-init.c
> index ff8caff..76e0205 100644
> --- a/arch/mips/mti-malta/malta-init.c
> +++ b/arch/mips/mti-malta/malta-init.c
> @@ -106,6 +106,8 @@ extern struct plat_smp_ops msmtc_smp_ops;
>  
>  void __init prom_init(void)
>  {
> +	set_micromips_exception_mode();
> +
>  	mips_display_message("LINUX");
>  
>  	/*
> diff --git a/arch/mips/mti-sead3/sead3-init.c b/arch/mips/mti-sead3/sead3-init.c
> index bfbd17b..9e314cb 100644
> --- a/arch/mips/mti-sead3/sead3-init.c
> +++ b/arch/mips/mti-sead3/sead3-init.c
> @@ -130,6 +130,8 @@ static void __init mips_ejtag_setup(void)
>  
>  void __init prom_init(void)
>  {
> +	set_micromips_exception_mode();
> +
>  	board_nmi_handler_setup = mips_nmi_setup;
>  	board_ejtag_handler_setup = mips_ejtag_setup;

 Shouldn't this be in a generic place such as trap_init instead?

  Maciej

  parent reply	other threads:[~2013-06-05 19:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-05 18:05 [PATCH v4] MIPS: micromips: Fix improper definition of ISA exception bit Steven J. Hill
2013-06-05 18:20 ` David Daney
2013-06-05 19:08 ` Maciej W. Rozycki [this message]
2013-06-05 19:12   ` David Daney
2013-06-05 19:26     ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.03.1306052004030.15274@linux-mips.org \
    --to=macro@linux-mips.org \
    --cc=Steven.Hill@imgtec.com \
    --cc=ddaney.cavm@gmail.com \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox