From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <paul.burton@mips.com>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] MIPS: SiByte: Enable swiotlb for SWARM and BigSur
Date: Wed, 7 Nov 2018 11:14:00 +0000 (GMT) [thread overview]
Message-ID: <alpine.LFD.2.21.1811071108150.20378@eddie.linux-mips.org> (raw)
In-Reply-To: <20181107075923.GD24381@lst.de>
On Wed, 7 Nov 2018, Christoph Hellwig wrote:
> Do we really need a new source file just to call swiotlb_init?
I think it being a separate file is actually good, as it saves a little
bit of code space at run time if this is not used without the need to
wrap the entire function into #ifdef.
> And
> if we do that file should have a SPDX header these days.
It does or I have missed something.
Thanks for your review.
Maciej
prev parent reply other threads:[~2018-11-07 11:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 0:08 [PATCH 2/2] MIPS: SiByte: Enable swiotlb for SWARM and BigSur Maciej W. Rozycki
2018-11-07 7:59 ` Christoph Hellwig
2018-11-07 11:14 ` Maciej W. Rozycki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.1811071108150.20378@eddie.linux-mips.org \
--to=macro@linux-mips.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=paul.burton@mips.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox