From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Paul Burton <paul.burton@mips.com>
Cc: "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>,
Paul Burton <pburton@wavecomp.com>
Subject: Re: [PATCH] MIPS: Hardcode cpu_has_mmips=1 for microMIPS kernels
Date: Thu, 29 Nov 2018 14:04:35 +0000 (GMT) [thread overview]
Message-ID: <alpine.LFD.2.21.1811291400290.20367@eddie.linux-mips.org> (raw)
In-Reply-To: <20181128223340.xocdpwtb6adl4prn@pburton-laptop>
Hi Paul,
> > > -# ifdef CONFIG_SYS_SUPPORTS_MICROMIPS
> > > +# if defined(__mips_micromips)
> >
> > Wouldn't it be cleaner if it was written:
> >
> > # if defined(CONFIG_CPU_MICROMIPS)
>
> I suppose it's just a matter of preference - in practice both ought to
> be defined or undefined at the same times. My personal preference is the
> standard macro provided by the compiler, so that's what I used.
The minor difference as I see it is that CONFIG_CPU_MICROMIPS is ours
and the primary knob while `__mips_micromips' is GCC's. I don't see it as
a big problem if any at all, it's just my guts feeling.
Do we have a consistency check between the two macros anywhere?
Maciej
prev parent reply other threads:[~2018-11-29 14:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 23:19 [PATCH] MIPS: Hardcode cpu_has_mmips=1 for microMIPS kernels Paul Burton
2018-11-13 22:22 ` Paul Burton
2018-11-13 22:22 ` Paul Burton
2018-11-28 3:10 ` Maciej W. Rozycki
2018-11-28 22:33 ` Paul Burton
2018-11-29 14:04 ` Maciej W. Rozycki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.1811291400290.20367@eddie.linux-mips.org \
--to=macro@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=paul.burton@mips.com \
--cc=pburton@wavecomp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox