From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EE1CC433FE for ; Mon, 7 Dec 2020 15:36:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CADE423731 for ; Mon, 7 Dec 2020 15:36:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725887AbgLGPgB (ORCPT ); Mon, 7 Dec 2020 10:36:01 -0500 Received: from [157.25.102.26] ([157.25.102.26]:58306 "EHLO orcam.me.uk" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725822AbgLGPgB (ORCPT ); Mon, 7 Dec 2020 10:36:01 -0500 Received: from bugs.linux-mips.org (eddie.linux-mips.org [IPv6:2a01:4f8:201:92aa::3]) by orcam.me.uk (Postfix) with ESMTPS id 76CAD2BE0EC; Mon, 7 Dec 2020 15:35:28 +0000 (GMT) Date: Mon, 7 Dec 2020 15:35:23 +0000 (GMT) From: "Maciej W. Rozycki" To: Thomas Bogendoerfer cc: Jinyang He , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] MIPS: KASLR: Fix sync_icache() trapped in loop when synci_step is zero In-Reply-To: <20201202103943.GA9065@alpha.franken.de> Message-ID: References: <1606878005-11427-1-git-send-email-hejinyang@loongson.cn> <20201202103943.GA9065@alpha.franken.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Wed, 2 Dec 2020, Thomas Bogendoerfer wrote: > PS: Does anybody know a reason, why this code doesn't use an old fashioned > dache/icache flushing, which might be slower but would work also on > legecy cores ? Hmm, this was contributed by ImgTec in 2016 only, so I guess there was no reason as such but merely the lack of care about older systems (mind that those people really didn't have any at that point). The option to enable this code is only available for R2 and newer CPUs so at least we are safe. Maciej