From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Anders Roxell <anders.roxell@linaro.org>
Cc: tsbogend@alpha.franken.de, natechancellor@gmail.com,
ndesaulniers@google.com, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com
Subject: Re: [PATCH v2] mips: lib: uncached: fix non-standard usage of variable 'sp'
Date: Fri, 11 Dec 2020 19:54:07 +0000 (GMT) [thread overview]
Message-ID: <alpine.LFD.2.21.2012111950290.2104409@eddie.linux-mips.org> (raw)
In-Reply-To: <20201211102437.3929348-1-anders.roxell@linaro.org>
On Fri, 11 Dec 2020, Anders Roxell wrote:
> diff --git a/arch/mips/lib/uncached.c b/arch/mips/lib/uncached.c
> index 09d5deea747f..f80a67c092b6 100644
> --- a/arch/mips/lib/uncached.c
> +++ b/arch/mips/lib/uncached.c
> @@ -37,10 +37,12 @@
> */
> unsigned long run_uncached(void *func)
> {
> - register long sp __asm__("$sp");
> register long ret __asm__("$2");
> long lfunc = (long)func, ufunc;
> long usp;
> + long sp;
> +
> + __asm__("move %0, $sp" : "=r" (sp));
I thought it might be better to make `sp' global instead, so that it's
the compiler that chooses how to schedule accesses. Have you tried that?
Maciej
next prev parent reply other threads:[~2020-12-11 21:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 10:24 [PATCH v2] mips: lib: uncached: fix non-standard usage of variable 'sp' Anders Roxell
2020-12-11 19:15 ` Nick Desaulniers
2020-12-11 19:54 ` Maciej W. Rozycki [this message]
2020-12-12 5:52 ` Nathan Chancellor
2020-12-14 15:24 ` Thomas Bogendoerfer
2020-12-20 4:07 ` Naresh Kamboju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.2012111950290.2104409@eddie.linux-mips.org \
--to=macro@linux-mips.org \
--cc=anders.roxell@linaro.org \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox