From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1FE063F4DD7; Thu, 23 Jul 2026 08:41:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784796101; cv=none; b=nWjQQukmSckc+0IiDc0YUpux5Up/P4mISR+/XSHc3lnNhBcsDDg/jlGoscQtQMu2TBya2xZdRh64TdCosmhc6IAcdESlcWZegfdsOPCaQskqSqZE66yteO/1P3pHye9ggR3vTVL7rp4kiQKpI2nswQWkcQoM+GBcoVmUNGodA3c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784796101; c=relaxed/simple; bh=tHu7RoxBrkiUeHKCDkL/iuN7wAUGu94jRhPQyIZkpMA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jDqc9caNL+NCF/houPbBM3gU1vhBxO4PXvTBZl6IM4z3utWbsaQ4MTQyzPmkKPhRBHwTbtePYDbgsWznn4xKKOHNapG7RNSVyYMLJ8tD1MihYOhdxciNfNQDTaS/ori7Ge5WIndC+91gYGKxVNGTpmFrfBG4737L4/iXSUAg9+s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=jyYf5dBq; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="jyYf5dBq" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4EB931477; Thu, 23 Jul 2026 01:41:33 -0700 (PDT) Received: from e129823.arm.com (e129823.arm.com [10.2.213.3]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C5BC73F86F; Thu, 23 Jul 2026 01:41:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1784796097; bh=tHu7RoxBrkiUeHKCDkL/iuN7wAUGu94jRhPQyIZkpMA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jyYf5dBqTJ1JCBs2GdetKtKebNTFujQgVNyM9FlYh+7WTSQ44Nzs8Y0U/Zcu3/0DZ F8o/mRcYZmN03NpFHUsVhYRsCOYeSG6tNiL+HHlZLY027DY2RfvehP4Hk242KMbom8 Y5LydIRYAz0Vbe5p9VsHCQl+hb7z9+8dMD0K2N00= Date: Thu, 23 Jul 2026 09:41:33 +0100 From: Yeoreum Yun To: David.Hildenbrand@arm.com, david@kernel.rog Cc: yeoruem.yun@arm.com, Yeoreum Yun , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-openrisc@vger.kernel.org Subject: Re: [INTERNAL REVIEW] [RFC PATCH v3 01/20] mm: change behavior of pXdp_get()/pXd_page() in compile-time folded pgtable Message-ID: References: <20260723081036.1461495-1-yeoreum.yun@arm.com> <20260723081036.1461495-2-yeoreum.yun@arm.com> Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260723081036.1461495-2-yeoreum.yun@arm.com> Sorry for making a noise. I've posted wrongly. Please, ignore this. Thanks! > Using ptep_get() and its counterparts in common code is suboptimal on > kernel configurations with generic compile-time folded page tables. > By default, ptep_get() and its friends expands to READ_ONCE(), > forcing the compiler to emit a load even when the value is not used afterwards. > > This issue was recently reported by Christophe Leroy [1] for ppc32 > preventing futher code conversion to ptep_get()/pmdp_get()/... helper > and the same behavior can also be observed on arm64 when built with > 2- or 3-level page tables > > e.g) perf_get_page_size() in arm64 with CONFIG_PGTABLE_LEVEL=3: > > 00000000000052a0 : > ... > 52dc: d53b4234 mrs x20, DAIF > 52e0: d50343df msr DAIFSet, #0x3 > ... > 52fc: d35e9a69 ubfx x9, x19, #30, #9 /* pud_offset_lockless() */ > 5300: f9403508 ldr x8, [x8, #0x68] > 5304: f869790a ldr x10, [x8, x9, lsl #3] /* pudp_get() */ > 5308: f90007ea str x10, [sp, #0x8] > 530c: f8697908 ldr x8, [x8, x9, lsl #3] /* pudp_get() */ > ... > 5360: 90000009 adrp x9, 0x5000 > 5364: 92746908 and x8, x8, #0x7ffffff000 > 5368: d3557675 ubfx x21, x19, #21, #9 /* pmd_offset_lockless() */ > ... > 5394: f8757ac8 ldr x8, [x22, x21, lsl #3] /* pmdp_get() */ > > Though PGTABLE_LEVEL=3, since the pudp_get() still remain with > READ_ONCE(), there's redundant load for the pud which is folded. > > To prevent generating suboptimal code, make pXdp_get() return a dummy > entry for compile-time folded page tables and prohibit calls to > pXd_page() in pgtable-nopXd.h. > > Also make the helpers in pgtable-nopXd.h, such as pXd_offset_lockless(), > validate dummy entries at compile time to catch the wrong usage. > > As the pXdp_get() can return *dummy* entry, some of code using > the stack value where saves the pXdp_get() could be a problematic: > > 1. Passing address of stack value where saves the pXdp_get() result > to pXd_offset() for example: > > pud_t *pudp, pud; > pmd_t *pmdp; > > pud = pudp_get(pudp, address); > pmdp = pmd_offset(&pud, pud, address); > > (e.g. host_pfn_mapping_level() in loongarch). > > 2. Using the pXdp_get() result to use as argument of pXd_val() and > to check prot without checking pgtable is folded. > for example, x86's effective_prot(). > > 3. Using set_pXd() with pXdp_get() will set problematic dummy entry > in folded page table like: > > set_pXd(pxdp, pXdp_get(pxdp_k)); > > 4. Using pgd_page_vaddr() to get the first-level pgtable. > passing dummy pxdp_get() for pgd_page_vaddr() will return wrong > address. Therefore, make pgd_page_vaddr() and pXd_pgtable() to > trigger the error for improper usage with folded dummy entry in the > generic compile-time folded pgtable. > > Thanksfully, above cases are rare since (1) most of usage using > pXd_offset() with result of upper pXd_offset(), (2) it's extreamely > rare to use pXd_val() for non-leaf entry in the kernel, > (3) is to handle the vmalloc_fault or set the first level of page table > and (4) to setup early page table and etc. > > Therefore, convert this kind of problematic rare pattern properly. > > Furthermore, passing the ptep_get() (or its counterparts) as argument > directly to pte_present() and related helpers can generate suboptimal code, > in arm64 as the current macro implementation may evaluate its argument > more than once like: > > !pte_val(READ_ONCE(*pte) || pte_present_invalid(READ_ONCE(*pte)) > > resulting in redundant loads. > > A typical example is pud_free_pmd_page(), where the expansion of > pmd_present() generates: > ... > /* pmd_present() (x20 = pmdp) */ > 1b88: f9400288 ldr x8, [x20] // read pmdp. > 1b8c: f9000fa8 str x8, [x29, #0x18] > 1b90: 3707fec8 tbnz w8, #0x0, 0x1b68 > 1b94: f9400288 ldr x8, [x20] // redundant read of pmdp. > 1b98: 8a170109 and x9, x8, x23 > 1b9c: f9000fa8 str x8, [x29, #0x18] > 1ba0: f120013f cmp x9, #0x800 > 1ba4: 54fffe20 b.eq 0x1b68 > 1ba8: 17fffff4 b 0x1b78 > ... > > To address this in arm64, convert pte_present() macro and its friends > to static inline function. > > This patch is based on mm-unstable. > > Future work > =========== > - print_bad_page_map() and show_pte() still prints dummy values > instead of printing the same content for all generic compile-time > folded page tables. We might want to skip printing dummy values later. > > - We currently catch abuse of dummy values on the stack at compile-time by > relying on constant propagation by the compiler. Usama's work [3] on using > distinct types for sw vs. hw PTEs could help here as well." > > Patch History > ============= > from v2 to v3: > - repasre commit message > - move ptdump_pgtable_first_level() into pgalloc.h > - skip the huge pud operation when CONFIG_X86_DIRECT_GBPAGES is > disabled > - https://lore.kernel.org/all/20260722-dummy_ptxp3-v2-0-d9e4bad31e0a@arm.com/ > > from v1 to v2: > - Restore slient fallback to next pXd in set_pXd() and pXd_pgtable() > and add check whether they're called with dummy entry. > - Add some comment for returning first entry of pgd in arm with > 2 pgtable-level > - https://lore.kernel.org/all/20260713135614.1618183-1-yeoreum.yun@arm.com/ > > To: Russell King > To: Huacai Chen > To: WANG Xuerui > To: Thomas Bogendoerfer > To: Catalin Marinas > To: Will Deacon > To: Arnd Bergmann > To: Andrew Morton > To: Kairui Song > To: Qi Zheng > To: Shakeel Butt > To: Barry Song > To: Axel Rasmussen > To: Yuanchu Xie > To: Wei Xu > To: Johannes Weiner > To: David Hildenbrand > To: Michal Hocko > To: Lorenzo Stoakes > To: Tianrui Zhao > To: Bibo Mao > To: Anup Patel > To: Atish Patra > To: Paul Walmsley > To: Palmer Dabbelt > To: Albert Ou > To: Alexandre Ghiti > To: Dave Hansen > To: Andy Lutomirski > To: Peter Zijlstra > To: Thomas Gleixner > To: Ingo Molnar > To: Borislav Petkov > To: x86@kernel.org > To: H. Peter Anvin > To: Liam R. Howlett > To: Vlastimil Babka > To: Mike Rapoport > To: Suren Baghdasaryan > To: Michal Hocko > To: Jonas Bonn > To: Stefan Kristiansson > To: Stafford Horne > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Cc: loongarch@lists.linux.dev > Cc: linux-mips@vger.kernel.org > Cc: linux-arch@vger.kernel.org > Cc: linux-mm@kvack.org > Cc: kvm@vger.kernel.org > Cc: kvm-riscv@lists.infradead.org > Cc: linux-riscv@lists.infradead.org > Cc: linux-openrisc@vger.kernel.org > Link: [1] https://lore.kernel.org/all/0019d675-ce3d-4a5c-89ed-f126c45145c9@kernel.org/ > Link: [2] https://lore.kernel.org/all/20251113014656.2605447-1-samuel.holland@sifive.com/ > Link: [3] https://lore.kernel.org/r/74182e50-b54f-4d2d-a27f-3a59a538d6bc@arm.com > > --- b4-submit-tracking --- > # This section is used internally by b4 prep for tracking purposes. > { > "series": { > "revision": 3, > "change-id": "20260722-dummy_ptxp3-3741d78cc70f", > "prefixes": [ > "RFC" > ], > "history": { > "v2": [ > "20260722-dummy_ptxp3-v2-0-d9e4bad31e0a@arm.com" > ] > } > } > } > > Signed-off-by: Yeoreum Yun > -- > LEVI:{C3F47F37-75D8-414A-A8BA-3980EC8A46D7} > -- Sincerely, Yeoreum Yun