From: Frank Li <Frank.li@oss.nxp.com>
To: Brian Masney <bmasney@redhat.com>
Cc: "Ludovic Desroches" <ludovic.desroches@microchip.com>,
"Vinod Koul" <vkoul@kernel.org>, "Frank Li" <Frank.Li@kernel.org>,
"Paul Cercueil" <paul@crapouillou.net>,
"Viresh Kumar" <vireshk@kernel.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Andreas Färber" <afaerber@suse.de>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Paul Walmsley" <pjw@kernel.org>,
"Samuel Holland" <samuel.holland@sifive.com>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"Linus Walleij" <linusw@kernel.org>,
"Zhang Wei" <zw@zh-kernel.org>,
linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
imx@lists.linux.dev, linux-actions@lists.infradead.org,
linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 3/3] dmaengine: fsldma: convert to subsys_platform_driver()
Date: Mon, 16 Nov 2026 14:45:25 -0600 [thread overview]
Message-ID: <avtrZb9RoVIPOzbv@SMW015318> (raw)
In-Reply-To: <20261106-dmaengine-subsys-v1-3-780eeddbf3ef@redhat.com>
On Fri, Nov 06, 2026 at 07:06:10PM -0500, Brian Masney wrote:
> Reduce boilerplate code in this driver and convert it over to use
> the macro subsys_platform_driver().
>
> Note that this driver previously displayed a log message during init
> time, and this change drops that message.
>
> Signed-off-by: Brian Masney <bmasney@redhat.com>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> drivers/dma/fsldma.c | 14 +-------------
> 1 file changed, 1 insertion(+), 13 deletions(-)
>
> diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c
> index 99a878ed1444..fd3dca7616a8 100644
> --- a/drivers/dma/fsldma.c
> +++ b/drivers/dma/fsldma.c
> @@ -1431,19 +1431,7 @@ static struct platform_driver fsldma_of_driver = {
> /* Module Init / Exit */
> /*----------------------------------------------------------------------------*/
>
> -static __init int fsldma_init(void)
> -{
> - pr_info("Freescale Elo series DMA driver\n");
> - return platform_driver_register(&fsldma_of_driver);
> -}
> -
> -static void __exit fsldma_exit(void)
> -{
> - platform_driver_unregister(&fsldma_of_driver);
> -}
> -
> -subsys_initcall(fsldma_init);
> -module_exit(fsldma_exit);
> +subsys_platform_driver(fsldma_of_driver);
>
> MODULE_DESCRIPTION("Freescale Elo series DMA driver");
> MODULE_LICENSE("GPL");
>
> --
> 2.56.0
>
prev parent reply other threads:[~2026-11-16 20:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-07 0:06 [PATCH 0/3] dmaengine: convert to subsys_platform_driver() and subsys_platform_driver_probe() Brian Masney
2026-11-07 0:06 ` [PATCH 1/3] dmaengine: convert to subsys_platform_driver() Brian Masney
2026-11-16 20:43 ` Frank Li
2026-11-07 0:06 ` [PATCH 2/3] dmaengine: convert to subsys_platform_driver_probe() Brian Masney
2026-11-09 9:57 ` Linus Walleij
2026-11-16 20:44 ` Frank Li
2026-11-07 0:06 ` [PATCH 3/3] dmaengine: fsldma: convert to subsys_platform_driver() Brian Masney
2026-11-16 20:45 ` Frank Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avtrZb9RoVIPOzbv@SMW015318 \
--to=frank.li@oss.nxp.com \
--cc=Frank.Li@kernel.org \
--cc=afaerber@suse.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bmasney@redhat.com \
--cc=dmaengine@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linusw@kernel.org \
--cc=linux-actions@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=ludovic.desroches@microchip.com \
--cc=mani@kernel.org \
--cc=paul@crapouillou.net \
--cc=pjw@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=samuel.holland@sifive.com \
--cc=vigneshr@ti.com \
--cc=vireshk@kernel.org \
--cc=vkoul@kernel.org \
--cc=zw@zh-kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox