Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Nicolas Schier <nsc@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: Nathan Chancellor <nathan@kernel.org>,
	Sasha Levin <sashal@kernel.org>,
	Harald Freudenberger <freude@linux.ibm.com>,
	Holger Dengler <dengler@linux.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Huacai Chen <chenhuacai@kernel.org>,
	WANG Xuerui <kernel@xen0n.name>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-kbuild@vger.kernel.org, linux-s390@vger.kernel.org,
	loongarch@lists.linux.dev, linux-mips@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"kernelci.org bot" <bot@kernelci.org>
Subject: Re: [PATCH 2/2] devicetable-offsets: Get struct cpu_feature from a device-id header
Date: Fri, 20 Nov 2026 21:21:13 +0100	[thread overview]
Message-ID: <awCruYkI2TkxJfPC@levanger> (raw)
In-Reply-To: <awAtvSIQeLJq2hvF@monoceros>

On Fri, Nov 20, 2026 at 12:25:48PM +0100, Uwe Kleine-König wrote:
> Hello,
> 
> On Thu, Nov 19, 2026 at 12:47:38PM -0700, Nathan Chancellor wrote:
> > On Thu, Nov 19, 2026 at 04:24:47PM +0100, Nicolas Schier wrote:
> > > So my questions:
> > > 
> > >  * Shall we keep it the way it is to keep the original patch order
> > >    (bisect might fail on the two commits before this patch)?
> > > 
> > >  * Or shall the patch be moved before Uwe's (removing the 'Fixes' tag,
> > >    and rewriting the commit msg)?
> > > 
> > > I am in favor of the latter.  Are there any objections?
> > > 
> > > 
> > > [1]: https://git.kernel.org/kbuild/c/f1dc66c38b7eb4b2fb946a2fd6929250ecd2d85a
> > > [2]: https://patch.msgid.link/bc9fbf5784f6788e10c749a05d56c42bdb68f3d9.1792144769.git.u.kleine-koenig@baylibre.com
> > 
> > If history is already being rewritten, I believe it is always good to
> > fix potential bisection issues like this. Rewriting the commit message
> > (and maybe some of the diff?) and placing it in an order such that the
> > build cannot break sounds great to me (but others are free to disagree).
> 
> Full ack. I think the danger to hit that point during bisection is
> small, but I like the 2nd option as this reduces the small chance to 0
> in that case that people yell at me :-)
> 
> So from my side: go!

Thanks!

I'll send a patch that combines both patches in a few minutes.  I plan
to replace

  * Move struct cpu_feature to <linux/cpufeature.h>
    https://patch.msgid.link/bc9fbf5784f6788e10c749a05d56c42bdb68f3d9.1792144769.git.u.kleine-koenig@baylibre.com

and

  * devicetable-offsets: Get struct cpu_feature from a device-id header
    https://patch.msgid.link/f610c07f39df15f3e7ebdc63bfcd759ca7a687a8.1794233316.git.sashal@kernel.org

with it.  Please complain in case of objections or inappropriate tags.

Have a nice weekend!


-- 
Nicolas

  reply	other threads:[~2026-11-20 20:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1792144769.git.u.kleine-koenig@baylibre.com>
     [not found] ` <179416565740.60865.16102443399828949110.b4-review@b4>
2026-11-09 14:14   ` [PATCH 1/2] s390/pkey: Include <linux/device-id/ap.h> for struct ap_device_id Sasha Levin
2026-11-09 14:14     ` [PATCH 2/2] devicetable-offsets: Get struct cpu_feature from a device-id header Sasha Levin
2026-11-09 15:57       ` Uwe Kleine-König
2026-11-09 16:07       ` Nicolas Schier
2026-11-19 15:24         ` Nicolas Schier
2026-11-19 19:47           ` Nathan Chancellor
2026-11-20 11:25             ` Uwe Kleine-König
2026-11-20 20:21               ` Nicolas Schier [this message]
2026-11-20 20:27                 ` [PATCH] Move struct cpu_feature to a <linux/device-id/cpu_feature.h> Nicolas Schier
2026-11-09 15:48     ` [PATCH 1/2] s390/pkey: Include <linux/device-id/ap.h> for struct ap_device_id Uwe Kleine-König
2026-11-13 13:38       ` Harald Freudenberger
2026-11-09 16:07     ` Nicolas Schier
2026-11-13 13:30     ` Harald Freudenberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=awCruYkI2TkxJfPC@levanger \
    --to=nsc@kernel.org \
    --cc=agordeev@linux.ibm.com \
    --cc=bot@kernelci.org \
    --cc=chenhuacai@kernel.org \
    --cc=dengler@linux.ibm.com \
    --cc=freude@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=kernel@xen0n.name \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=loongarch@lists.linux.dev \
    --cc=nathan@kernel.org \
    --cc=sashal@kernel.org \
    --cc=tsbogend@alpha.franken.de \
    --cc=u.kleine-koenig@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox