From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Fri, 18 Aug 2017 19:28:20 +0200 (CEST) Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:42792 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23994932AbdHRR2KOnyBh (ORCPT ); Fri, 18 Aug 2017 19:28:10 +0200 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 345B42B; Fri, 18 Aug 2017 10:28:04 -0700 (PDT) Received: from [10.1.207.16] (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 326413F483; Fri, 18 Aug 2017 10:28:03 -0700 (PDT) Subject: Re: [PATCH 00/38] irqchip: mips-gic: Cleanup & optimisation To: Paul Burton , linux-mips@linux-mips.org, Jason Cooper , Thomas Gleixner Cc: Ralf Baechle References: <20170813043646.25821-1-paul.burton@imgtec.com> From: Marc Zyngier Organization: ARM Ltd Message-ID: Date: Fri, 18 Aug 2017 18:28:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170813043646.25821-1-paul.burton@imgtec.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 59685 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: marc.zyngier@arm.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips Hi Paul, On 13/08/17 05:36, Paul Burton wrote: > This series cleans up the MIPS Global Interrupt Controller (GIC) driver > somewhat. It moves us towards using a header in a similar vein to the > ones we have for the MIPS Coherence Manager (CM) & Cluster Power > Controller (CPC) which allows us to access the GIC outside of the > irqchip driver - something beneficial already for the clocksource & > clock event driver, and which will be beneficial for further drivers > (eg. one for the GIC watchdog timer) and for multi-cluster work. Using > this header is also beneficial for consistency & code-sharing. > > In addition to cleanups the series also optimises the driver in various > ways, including by using a per-CPU variable for pcpu_masks & removing > the need to read the GIC_SH_MASK_* registers when decoding interrupts in > gic_handle_shared_int(). > > This series requires my "[PATCH 00/19] MIPS: Initial multi-cluster > support" series to be applied first. I went through the whole series, and didn't spot anything bad (the couple of nits I raised can either be fixed at a later time or as a fixup on top of what you have). Given that this has a number of dependencies (your multicluster series), how do you want to get this merged? Thanks, M. -- Jazz is not dead. It just smells funny...