Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: lee@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	tsbogend@alpha.franken.de, hkallweit1@gmail.com,
	linux@armlinux.org.uk, markus.stockhausen@gmx.de,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, linux-mips@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: net: Add Realtek MDIO controller
Date: Fri, 13 Dec 2024 12:58:25 +0100	[thread overview]
Message-ID: <b1117d56-87d9-46b2-b6aa-e6ca20bac322@lunn.ch> (raw)
In-Reply-To: <4e59d81c-4af1-407b-a9c5-4b36eee35f96@alliedtelesis.co.nz>

On Fri, Dec 13, 2024 at 01:56:52PM +1300, Chris Packham wrote:
> Hi Andrew,
> 
> On 13/12/2024 06:13, Andrew Lunn wrote:
> > > +      realtek,smi-address:
> > > +        $ref: /schemas/types.yaml#/definitions/uint32-array
> > > +        description: SMI interface and address for the connected PHY
> > > +        items:
> > > +          - description: SMI interface number associated with the port.
> > > +          - description: SMI address of the PHY for the port.
> > Is the hardware really random here with its mapping of PHYs?
> > Generally, hardware is pretty predictable, logical. I'm just wondering
> > if this property is really required, or if it can be replaced with
> > some logic, avoiding typ0s.
> 
> The hardware is pretty flexible in this respect. You can pretty arbitrarily
> arrange your PHYs. Not all ports support the same kind of SERDES interface
> but as far as the MDIO interface goes you can arrange things however you
> like.

Is there a reason to not just statically define it, maybe with a table
in the driver? Does a DT developer actually need this flexibility?

	Andrew

  reply	other threads:[~2024-12-13 11:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-11 23:53 [PATCH 0/4] RTL9300 MDIO driver Chris Packham
2024-12-11 23:53 ` [PATCH 1/4] dt-bindings: net: Add Realtek MDIO controller Chris Packham
2024-12-12 17:13   ` Andrew Lunn
2024-12-13  0:56     ` Chris Packham
2024-12-13 11:58       ` Andrew Lunn [this message]
2024-12-15 19:52         ` Chris Packham
2024-12-15 21:38           ` Andrew Lunn
2024-12-11 23:53 ` [PATCH 2/4] dt-bindings: mfd: Add MDIO interface to rtl9301-switch Chris Packham
2024-12-11 23:53 ` [PATCH 3/4] mips: dts: realtek: Add MDIO controller Chris Packham
2024-12-11 23:53 ` [PATCH 4/4] net: mdio: Add RTL9300 MDIO driver Chris Packham
2024-12-12  7:41   ` Andrew Lunn
2024-12-12  8:18   ` Christophe JAILLET
2024-12-12  9:59   ` Russell King (Oracle)
2024-12-13  0:51     ` Chris Packham
2024-12-13 19:59   ` Simon Horman
2024-12-15 20:27     ` Chris Packham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b1117d56-87d9-46b2-b6aa-e6ca20bac322@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=andrew+netdev@lunn.ch \
    --cc=chris.packham@alliedtelesis.co.nz \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=markus.stockhausen@gmx.de \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox