From: Vincenzo Frascino <vincenzo.frascino@arm.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
clang-built-linux@googlegroups.com, x86@kernel.org,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>, Arnd Bergmann <arnd@arndb.de>,
Russell King <linux@armlinux.org.uk>,
Paul Burton <paul.burton@mips.com>,
Thomas Gleixner <tglx@linutronix.de>,
Andy Lutomirski <luto@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>, Stephen Boyd <sboyd@kernel.org>,
Mark Salyzyn <salyzyn@android.com>,
Kees Cook <keescook@chromium.org>,
Peter Collingbourne <pcc@google.com>,
Dmitry Safonov <0x7f454c46@gmail.com>,
Andrei Vagin <avagin@openvz.org>,
Nick Desaulniers <ndesaulniers@google.com>
Subject: Re: [PATCH v2 00/20] Introduce common headers
Date: Mon, 9 Mar 2020 11:07:08 +0000 [thread overview]
Message-ID: <b18c7ce1-0948-a9e2-2d7e-d019669a71e1@arm.com> (raw)
In-Reply-To: <3278D604-28F1-47A1-BAB8-D8EB439995E8@amacapital.net>
Hi Andy,
On 3/6/20 4:04 PM, Andy Lutomirski wrote:
[...]
>>
>> To solve the problem, I decided to use the approach below:
>> * Extract from include/linux/ the vDSO required kernel interface
>> and place it in include/common/
>
> I really like the approach, but I’m wondering if “common” is the right name. This directory is headers that aren’t stable ABI like uapi but are shared between the kernel and the vDSO. Regular user code should *not* include these, right?
>
> Would “vdso” or perhaps “private-abi” be clearer?
>
Thanks! These headers are definitely not "uapi" like and they are meant to
evolve in future like any other kernel header. We have just to make sure that
the evolution does not break what we are trying to achieve with this series.
I have to admit that I spent quite some time in choosing the name and I am not
completely satisfied with "common" either. The reason why I ended up with this
is that the headers are common in between the kernel and the vdso (userspace)
but I agree that it does not make completely self explanatory.
Using "vdso" would mean according to me that those are vdso only headers,
probably "private-abi" is the best choice here. If there is enough consensus, I
am happy to rework my patches accordingly. What do you think?
>> * Make sure that where meaningful the kernel includes "common"
>> * Limit the vDSO library to include headers coming only from UAPI
>> and "common" (with 2 exceptions compiler.h for barriers and
>> param.h for HZ).
>> * Adapt all the architectures that support the unified vDSO library
>> to use "common" headers.
>
[...]
--
Regards,
Vincenzo
next prev parent reply other threads:[~2020-03-09 11:06 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 13:32 [PATCH v2 00/20] Introduce common headers Vincenzo Frascino
2020-03-06 13:32 ` [PATCH v2 01/20] linux/const.h: Extract common header for vDSO Vincenzo Frascino
2020-03-06 13:32 ` [PATCH v2 02/20] linux/bits.h: " Vincenzo Frascino
2020-03-06 13:32 ` [PATCH v2 03/20] linux/limits.h: " Vincenzo Frascino
2020-03-06 13:32 ` [PATCH v2 04/20] linux/math64.h: " Vincenzo Frascino
2020-03-06 13:32 ` [PATCH v2 05/20] linux/time.h: " Vincenzo Frascino
2020-03-06 13:32 ` [PATCH v2 06/20] linux/time32.h: " Vincenzo Frascino
2020-03-06 13:32 ` [PATCH v2 07/20] linux/time64.h: " Vincenzo Frascino
2020-03-06 13:32 ` [PATCH v2 08/20] linux/jiffies.h: " Vincenzo Frascino
2020-03-06 13:32 ` [PATCH v2 09/20] linux/ktime.h: " Vincenzo Frascino
2020-03-06 13:32 ` [PATCH v2 10/20] common: Introduce processor.h Vincenzo Frascino
2020-03-06 13:32 ` [PATCH v2 11/20] linux/elfnote.h: Replace elf.h with UAPI equivalent Vincenzo Frascino
2020-03-07 1:21 ` kbuild test robot
2020-03-06 13:32 ` [PATCH v2 12/20] arm64: Introduce asm/common/processor.h Vincenzo Frascino
2020-03-06 13:32 ` [PATCH v2 13/20] arm64: vdso: Include common headers in the vdso library Vincenzo Frascino
2020-03-06 13:32 ` [PATCH v2 14/20] arm64: vdso32: " Vincenzo Frascino
2020-03-06 13:32 ` [PATCH v2 15/20] arm64: Introduce asm/common/arch_timer.h Vincenzo Frascino
2020-03-06 13:32 ` [PATCH v2 16/20] mips: vdso: Enable mips to use common headers Vincenzo Frascino
2020-03-06 13:32 ` [PATCH v2 17/20] x86: vdso: Enable x86 " Vincenzo Frascino
2020-03-06 13:32 ` [PATCH v2 18/20] arm: vdso: Enable arm " Vincenzo Frascino
2020-03-06 13:32 ` [PATCH v2 19/20] lib: vdso: Enable " Vincenzo Frascino
2020-03-06 13:32 ` [PATCH v2 20/20] arm64: vdso32: Enable Clang Compilation Vincenzo Frascino
2020-03-10 1:40 ` Nathan Chancellor
2020-03-13 12:01 ` Vincenzo Frascino
2020-03-06 16:04 ` [PATCH v2 00/20] Introduce common headers Andy Lutomirski
2020-03-09 11:07 ` Vincenzo Frascino [this message]
2020-03-09 12:24 ` Mark Rutland
2020-03-09 19:23 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b18c7ce1-0948-a9e2-2d7e-d019669a71e1@arm.com \
--to=vincenzo.frascino@arm.com \
--cc=0x7f454c46@gmail.com \
--cc=arnd@arndb.de \
--cc=avagin@openvz.org \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=clang-built-linux@googlegroups.com \
--cc=keescook@chromium.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=ndesaulniers@google.com \
--cc=paul.burton@mips.com \
--cc=pcc@google.com \
--cc=salyzyn@android.com \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).