From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACDC7C2BA19 for ; Wed, 15 Apr 2020 12:12:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 88315206F9 for ; Wed, 15 Apr 2020 12:12:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RGQ9ReOx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S368589AbgDOMMi (ORCPT ); Wed, 15 Apr 2020 08:12:38 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:40681 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S368583AbgDOMLs (ORCPT ); Wed, 15 Apr 2020 08:11:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586952701; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3g8pOUWTOZg7Xu60Mt7A1x/Ov3i7r+YKQXs6UW5HczM=; b=RGQ9ReOxUD6zJxpTpcJyovIWYbtUkeED3xFLICuYpGDlGl/rd+rqnNoCERJwPU+rJtxclB kzwoRxnLECElXSIlg1wGMaDqEmFbNwD+NqUGlqpurC/cuS6hFxs7UIIZr1SOGDyLOJPkzc fwwsB7SR1oicULgzTA8mT74GS8uEOPk= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-163-seMxaawgOLaTsfXY1uOHoQ-1; Wed, 15 Apr 2020 08:11:39 -0400 X-MC-Unique: seMxaawgOLaTsfXY1uOHoQ-1 Received: by mail-wr1-f69.google.com with SMTP id o10so10409695wrj.7 for ; Wed, 15 Apr 2020 05:11:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3g8pOUWTOZg7Xu60Mt7A1x/Ov3i7r+YKQXs6UW5HczM=; b=NrEWX7EcVpwHFPnbC2syOhr94TRmGP3Y+ITxkqGvEFDGINLHRZCrkkzCuBcwtyfhOV CVKHNMWv/jF5+seNVrpOXqIR2/O27kt2rVc4eNTzz7M+nFt+lK4p4lylDjDhUlLmKK/w 6A6hMz4MOPRw098pHSPzvYbzg/QSOhAuw8XO0cUfccdA5ckq5Fw9cE5/Vo/Xk4a9MQbi i4OJ1o006wIc8c4oIymngrWJejPZsrZLL7cz17wTaKa3vYdA+nwxcTApWrj13x5Kndi0 IdMqyQ5LygUYHaryqqidPPnZXBti7wWGVI0qNGO9x6Vgha59HaqadeIruaz+QerUKX2/ Y/dQ== X-Gm-Message-State: AGi0PuZOkTLY66Z5ZV7uMZarhpFJW+WJaOXcIFSAQeM786ANNDgljNnj BvBk6+ugqabijzLOarKjN+WZ3EsW4tdLLamuqILTAfjscyvZDV16n8gnxO+CiipGLsW/NJDmW4u tz4orptsXFI9YAIKiRosJeQ== X-Received: by 2002:a5d:688f:: with SMTP id h15mr29234453wru.352.1586952698402; Wed, 15 Apr 2020 05:11:38 -0700 (PDT) X-Google-Smtp-Source: APiQypKdWpo7ENEPbDqHP93vSXvdpZwuSMQZ1BbP1xfwyNZcod/63Icpez1n6CuR5oR+nIQbYmcMPw== X-Received: by 2002:a5d:688f:: with SMTP id h15mr29234435wru.352.1586952698180; Wed, 15 Apr 2020 05:11:38 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:9066:4f2:9fbd:f90e? ([2001:b07:6468:f312:9066:4f2:9fbd:f90e]) by smtp.gmail.com with ESMTPSA id q8sm22064722wmg.22.2020.04.15.05.11.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Apr 2020 05:11:37 -0700 (PDT) Subject: Re: [PATCH 3/4] kvm: Replace vcpu->swait with rcuwait To: Davidlohr Bueso Cc: tglx@linutronix.de, bigeasy@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, torvalds@linux-foundation.org, will@kernel.org, joel@joelfernandes.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Paul Mackerras , kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, Davidlohr Bueso References: <20200324044453.15733-1-dave@stgolabs.net> <20200324044453.15733-4-dave@stgolabs.net> <20200414211243.7vehybdrvbzmbduu@linux-p48b> From: Paolo Bonzini Message-ID: Date: Wed, 15 Apr 2020 14:11:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200414211243.7vehybdrvbzmbduu@linux-p48b> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On 14/04/20 23:12, Davidlohr Bueso wrote: > On Wed, 25 Mar 2020, Paolo Bonzini wrote: > >> On 24/03/20 05:44, Davidlohr Bueso wrote: >>> diff --git a/arch/mips/kvm/mips.c b/arch/mips/kvm/mips.c >>> index 71244bf87c3a..e049fcb3dffb 100644 >>> --- a/arch/mips/kvm/mips.c >>> +++ b/arch/mips/kvm/mips.c >>> @@ -290,8 +290,7 @@ static enum hrtimer_restart >>> kvm_mips_comparecount_wakeup(struct hrtimer *timer) >>>     kvm_mips_callbacks->queue_timer_int(vcpu); >>> >>>     vcpu->arch.wait = 0; >>> -    if (swq_has_sleeper(&vcpu->wq)) >>> -        swake_up_one(&vcpu->wq); >>> +    rcuwait_wake_up(&vcpu->wait) >> >> This is missing a semicolon.  (KVM MIPS is known not to compile and will >> be changed to "depends on BROKEN" in 5.7). > > Do you want me to send another version with this fix or do you prefer > fixing it when/if picked up? It's up to the TIP tree people, but sending a fixed version is probably the best way to get their attention. :) I can also queue it myself (for 5.7 even) if I get an Acked-by from Peter though. Paolo