From: Florian Fainelli <f.fainelli@gmail.com>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Paul Cercueil <paul@crapouillou.net>,
Nathan Chancellor <nathan@kernel.org>,
Tiezhu Yang <yangtiezhu@loongson.cn>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: Rewrite `csum_tcpudp_nofold' in plain C
Date: Tue, 24 May 2022 11:30:54 -0700 [thread overview]
Message-ID: <b567d6bd-b563-f696-60f2-0fc36261d094@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2205241811180.52080@angie.orcam.me.uk>
On 5/24/22 10:18, Maciej W. Rozycki wrote:
> On Tue, 24 May 2022, Florian Fainelli wrote:
>
>>> I have visually inspected code produced and verified this change to boot
>>> with TCP networking performing just fine, both with a 32-bit and a 64-bit
>>> configuration. Sadly with the little endianness only, because in the
>>> course of this verification I have discovered the core card of my Malta
>>> board bit the dust a few days ago, apparently in a permanent manner, and I
>>> have no other big-endian MIPS system available here to try.
>>
>> How about QEMU is not that a viable option for testing big/little endian
>> configurations?
>
> Yeah, for this particular change, sure. I don't have QEMU set up however
> at the moment and would have to take some time to sort it, and it won't do
> for peripherals it doesn't implement. The failure is a fresh problem and
> I yet need to figure out what to do about it. A bad coincidence I guess
> as I have MIPS hardware 10 years older that still goes strong.
If that makes it any easier, OpenWrt has 4 configurations of Malta for
QEMU which allows you to have at least networking (relevant here) for
32/64 and le/be:
https://git.openwrt.org/?p=openwrt/openwrt.git;a=tree;f=target/linux/malta;h=90b2913dec291a1926eefc332b90b5842746c6e6;hb=HEAD
Along with a readme file on how to start those platforms:
https://git.openwrt.org/?p=openwrt/openwrt.git;a=blob;f=target/linux/malta/README;h=bbe806de3d6671d69ecc3db0fcfccf9f9176de13;hb=HEAD
It's really easy.
--
Florian
next prev parent reply other threads:[~2022-05-24 18:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-22 20:48 [PATCH] MIPS: Rewrite `csum_tcpudp_nofold' in plain C Maciej W. Rozycki
2022-05-23 9:40 ` Thomas Bogendoerfer
2022-05-24 16:38 ` Florian Fainelli
2022-05-24 17:18 ` Maciej W. Rozycki
2022-05-24 18:30 ` Florian Fainelli [this message]
2022-05-25 15:01 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b567d6bd-b563-f696-60f2-0fc36261d094@gmail.com \
--to=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=nathan@kernel.org \
--cc=paul@crapouillou.net \
--cc=tsbogend@alpha.franken.de \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox