From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: Haoran Jiang <jianghaoran@kylinos.cn>, chenhuacai@kernel.org
Cc: jiaxun.yang@flygoat.com, tglx@linutronix.de, maz@kernel.org,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] irqchip/loongson-liointc: 4 cores correspond to different interrupt status registers
Date: Tue, 10 May 2022 11:08:57 +0300 [thread overview]
Message-ID: <b6a10a52-6d0e-5351-cdb5-373286cf7d3f@gmail.com> (raw)
In-Reply-To: <20220510055303.1907165-1-jianghaoran@kylinos.cn>
Hello!
On 5/10/22 8:53 AM, Haoran Jiang wrote:
> According to the loongson cpu manual,different cpu cores
Please add space after comma.
> correspond to different interrupt status registers
>
> Signed-off-by: Haoran Jiang <jianghaoran@kylinos.cn>
> ---
> drivers/irqchip/irq-loongson-liointc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-loongson-liointc.c b/drivers/irqchip/irq-loongson-liointc.c
> index 649c58391618..f4e015b50af0 100644
> --- a/drivers/irqchip/irq-loongson-liointc.c
> +++ b/drivers/irqchip/irq-loongson-liointc.c
> @@ -195,7 +195,7 @@ static int __init liointc_of_init(struct device_node *node,
> }
>
> for (i = 0; i < LIOINTC_NUM_CORES; i++)
> - priv->core_isr[i] = base + LIOINTC_REG_INTC_STATUS;
> + priv->core_isr[i] = base + LIOINTC_REG_INTC_STATUS + i*8;
Please add spaces around *.
[...]
MBR, Sergey
next prev parent reply other threads:[~2022-05-10 8:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 5:53 [PATCH] irqchip/loongson-liointc: 4 cores correspond to different interrupt status registers Haoran Jiang
2022-05-10 7:45 ` Marc Zyngier
2022-05-10 8:08 ` Sergei Shtylyov [this message]
2022-05-10 12:15 ` Jiaxun Yang
2022-05-11 5:33 ` jianghaoran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6a10a52-6d0e-5351-cdb5-373286cf7d3f@gmail.com \
--to=sergei.shtylyov@gmail.com \
--cc=chenhuacai@kernel.org \
--cc=jianghaoran@kylinos.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox