* [PATCH v2] dt-bindings: dma: img-mdc-dma: convert to DT schema
[not found] <20250821150255.236884-1-ninozhang001@gmail.com>
@ 2025-08-24 3:45 ` Nino Zhang
2025-08-24 11:24 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Nino Zhang @ 2025-08-24 3:45 UTC (permalink / raw)
To: devicetree
Cc: robh, krzk+dt, conor+dt, vkoul, rahulbedarkar89, linux-mips,
dmaengine, linux-kernel, Nino Zhang
Convert the img-mdc-dma binding from txt to YAML schema.
No functional changes except dropping the consumer node
(spi@18100f00) from the example, which belongs to the
consumer binding instead.
Signed-off-by: Nino Zhang <ninozhang001@gmail.com>
---
Changes since v1:
- All review comments addressed.
Open:
- Maintainers: set to Rahul Bedarkar + linux-mips per MAINTAINERS entry
for Pistachio/CI40 device tree. This seems the closest match to the
hardware. Happy to adjust if platform maintainers suggest otherwise.
- img,max-burst-multiplier: defined as uint32. A minimum of 1 is used to
exclude the invalid case of 0, but the actual supported range has not
been confirmed in available documentation. Example uses 16. A maximum
will be added once confirmed by platform maintainers or hardware docs.
.../bindings/dma/img,pistachio-mdc-dma.yaml | 90 +++++++++++++++++++
.../devicetree/bindings/dma/img-mdc-dma.txt | 57 ------------
2 files changed, 90 insertions(+), 57 deletions(-)
create mode 100644 Documentation/devicetree/bindings/dma/img,pistachio-mdc-dma.yaml
delete mode 100644 Documentation/devicetree/bindings/dma/img-mdc-dma.txt
diff --git a/Documentation/devicetree/bindings/dma/img,pistachio-mdc-dma.yaml b/Documentation/devicetree/bindings/dma/img,pistachio-mdc-dma.yaml
new file mode 100644
index 000000000000..4dde54a17f52
--- /dev/null
+++ b/Documentation/devicetree/bindings/dma/img,pistachio-mdc-dma.yaml
@@ -0,0 +1,90 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/dma/img,pistachio-mdc-dma.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: IMG Multi-threaded DMA Controller (MDC)
+
+maintainers:
+ - Rahul Bedarkar <rahulbedarkar89@gmail.com>
+ - linux-mips@vger.kernel.org
+
+allOf:
+ - $ref: /schemas/dma/dma-controller.yaml#
+
+properties:
+ compatible:
+ const: img,pistachio-mdc-dma
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ minItems: 1
+ maxItems: 32
+
+ clocks:
+ maxItems: 1
+
+ clock-names:
+ items:
+ - const: sys
+
+ img,cr-periph:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description: >
+ Phandle to peripheral control syscon node with DMA request to channel
+ mapping registers.
+
+ img,max-burst-multiplier:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ minimum: 1
+ description: >
+ Maximum supported burst size multiplier. The maximum burst size is this
+ value multiplied by the hardware-reported bus width.
+
+ "#dma-cells":
+ const: 3
+ description: |
+ DMA specifier cells:
+ 1: peripheral's DMA request line
+ 2: channel bitmap: bit N set indicates channel N is usable
+ 3: thread ID to be used by the channel
+
+ dma-channels:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ minimum: 1
+ maximum: 32
+ description: Number of supported DMA channels (defaults to HW-reported value)
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - clocks
+ - clock-names
+ - img,cr-periph
+ - img,max-burst-multiplier
+ - "#dma-cells"
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/mips-gic.h>
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ dma-controller@18143000 {
+ compatible = "img,pistachio-mdc-dma";
+ reg = <0x18143000 0x1000>;
+ interrupts = <GIC_SHARED 27 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SHARED 28 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&system_clk>;
+ clock-names = "sys";
+
+ img,max-burst-multiplier = <16>;
+ img,cr-periph = <&cr_periph>;
+
+ #dma-cells = <3>;
+ };
diff --git a/Documentation/devicetree/bindings/dma/img-mdc-dma.txt b/Documentation/devicetree/bindings/dma/img-mdc-dma.txt
deleted file mode 100644
index 28c1341db346..000000000000
--- a/Documentation/devicetree/bindings/dma/img-mdc-dma.txt
+++ /dev/null
@@ -1,57 +0,0 @@
-* IMG Multi-threaded DMA Controller (MDC)
-
-Required properties:
-- compatible: Must be "img,pistachio-mdc-dma".
-- reg: Must contain the base address and length of the MDC registers.
-- interrupts: Must contain all the per-channel DMA interrupts.
-- clocks: Must contain an entry for each entry in clock-names.
- See ../clock/clock-bindings.txt for details.
-- clock-names: Must include the following entries:
- - sys: MDC system interface clock.
-- img,cr-periph: Must contain a phandle to the peripheral control syscon
- node which contains the DMA request to channel mapping registers.
-- img,max-burst-multiplier: Must be the maximum supported burst size multiplier.
- The maximum burst size is this value multiplied by the hardware-reported bus
- width.
-- #dma-cells: Must be 3:
- - The first cell is the peripheral's DMA request line.
- - The second cell is a bitmap specifying to which channels the DMA request
- line may be mapped (i.e. bit N set indicates channel N is usable).
- - The third cell is the thread ID to be used by the channel.
-
-Optional properties:
-- dma-channels: Number of supported DMA channels, up to 32. If not specified
- the number reported by the hardware is used.
-
-Example:
-
-mdc: dma-controller@18143000 {
- compatible = "img,pistachio-mdc-dma";
- reg = <0x18143000 0x1000>;
- interrupts = <GIC_SHARED 27 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SHARED 28 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SHARED 29 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SHARED 30 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SHARED 31 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SHARED 32 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SHARED 33 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SHARED 34 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SHARED 35 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SHARED 36 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SHARED 37 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SHARED 38 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&system_clk>;
- clock-names = "sys";
-
- img,max-burst-multiplier = <16>;
- img,cr-periph = <&cr_periph>;
-
- #dma-cells = <3>;
-};
-
-spi@18100f00 {
- ...
- dmas = <&mdc 9 0xffffffff 0>, <&mdc 10 0xffffffff 0>;
- dma-names = "tx", "rx";
- ...
-};
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread