From: Zhou Yanjie <zhouyanjie@wanyeetech.com>
To: Wolfram Sang <wsa@kernel.org>
Cc: paul@crapouillou.net, stable@vger.kernel.org,
linux-mips@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, dongsheng.qiu@ingenic.com,
aric.pzqi@ingenic.com, sernia.zhou@foxmail.com
Subject: Re: [PATCH] I2C: JZ4780: Fix bug for Ingenic X1000.
Date: Fri, 2 Apr 2021 23:30:32 +0800 [thread overview]
Message-ID: <b93bf84f-73fd-f0f9-c25b-d7063be76987@wanyeetech.com> (raw)
In-Reply-To: <20210331071835.GB1025@ninjato>
Hi Wolfram,
On 2021/3/31 下午3:18, Wolfram Sang wrote:
> Hi,
>
>>> Any write operation? I wonder then why nobody noticed before?
>>
>> The standard I2C communication should look like this:
>>
>> Read:
>>
>> device_addr + w, reg_addr, device_addr + r, data;
>>
>> Write:
>>
>> device_addr + w, reg_addr, data;
>>
>>
>> But without this patch, it looks like this:
>>
>> Read:
>>
>> device_addr + w, reg_addr, device_addr + r, data;
>>
>> Write:
>>
>> device_addr + w, reg_addr, device_addr + w, data;
>>
>> This is clearly not correct.
> Thanks for the additional information! I understand now. I added a bit
> of this to the commit message of v2 to explain the situation.
>
Thanks!
Best regards!
prev parent reply other threads:[~2021-04-02 15:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 16:25 Fix bug for Ingenic X1000 周琰杰 (Zhou Yanjie)
2021-03-18 16:25 ` [PATCH] I2C: JZ4780: " 周琰杰 (Zhou Yanjie)
2021-03-18 17:01 ` Greg KH
2021-03-18 17:06 ` Wolfram Sang
2021-03-19 6:58 ` Zhou Yanjie
2021-03-31 7:18 ` Wolfram Sang
2021-04-02 15:30 ` Zhou Yanjie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b93bf84f-73fd-f0f9-c25b-d7063be76987@wanyeetech.com \
--to=zhouyanjie@wanyeetech.com \
--cc=aric.pzqi@ingenic.com \
--cc=dongsheng.qiu@ingenic.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=sernia.zhou@foxmail.com \
--cc=stable@vger.kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).