From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 640F7392C2E for ; Mon, 6 Jul 2026 08:28:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783326510; cv=none; b=RIfl2oFlLRwo0g7OYFAGROHXDnwVEQS45nCmkYutiWtHleoTs2IIICRWUAEMxfRJ4nIJfXd83r8QChAuNnn5D7jc6FQSp/g6EXVJqTo9O9499oswfK73atRvttpCb7VEBuT8i0/+q4dmSIh71ljOeqMEXd5pzzLG7rs29sTLmCE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783326510; c=relaxed/simple; bh=JJvjvXzlCcli26w+i5Hirhm7MyXZ6wjDQGioyQ2O3Fo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rVGRdY8VM0WV/F4z6e3Wz0XfDN7G3Vq04BveKWWtQHVxpghfvtadWlxwGE/Y4/nY4C2buaBuVC68RlCXcs7NsJrlSKkStkrhx/ubXoBCFzDOQDfxm8eYkI4LoyHPeOiyvPdN7vKyUkuriAGgWOcRQ20YndlNVHlNRP4XtPXgnC8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jm0Kg9lS; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DYOWYZZs; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jm0Kg9lS"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DYOWYZZs" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66678OOE3977007 for ; Mon, 6 Jul 2026 08:28:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= XAhBIVcIgoBMwzdmQI01e6U2QYtMrrtbbOHKP8KiZ8E=; b=jm0Kg9lSibJvV8Yi 8hdJzAn4zgpP2byZ5O4vxPHA667bXVLXHofUt568kB49iHxnfwvFhctaInLtCjCZ sjNHRodxgeyEI+K4Sh5SeEFuH+eYubHtMfiWH/bAUEFyu7LxqpBoChobn1qyHVpZ 1rLLI4FJJqj/Yk953HEONXVBT+N6ylBmW+SjTQeQEVhfTmxCK8O9BG8vaRt3Exir JXmS8JQhSMmJuTk8SMinF8d+mY+jVTVBRkY8NqkZa2/Ot0bSxasJBedLFZ9P4/jy oIqrv4PZJHfl9zhVgr7IHFht7qp40w3MPq61gyA4heu2IH0hVtB6bY7pBm7HdH1D jKj/ig== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f87q7g9ym-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 08:28:22 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92da6f3cc81so339736285a.2 for ; Mon, 06 Jul 2026 01:28:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783326502; x=1783931302; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=XAhBIVcIgoBMwzdmQI01e6U2QYtMrrtbbOHKP8KiZ8E=; b=DYOWYZZs63ViB45kaHAd7lZtDSS7GT6CnXI61C+yO6RoMpqdqy5CzBF9NgBk9y8SyS +C3Q6NlxiyMd56YUFEro6OpxRQXHGxmjeZiVGw4XctB8EwDRBSy9NW075BZ+B3XTCjKs +rK5n92TcpwKW5WagrK++8ddGw+eFPs/uS+TOKdE3MRfmzoyekqN2ZkMkg1IWMYiLiTV IZnX9vkWCPfQz/vfNLifUpdngzrSv2eJwDl4yEG4mn72JdkRoY5BRAc7n2vUt72r4Ii4 9oScewXkufMMurxbAzkuFTERvVykOA+/m2ALfQvATy1UnSqegfMZ97mG7/G3VppCyWVS yvuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783326502; x=1783931302; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XAhBIVcIgoBMwzdmQI01e6U2QYtMrrtbbOHKP8KiZ8E=; b=hCSBZS/BScgGpxk0RYS8j7e25yQ6Kuuni3OSmG1uPfL8p53uYOAXVjVAnmZg1lo39q om6wlsM7BjC5Y464s80qbVtAuAs6oAe9g1IE0+sWsGumrBCaeQwqbk7XPlSTQeN/5NAF wGrh5SkGgH+avv+Z4zLzPn8jJsnY8LceSqN4Jt1C4ftfS/ON61FMeEBWQ7pSKQvrhs4q VMgVk/hvTTPY2vOYzihVKqMdYN8xKQDCo3oyMlk59HXajosojmCO+QEq/o/lpFj0nsKZ awDfb6JyL5dnS+uJKMQfeZkr9wKqbz6wma2SxhVucKC4UQmz9wDDQpKfudUb4iBp6tlN kJpw== X-Forwarded-Encrypted: i=1; AHgh+RrcSnfWvEd1YN7gVrfjAgnjm/tRuNFho68nWWhOOrinE5bT+IhEu+2QubMNsqBfGet3Jtx/ryZ+gbKl@vger.kernel.org X-Gm-Message-State: AOJu0YyD2otrPhzolbDnvcoBNNVUP4LUYe4WLuw7nSOTt7XLp/fpbwhO 8gihFUNIEcv/t7S5UlYnd+NrVUFG9GZG2OGc/n9tFW4FS7jL5DMDset0WfhrkMbVFOht04Sr34j 4KhF0Mv0I/sqYSjp3CZ6rOmmrHtU91WYszHP/4kJWYTJ7Vw3IUwD+W0M6IjtrwEFQ X-Gm-Gg: AfdE7cnkd4WXiZ3J/17SMAH8SKQ1JmHsBwmgZOhJcBrzlsK7PIxo9a7yv9504GPCLT7 +z71djXyevX5RV2vdJCBFZtSxL9zhWOh+PjUhBU8u7sylQ4DtVSsiJsdwg21ukM78SttJCLMPnF KGIAshUneI+SktGaWNTmKNoMPoDqLe8FZPA54GpJLtkF+EkwcaiQJUU70l2OsUq0/wVlNzNNFi3 jeMxm1Ma5QQ7SHMLhoJBFiHF2StEOMerSl3yUsdLq6DwVT8LjDQvxzffrrrs2SMaAaepfoMaoFh lXGRJ09ZAEMUcVDqNoeAgdUFKzOR7bz38F01Invsi4rKRv44U1aMGuTJhBpeL4dVTFjausDfc1v jkXtATzmrVUKy/4nrgPzODJFNdOJFUogaM8djFRja4puwnuhhvsCwdhc+Yig1Dw== X-Received: by 2002:a05:620a:2b84:b0:92e:47d4:b485 with SMTP id af79cd13be357-92e9a4ed0e1mr1294193385a.62.1783326501623; Mon, 06 Jul 2026 01:28:21 -0700 (PDT) X-Received: by 2002:a05:620a:2b84:b0:92e:47d4:b485 with SMTP id af79cd13be357-92e9a4ed0e1mr1294189385a.62.1783326501174; Mon, 06 Jul 2026 01:28:21 -0700 (PDT) Received: from [192.168.69.219] (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c12b62907absm677939066b.33.2026.07.06.01.28.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jul 2026 01:28:20 -0700 (PDT) Message-ID: Date: Mon, 6 Jul 2026 10:28:16 +0200 Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 4/5] pwm: Unify coding style of of_device_id arrays Content-Language: en-US To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= , Chen Wang Cc: linux-pwm@vger.kernel.org, Sven Peter , Janne Grunau , Neal Gompa , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Ray Jui , Scott Branden , Broadcom internal kernel review list , Florian Fainelli , Benson Leung , Guenter Roeck , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Paul Cercueil , Vladimir Zapolskiy , Piotr Wojtaszczyk , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Magnus Damm , Heiko Stuebner , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Paul Walmsley , Samuel Holland , Michael Walle , Inochi Amaoto , Orson Zhai , Baolin Wang , Chunyan Zhang , Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Hammer Hsieh , Nobuhiro Iwamatsu , Alexey Charkov , Sean Anderson , Michal Simek , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, chrome-platform@lists.linux.dev, imx@lists.linux.dev, linux-mips@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-riscv@lists.infradead.org, sophgo@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev References: <20de6cd60c2938aad2d21397b92742849418ab1b.1783263835.git.ukleinek@kernel.org> <973f3d6f-6ff4-4685-9c9f-b07987f74d98@linux.dev> From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDA4MyBTYWx0ZWRfX+B5NscMDJXdR vtvA/K50rFFau81xmHVRLTvupy8x/9p1/+5F1wWr9Ttc7QP8mIchraVLxbY/ekRQAM/fozwhpCX x1ZfEwglF9rCW2JKcfW3Pr+N6n4yXRfh1gXwwpHuC1YlpBziXe3+okQ08Au3lACkURRx82R/GKs T/456FEO0zsqw1K8timB6jc2Fx94Qf7qbNRLJ8HwF2LOBqE5Uj+Dt3XYocAJ9IOuAQvkbMNcNbL vuzU3CJ4rOonvAMsG97VtyrnQiEqHneTm4tD6NQdkXvOnxJdqfk0nXeBOGEMzQV9leqGDMM/ts5 tCTWmBTb9wR2nSSOWQH2ydBDr5mJLl5y2BGI93QDx+PbEZduXtVc8Xtt420era1RJilh1+xflxI t+zpKDuWd3aCK9AVSVqcpbNcOFw82gkJduxAlynQGWY+YmPUFeLdbAUcvxHHbGpfIfV8URx6AJi kQNgBIt0qL6XdPcOYrA== X-Proofpoint-ORIG-GUID: Qg_WrtOkUQNCwNWPyvP4Mafix_dkTbkw X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDA4MyBTYWx0ZWRfX7vY7hZ3yHOAk bEe4b+YBmxekMeZefeZQ7fgluSpMVMnSZP8YjXM5wt52kC8pBXskpV7tTmBPfXzZ38UP3amBPWn bcaujp0hC/KAVEfW8wwDl7V1MwDjS94= X-Proofpoint-GUID: Qg_WrtOkUQNCwNWPyvP4Mafix_dkTbkw X-Authority-Analysis: v=2.4 cv=f9N4wuyM c=1 sm=1 tr=0 ts=6a4b6726 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=8pif782wAAAA:8 a=IpJZQVW2AAAA:8 a=TiEZW8bMWLlPbLH3YMsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=IawgGOuG5U0WyFbmm1f5:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-05_02,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 impostorscore=0 bulkscore=0 suspectscore=0 clxscore=1015 spamscore=0 phishscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060083 Hi Uwe, On 6/7/26 09:19, Uwe Kleine-König (The Capable Hub) wrote: > Hello Chen, > > On Mon, Jul 06, 2026 at 08:33:47AM +0800, Chen Wang wrote: >> On 7/5/2026 11:14 PM, Uwe Kleine-König (The Capable Hub) wrote: >>> - Use a single space in a of_device_id array terminator; A single space >>> after the opening { and before the closing } in non-empty >>> initializers; >>> - No comma after an array terminator; >>> - Also no trailing comma after a named initializer iff the >> iff -> if > > This is actually intended. iff = "if and only if", see e.g. > https://en.wikipedia.org/wiki/If_and_only_if . I agree this scientific idiomatic expression is not well known by non-native English speakers, and using the expanded form is just simpler to review (thinking at non-native English speaker reading your commit in the future). > >>> closing } is on the same line; >>> >>> Signed-off-by: Uwe Kleine-König (The Capable Hub) >> >> [......]