From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8294A22D4E2 for ; Wed, 26 Feb 2025 18:38:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740595117; cv=none; b=GeWbbWYK1UUzbnVJe3RioLxA6rigkKUO37Ot/Gem+xtoJPZMKDRAeTz31nbeg9leJ9GHA43nYERViXybulV0H0pZPKkU+zOC7WsfWBpvAA3h3pdtGCxWh+NlvALxB9+g3FulVzFd9/u0j6hIbhegBKebM9tfLBed3U+lFROcMgY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740595117; c=relaxed/simple; bh=4pE8iNhrmO71LZGB2PEKoAbu2e3X350ddkt001DYnro=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ixd6Ud25D1IcI0KkEAb2XkgLbsgHSv7js7st7gWbxutro72+c8J9CHcuqS/jX6wWcsvOrSoAGngYK1tR//sL+ZB7cINiML84yUPMKHxek4Y6IY/gOaynuqiqiGaeR75hOysxzZUUeIWpoLl6BVUi5geuxUZzuuQaXDkTJZ4S0l4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CshK/79d; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CshK/79d" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740595114; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Po4dipnmwfGs5ho6Uar/3eIBvd8Wea1v5VEnmsiU7UA=; b=CshK/79dTXTwicjtWzFtbfjANHpjKM/rUCnXCIdneOO60dN2mbQa6rBRLuKi+U4JVgsDRg QnVNFX9tEkMwgxljigJm0ZvvmVLjrsSF4iLZM8I7QaeB6XS6P1IkF9xClx3aGmDi/ng0Zu sxUCEhhwURSlbd/tazmasZMqjF3OFNw= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-481-SJD0tXZKNC-UuFcF27Ycaw-1; Wed, 26 Feb 2025 13:38:31 -0500 X-MC-Unique: SJD0tXZKNC-UuFcF27Ycaw-1 X-Mimecast-MFC-AGG-ID: SJD0tXZKNC-UuFcF27Ycaw_1740595110 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-abb61c30566so4928266b.2 for ; Wed, 26 Feb 2025 10:38:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740595109; x=1741199909; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Po4dipnmwfGs5ho6Uar/3eIBvd8Wea1v5VEnmsiU7UA=; b=jMhdYqg+zhzqJ1kXZcGWElUcTo81zrYJOr4gb86UXM8x4nA27A1i4jrTut4BM7cflL AsnSd00mHqxTeL5Cr0/zzhUg5ZTI7k/StEyCGYfwEwsqys7k7UQnIsPkKHg4LANCwOSU NSb+jlemZV9h8lai8tVaWX+sSH1lLGOLA+QAvi9+gUD39zS3RUudR3q3UqXZecYDtnVx naFY/eL8Hfg43lZKlTm8sp56hGseZlnKv/5GnuVGl8V6qk3CN18o1Ztn9COc/4GLS1qt AtHugSofhaConNMftIQTN2XYtHgFC4X/BYzxXxvcXAylBHkWlqgu+TRGv/vQpcKPlkUY an+g== X-Forwarded-Encrypted: i=1; AJvYcCXCf4R9gJNLZ5C+ep0Lp1PfjhUxqeVSST+DPFSCbmCq8IKjrGf7FHs2pWcQyVvLW0hHB4IdF/CZ0nOg@vger.kernel.org X-Gm-Message-State: AOJu0Yz3Tv2hT/lRQVj1a716JyulL1XDigJfpzgsYqRW4IJgpZEzAAzk +nebxX6Ino1WB1kdtHQ77/AZLXu3mKTVHyG/NrkItVruI4HxWlRtnCyrGBlo5zE12ObtZEp9gFL 4mIHE8ICxV0V2D6Qx3XfaK+ctSIDQq3MolzDtqyzzRexAmkySl1EGdpODoj4= X-Gm-Gg: ASbGncscoJhkVW8muRpiuI548CakjS66SaIuXNOfAM/eUgmUsflpe7QXxfV/EFvEgoy DjHVzNqGAS1tpOEpkuL8EHMnNxEr1Zy3UtpJxmNNL97k2RQpVFV3IhXTHVNzJvPlcttt11drBfJ SMFwQPvVLhvfmhoef7SPbpVB4KOJaFj1fb4qFfaRzHGmreGFnZtBs7u0wYUIlXVKpgbNb0kpOiY fl7CDC2V8+r430868VODCPocd/3x4AxxWIPfLOF0zbGsnGFGLkZjd32MPXDtXM5i05c16h0vRpV pc8zFzBBO2SY3bMPaavk X-Received: by 2002:a17:906:6185:b0:ab7:c1d5:14f9 with SMTP id a640c23a62f3a-abeeecf6f63mr518736366b.10.1740595109603; Wed, 26 Feb 2025 10:38:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IGCDnvlNLlcOiBeBNB6S3TtqOxMTUK/PR46JW7lLq0KgREP2FusBvOHa60dTZ6MWayPAjFhrw== X-Received: by 2002:a17:906:6185:b0:ab7:c1d5:14f9 with SMTP id a640c23a62f3a-abeeecf6f63mr518730666b.10.1740595109199; Wed, 26 Feb 2025 10:38:29 -0800 (PST) Received: from [192.168.10.81] ([176.206.102.52]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-abed20ac11bsm364226166b.163.2025.02.26.10.38.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Feb 2025 10:38:28 -0800 (PST) Message-ID: Date: Wed, 26 Feb 2025 19:38:21 +0100 Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/7] KVM: x86: nVMX IRQ fix and VM teardown cleanups To: Sean Christopherson , Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Huacai Chen , Madhavan Srinivasan , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Aaron Lewis , Jim Mattson , Yan Zhao , Rick P Edgecombe , Kai Huang , Isaku Yamahata References: <20250224235542.2562848-1-seanjc@google.com> From: Paolo Bonzini Content-Language: en-US Autocrypt: addr=pbonzini@redhat.com; keydata= xsEhBFRCcBIBDqDGsz4K0zZun3jh+U6Z9wNGLKQ0kSFyjN38gMqU1SfP+TUNQepFHb/Gc0E2 CxXPkIBTvYY+ZPkoTh5xF9oS1jqI8iRLzouzF8yXs3QjQIZ2SfuCxSVwlV65jotcjD2FTN04 hVopm9llFijNZpVIOGUTqzM4U55sdsCcZUluWM6x4HSOdw5F5Utxfp1wOjD/v92Lrax0hjiX DResHSt48q+8FrZzY+AUbkUS+Jm34qjswdrgsC5uxeVcLkBgWLmov2kMaMROT0YmFY6A3m1S P/kXmHDXxhe23gKb3dgwxUTpENDBGcfEzrzilWueOeUWiOcWuFOed/C3SyijBx3Av/lbCsHU Vx6pMycNTdzU1BuAroB+Y3mNEuW56Yd44jlInzG2UOwt9XjjdKkJZ1g0P9dwptwLEgTEd3Fo UdhAQyRXGYO8oROiuh+RZ1lXp6AQ4ZjoyH8WLfTLf5g1EKCTc4C1sy1vQSdzIRu3rBIjAvnC tGZADei1IExLqB3uzXKzZ1BZ+Z8hnt2og9hb7H0y8diYfEk2w3R7wEr+Ehk5NQsT2MPI2QBd wEv1/Aj1DgUHZAHzG1QN9S8wNWQ6K9DqHZTBnI1hUlkp22zCSHK/6FwUCuYp1zcAEQEAAc0j UGFvbG8gQm9uemluaSA8cGJvbnppbmlAcmVkaGF0LmNvbT7CwU0EEwECACMFAlRCcBICGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRB+FRAMzTZpsbceDp9IIN6BIA0Ol7MoB15E 11kRz/ewzryFY54tQlMnd4xxfH8MTQ/mm9I482YoSwPMdcWFAKnUX6Yo30tbLiNB8hzaHeRj jx12K+ptqYbg+cevgOtbLAlL9kNgLLcsGqC2829jBCUTVeMSZDrzS97ole/YEez2qFpPnTV0 VrRWClWVfYh+JfzpXmgyhbkuwUxNFk421s4Ajp3d8nPPFUGgBG5HOxzkAm7xb1cjAuJ+oi/K CHfkuN+fLZl/u3E/fw7vvOESApLU5o0icVXeakfSz0LsygEnekDbxPnE5af/9FEkXJD5EoYG SEahaEtgNrR4qsyxyAGYgZlS70vkSSYJ+iT2rrwEiDlo31MzRo6Ba2FfHBSJ7lcYdPT7bbk9 AO3hlNMhNdUhoQv7M5HsnqZ6unvSHOKmReNaS9egAGdRN0/GPDWr9wroyJ65ZNQsHl9nXBqE AukZNr5oJO5vxrYiAuuTSd6UI/xFkjtkzltG3mw5ao2bBpk/V/YuePrJsnPFHG7NhizrxttB nTuOSCMo45pfHQ+XYd5K1+Cv/NzZFNWscm5htJ0HznY+oOsZvHTyGz3v91pn51dkRYN0otqr bQ4tlFFuVjArBZcapSIe6NV8C4cEiSTOwE0EVEJx7gEIAMeHcVzuv2bp9HlWDp6+RkZe+vtl KwAHplb/WH59j2wyG8V6i33+6MlSSJMOFnYUCCL77bucx9uImI5nX24PIlqT+zasVEEVGSRF m8dgkcJDB7Tps0IkNrUi4yof3B3shR+vMY3i3Ip0e41zKx0CvlAhMOo6otaHmcxr35sWq1Jk tLkbn3wG+fPQCVudJJECvVQ//UAthSSEklA50QtD2sBkmQ14ZryEyTHQ+E42K3j2IUmOLriF dNr9NvE1QGmGyIcbw2NIVEBOK/GWxkS5+dmxM2iD4Jdaf2nSn3jlHjEXoPwpMs0KZsgdU0pP JQzMUMwmB1wM8JxovFlPYrhNT9MAEQEAAcLBMwQYAQIACQUCVEJx7gIbDAAKCRB+FRAMzTZp sadRDqCctLmYICZu4GSnie4lKXl+HqlLanpVMOoFNnWs9oRP47MbE2wv8OaYh5pNR9VVgyhD OG0AU7oidG36OeUlrFDTfnPYYSF/mPCxHttosyt8O5kabxnIPv2URuAxDByz+iVbL+RjKaGM GDph56ZTswlx75nZVtIukqzLAQ5fa8OALSGum0cFi4ptZUOhDNz1onz61klD6z3MODi0sBZN Aj6guB2L/+2ZwElZEeRBERRd/uommlYuToAXfNRdUwrwl9gRMiA0WSyTb190zneRRDfpSK5d usXnM/O+kr3Dm+Ui+UioPf6wgbn3T0o6I5BhVhs4h4hWmIW7iNhPjX1iybXfmb1gAFfjtHfL xRUr64svXpyfJMScIQtBAm0ihWPltXkyITA92ngCmPdHa6M1hMh4RDX+Jf1fiWubzp1voAg0 JBrdmNZSQDz0iKmSrx8xkoXYfA3bgtFN8WJH2xgFL28XnqY4M6dLhJwV3z08tPSRqYFm4NMP dRsn0/7oymhneL8RthIvjDDQ5ktUjMe8LtHr70OZE/TT88qvEdhiIVUogHdo4qBrk41+gGQh b906Dudw5YhTJFU3nC6bbF2nrLlB4C/XSiH76ZvqzV0Z/cAMBo5NF/w= In-Reply-To: <20250224235542.2562848-1-seanjc@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/25/25 00:55, Sean Christopherson wrote: > This was _supposed_ to be a tiny one-off patch to fix a nVMX bug where KVM > fails to detect that, after nested VM-Exit, L1 has a pending IRQ (or NMI). > But because x86's nested teardown flows are garbage (KVM simply forces a > nested VM-Exit to put the vCPU back into L1), that simple fix snowballed. > > The immediate issue is that checking for a pending interrupt accesses the > legacy PIC, and x86's kvm_arch_destroy_vm() currently frees the PIC before > destroying vCPUs, i.e. checking for IRQs during the forced nested VM-Exit > results in a NULL pointer deref (or use-after-free if KVM didn't nullify > the PIC pointer). That's patch 1. > > Patch 2 is the original nVMX fix. > > The remaining patches attempt to bring a bit of sanity to x86's VM > teardown code, which has accumulated a lot of cruft over the years. E.g. > KVM currently unloads each vCPU's MMUs in a separate operation from > destroying vCPUs, all because when guest SMP support was added, KVM had a > kludgy MMU teardown flow that broken when a VM had more than one 1 vCPU. > And that oddity lived on, for 18 years... Queued patches 1 and 2 to kvm/master, and everything to kvm/queue (pending a little more testing and the related TDX change). Paolo