From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B5D8C433F5 for ; Mon, 2 May 2022 13:28:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1385271AbiEBNcC (ORCPT ); Mon, 2 May 2022 09:32:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1385267AbiEBNcB (ORCPT ); Mon, 2 May 2022 09:32:01 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3557512AD8 for ; Mon, 2 May 2022 06:28:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651498112; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2zV+k9kqlgz67AfOxcNykb0h39cTNVnn0WXnNEGgjk4=; b=M/bOdoL2S3N0JICWRmvfdoNBvP4iNrDAP1wSgx/MeZZQL2CSowHRGcH3mF5Gt1s8xHPhCN SX7OFMMemNWaKzv/qjEmY3I630B0PmkjWeVJZ+08PF/1KgZ0hh5grd8LMv9v5B3qjzJc7d UaFePn/FknHIegcRpdvjKAe8qaTrvR4= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-17-zmNoGPIFNWeuEJhonujwMA-1; Mon, 02 May 2022 09:28:31 -0400 X-MC-Unique: zmNoGPIFNWeuEJhonujwMA-1 Received: by mail-wr1-f69.google.com with SMTP id s14-20020adfa28e000000b0020ac7532f08so5299448wra.15 for ; Mon, 02 May 2022 06:28:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=2zV+k9kqlgz67AfOxcNykb0h39cTNVnn0WXnNEGgjk4=; b=ImbVfwB+dfvAZ/7YNZ17rXx66FrLqfCKQ69agsshzr5aE+mX2J9ws5ZF6HOFjQiwTH B//KFwzKjiWO1p7gN0OJD3ucD3TiPkUfDABZKz28g/E+vy0RpeqMjvOejVIDm6z096H7 Yq8/oj0Cw08Z8+cjVgSWgRCqrxnkyLDwa53b3eMh1tavUzrROMkZi84Sef5bZ6/VqMvl 6TKTNPA2+crp5yQV/hbQRjGq1hHoMiXv12ZWa0yQ/+Ia+b8+Tj9Vva3bZ91IssySQaIo Eku6sCVl/CTjiXhCjC10zJ1ORr3cAIoX1sFv9fY14DitGFUDE3AMlpJMPBY33my4K5uC jkdA== X-Gm-Message-State: AOAM5339yw9261JrOLSD5JukBboRSBWtF0jzlSR+GbL2cYYGxKgQNKV2 PtQjoz/7kgQnTts1bLL4N+ikEASPfGLEpHBA/xAk0Yd40fHMS+MLTAvfGZqeiI7Exy6KEWGNHtY lsS6agdcBuYLmC8QYR0gn7A== X-Received: by 2002:a05:600c:1c20:b0:394:25cb:1404 with SMTP id j32-20020a05600c1c2000b0039425cb1404mr12244404wms.52.1651498109824; Mon, 02 May 2022 06:28:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzu2jM2LG+DX+dIVzq45o/V1TxQWIpFsCwnWfT+RmC19xyv+UYhuI/wi7PI/5TDnuN7eFlQ9w== X-Received: by 2002:a05:600c:1c20:b0:394:25cb:1404 with SMTP id j32-20020a05600c1c2000b0039425cb1404mr12244330wms.52.1651498109516; Mon, 02 May 2022 06:28:29 -0700 (PDT) Received: from [192.168.1.129] ([92.176.231.205]) by smtp.gmail.com with ESMTPSA id l3-20020adfa383000000b0020c5253d8bcsm6985850wrb.8.2022.05.02.06.28.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 May 2022 06:28:29 -0700 (PDT) Message-ID: Date: Mon, 2 May 2022 15:28:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 2/3] drm/fb-helper: Rename preferred_bpp drm_fbdev_generic_setup() parameter Content-Language: en-US To: Laurent Pinchart Cc: Alexandre Belloni , Emma Anholt , Chun-Kuang Hu , David Airlie , Laurentiu Palcu , Liviu Dudau , Alexandre Torgue , Gurchetan Singh , Paul Cercueil , Gerd Hoffmann , Shawn Guo , linux-stm32@st-md-mailman.stormreply.com, Jerome Brunet , Marek Vasut , Hao Fang , linux-aspeed@lists.ozlabs.org, Samuel Holland , Kevin Hilman , Neil Armstrong , Alexey Brodkin , Michal Simek , Jernej Skrabec , Xinliang Liu , Chen-Yu Tsai , Joel Stanley , Dave Airlie , Xinwei Kong , virtualization@lists.linux-foundation.org, NXP Linux Team , Thomas Zimmermann , Raphael Gallais-Pou , Martin Blumenstingl , Chen Feng , Sascha Hauer , Alison Wang , linux-mips@vger.kernel.org, Sam Ravnborg , Hans de Goede , linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Alain Volmat , Matthias Brugger , linux-amlogic@lists.infradead.org, Mario Limonciello , Evan Quan , Pengutronix Kernel Team , Yong Wu , linux-arm-kernel@lists.infradead.org, Maxime Coquelin , linux-sunxi@lists.linux.dev, amd-gfx@lists.freedesktop.org, Tomi Valkeinen , Hyun Kwon , Boris Brezillon , Andrew Jeffery , Greg Kroah-Hartman , Yannick Fertre , "Pan, Xinhui" , linux-kernel@vger.kernel.org, Claudiu Beznea , linux-renesas-soc@vger.kernel.org, Solomon Chiu , Kieran Bingham , Philippe Cornu , Nicolas Ferre , Alex Deucher , Tian Tao , spice-devel@lists.freedesktop.org, Jyri Sarha , =?UTF-8?Q?Christian_K=c3=b6nig?= References: <20220502084830.285639-1-javierm@redhat.com> <20220502084830.285639-3-javierm@redhat.com> From: Javier Martinez Canillas In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Hello Laurent, On 5/2/22 13:34, Laurent Pinchart wrote: > Hi Javier, > > Thank you for the patch. > Thanks a lot for your feedback. [snip] >> +++ b/drivers/gpu/drm/drm_fb_helper.c >> @@ -2501,8 +2501,16 @@ static const struct drm_client_funcs drm_fbdev_client_funcs = { >> /** >> * drm_fbdev_generic_setup() - Setup generic fbdev emulation >> * @dev: DRM device >> - * @preferred_bpp: Preferred bits per pixel for the device. >> - * @dev->mode_config.preferred_depth is used if this is zero. >> + * @options: options for the registered framebuffer. >> + * >> + * The @options parameter is a multi-field parameter that can contain >> + * different options for the emulated framebuffer device registered. >> + * >> + * The options must be set using DRM_FB_SET_OPTION() and obtained using >> + * DRM_FB_GET_OPTION(). The options field are the following: >> + * >> + * * DRM_FB_BPP: bits per pixel for the device. If the field is not set, >> + * @dev->mode_config.preferred_depth is used instead. > > Do I assume correctly that a driver that would need to set multiple > options would do something like > > drm_fbdev_generic_setup(dev, DRM_FB_SET_OPTION(DRM_FB_BPP, 32) | > DRM_FB_SET_OPTION(DRM_FB_FW, 1)); > That's correct, yes. > ? If so, I would rename DRM_FB_SET_OPTION() to DRM_FB_OPTION() as it's > computing the value of the option bitfield, it doesn't actually set it. > Apart from that, > Right. I'll rename it. > Reviewed-by: Laurent Pinchart > Thanks! -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat