linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Larry Finger" <Larry.Finger@lwfinger.net>,
	"Arnd Bergmann" <arnd@kernel.org>,
	"Dominik Brodowski" <linux@dominikbrodowski.net>,
	linux-kernel@vger.kernel.org
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Hartley Sweeten" <hsweeten@visionengravers.com>,
	"Ian Abbott" <abbotti@mev.co.uk>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Kevin Cernekee" <cernekee@gmail.com>,
	"Lukas Wunner" <lukas@wunner.de>,
	"Manuel Lauss" <manuel.lauss@gmail.com>,
	"Oliver Hartkopp" <socketcan@hartkopp.net>,
	"Olof Johansson" <olof@lixom.net>,
	"Robert Jarzmik" <robert.jarzmik@free.fr>,
	"YOKOTA Hiroshi" <yokota@netlab.is.tsukuba.ac.jp>,
	bcm-kernel-feedback-list@broadcom.com,
	linux-arm-kernel@lists.infradead.org, linux-can@vger.kernel.org,
	linux-mips@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-wireless@vger.kernel.org, Netdev <netdev@vger.kernel.org>
Subject: Re: [RFC 0/6] pcmcia: separate 16-bit support from cardbus
Date: Mon, 27 Feb 2023 21:38:54 +0100	[thread overview]
Message-ID: <c17bff4e-031e-4101-8564-51f6298b1c68@app.fastmail.com> (raw)
In-Reply-To: <3d8f28d7-78df-5276-612c-85b5262a987a@lwfinger.net>

On Mon, Feb 27, 2023, at 21:23, Larry Finger wrote:
> On 2/27/23 07:34, Arnd Bergmann wrote:

>
> Your patch set also breaks my PowerBook G4. The output of 'lspci -nn | grep 
> Network' shows the following before your patch is applied:
>
> 0001:10:12.0 Network controller [0280]: Broadcom Inc. and subsidiaries BCM4306 
> 802.11b/g Wireless LAN Controller [14e4:4320] (rev 03)
> 0001:11:00.0 Network controller [0280]: Broadcom Inc. and subsidiaries BCM4318 
> [AirForce One 54g] 802.11g Wireless LAN Controller [14e4:4318] (rev 02)
>
> The first of these is broken and built into the laptop. The second is plugged 
> into a PCMCIA slot, and uses yenta-socket as a driver.
>
> When your patches are applied, the second entry vanishes.
>
> Yes, this hardware is ancient, but I would prefer having this wifi interface 
> work. I can provide any output you need.

Is this the Cardbus or the PCMCIA version of the BCM4306 device? As far
as I understand this particular chip can be wired up either way inside
of the card, and the PowerBook G4 supports both types of devices.

If it's the PCMCIA version, then dropping support for it was the idea
of the patch series that we can debate, but if it was the Cardbus version
that broke, then this was likely a bug I introduced by accident.

      Arnd

  reply	other threads:[~2023-02-27 20:39 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-27 13:34 [RFC 0/6] pcmcia: separate 16-bit support from cardbus Arnd Bergmann
2023-02-27 13:34 ` [RFC 1/6] pccard: remove bcm63xx socket driver Arnd Bergmann
2023-02-27 21:33   ` Florian Fainelli
2023-03-14  8:53     ` Maxime Bizon
2023-02-27 13:34 ` [RFC 2/6] pccard: split cardbus support from pcmcia Arnd Bergmann
2023-02-27 13:34 ` [RFC 4/6] yenta_socket: remove dead code Arnd Bergmann
2023-02-27 13:34 ` [RFC 5/6] pccard: drop remnants of cardbus support Arnd Bergmann
2023-02-27 13:34 ` [RFC 6/6] pci: hotplug: move cardbus code from drivers/pcmcia Arnd Bergmann
2023-02-27 19:07 ` [RFC 0/6] pcmcia: separate 16-bit support from cardbus Oliver Hartkopp
2023-02-27 19:53   ` Arnd Bergmann
2023-02-27 20:32     ` Oliver Hartkopp
2023-02-27 20:54       ` Marc Kleine-Budde
2023-02-27 20:15 ` Russell King (Oracle)
2023-02-27 21:04   ` Arnd Bergmann
2023-02-28 22:45   ` David Laight
2023-02-28 22:55     ` David Laight
2023-02-27 20:23 ` Larry Finger
2023-02-27 20:38   ` Arnd Bergmann [this message]
2023-02-27 20:59     ` Russell King (Oracle)
2023-02-27 21:09     ` Larry Finger
2023-02-27 21:30       ` Arnd Bergmann
2023-02-28  3:57         ` Larry Finger
2023-02-28  8:37           ` Arnd Bergmann
2023-03-01  1:13             ` Larry Finger
2023-03-01  8:01               ` Arnd Bergmann
2023-02-28 21:35 ` Ondrej Zary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c17bff4e-031e-4101-8564-51f6298b1c68@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=Larry.Finger@lwfinger.net \
    --cc=abbotti@mev.co.uk \
    --cc=arnd@kernel.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=bhelgaas@google.com \
    --cc=cernekee@gmail.com \
    --cc=f.fainelli@gmail.com \
    --cc=hsweeten@visionengravers.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linux@dominikbrodowski.net \
    --cc=lukas@wunner.de \
    --cc=manuel.lauss@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=robert.jarzmik@free.fr \
    --cc=socketcan@hartkopp.net \
    --cc=yokota@netlab.is.tsukuba.ac.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).