From: "Jiaxun Yang" <jiaxun.yang@flygoat.com>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>,
"Johan Almbladh" <johan.almbladh@anyfinetworks.com>
Cc: "linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
linux-kernel@vger.kernel.org,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"paulburton@kernel.org" <paulburton@kernel.org>,
bpf@vger.kernel.org, "Alexei Starovoitov" <ast@kernel.org>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>
Subject: Re: [PATCH 2/2] MIPS: ebpf jit: Implement R4000 workarounds
Date: Mon, 27 Feb 2023 15:47:05 +0000 [thread overview]
Message-ID: <c36effcb-5a5f-49b0-8bbe-cc46addf2959@app.fastmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2302271515100.63909@angie.orcam.me.uk>
在2023年2月27日二月 下午3:18，Maciej W. Rozycki写道：
> On Mon, 27 Feb 2023, Johan Almbladh wrote:
>
>> > > R4000 is a 64-bit CPU, so the 32-bit JIT implementation will not be
>> > > used. From the Makefile:
>> > >
>> > > ifeq ($(CONFIG_32BIT),y)
>> > > obj-$(CONFIG_BPF_JIT) += bpf_jit_comp32.o
>> > > else
>> > > obj-$(CONFIG_BPF_JIT) += bpf_jit_comp64.o
>> > > endif
>> >
>> > It’s common practice to run 32-bit kernel on R4000 based systems to save some memory :-)
>>
>> Ok, I understand.
>
> Likewise:
>
> select CPU_R4000_WORKAROUNDS if 64BIT
> select CPU_R4400_WORKAROUNDS if 64BIT
>
> This only applies to 64-bit operations, which are not used in 32-bit code
> (one reason why these early silicon revisions were originally used with
> 32-bit software only).
Thanks for the info.
Will drop 32bit part from both patch.
>
> Maciej
--
- Jiaxun
next prev parent reply other threads:[~2023-02-27 15:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-22 16:12 [PATCH 0/2] MIPS: Implement two workarounds for BPF JIT Jiaxun Yang
2023-02-22 16:12 ` [PATCH 1/2] MIPS: ebpf jit: Implement DADDI workarounds Jiaxun Yang
2023-02-23 10:10 ` Johan Almbladh
2023-02-23 10:29 ` Jiaxun Yang
2023-02-27 12:17 ` Johan Almbladh
2023-02-27 15:17 ` Maciej W. Rozycki
2023-02-22 16:12 ` [PATCH 2/2] MIPS: ebpf jit: Implement R4000 workarounds Jiaxun Yang
2023-02-23 10:22 ` Johan Almbladh
2023-02-23 10:31 ` Jiaxun Yang
2023-02-27 12:19 ` Johan Almbladh
2023-02-27 15:18 ` Maciej W. Rozycki
2023-02-27 15:47 ` Jiaxun Yang [this message]
2023-02-26 22:09 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c36effcb-5a5f-49b0-8bbe-cc46addf2959@app.fastmail.com \
--to=jiaxun.yang@flygoat.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=johan.almbladh@anyfinetworks.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=paulburton@kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).