[PATCH 0/2] brcmstb-memc-ddr binding updates for MIPS boards

[PATCH 0/2] brcmstb-memc-ddr binding updates for MIPS boards

[Florian Fainelli]

This patch series updates the MIPS-based Broadcom STB chips to use a
proper compatible string for their memory controller node(s) after
501be7cecec9 ("dt-bindings: memory-controller: Define fallback
compatible").

Florian Fainelli (2):
  dt-bindings: memory: Update brcmstb-memc-ddr binding with older chips
  MIPS: BMIPS: Properly define memory controller compatible

 .../bindings/memory-controllers/brcm,brcmstb-memc-ddr.yaml  | 4 ++++
 arch/mips/boot/dts/brcm/bcm7346.dtsi                        | 3 ++-
 arch/mips/boot/dts/brcm/bcm7360.dtsi                        | 3 ++-
 arch/mips/boot/dts/brcm/bcm7362.dtsi                        | 3 ++-
 arch/mips/boot/dts/brcm/bcm7425.dtsi                        | 6 ++++--
 arch/mips/boot/dts/brcm/bcm7435.dtsi                        | 6 ++++--
 6 files changed, 18 insertions(+), 7 deletions(-)

-- 
2.43.0

[PATCH 1/2] dt-bindings: memory: Update brcmstb-memc-ddr binding with older chips

[Florian Fainelli]

The older MIPS-based chips incorporated a memory controller with the
revision A.0.0, update the binding to list that compatible.

Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
---
 .../bindings/memory-controllers/brcm,brcmstb-memc-ddr.yaml    | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/memory-controllers/brcm,brcmstb-memc-ddr.yaml b/Documentation/devicetree/bindings/memory-controllers/brcm,brcmstb-memc-ddr.yaml
index b935894bd4fc..3328c8df8190 100644
--- a/Documentation/devicetree/bindings/memory-controllers/brcm,brcmstb-memc-ddr.yaml
+++ b/Documentation/devicetree/bindings/memory-controllers/brcm,brcmstb-memc-ddr.yaml
@@ -42,6 +42,10 @@ properties:
         items:
           - const: brcm,brcmstb-memc-ddr-rev-b.1.x
           - const: brcm,brcmstb-memc-ddr
+      - description: Revision 0.x controllers
+        items:
+          - const: brcm,brcmstb-memc-ddr-rev-a.0.0
+          - const: brcm,brcmstb-memc-ddr
 
   reg:
     maxItems: 1
-- 
2.43.0

[PATCH 2/2] MIPS: BMIPS: Properly define memory controller compatible

[Florian Fainelli]

With the DT binding updated with 501be7cecec9 ("dt-bindings:
memory-controller: Define fallback compatible") we need to define a
proper compatible string for the memory controller node(s).

Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
---
 arch/mips/boot/dts/brcm/bcm7346.dtsi | 3 ++-
 arch/mips/boot/dts/brcm/bcm7360.dtsi | 3 ++-
 arch/mips/boot/dts/brcm/bcm7362.dtsi | 3 ++-
 arch/mips/boot/dts/brcm/bcm7425.dtsi | 6 ++++--
 arch/mips/boot/dts/brcm/bcm7435.dtsi | 6 ++++--
 5 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/arch/mips/boot/dts/brcm/bcm7346.dtsi b/arch/mips/boot/dts/brcm/bcm7346.dtsi
index 2afa0dada575..9d6f97e02ff9 100644
--- a/arch/mips/boot/dts/brcm/bcm7346.dtsi
+++ b/arch/mips/boot/dts/brcm/bcm7346.dtsi
@@ -531,7 +531,8 @@ memc-arb@1000 {
 			};
 
 			memc-ddr@2000 {
-				compatible = "brcm,brcmstb-memc-ddr";
+				compatible = "brcm,brcmstb-memc-ddr-rev-a.0.0",
+					     "brcm,brcmstb-memc-ddr";
 				reg = <0x2000 0x300>;
 			};
 
diff --git a/arch/mips/boot/dts/brcm/bcm7360.dtsi b/arch/mips/boot/dts/brcm/bcm7360.dtsi
index a57cacea91cf..a7f60f059e50 100644
--- a/arch/mips/boot/dts/brcm/bcm7360.dtsi
+++ b/arch/mips/boot/dts/brcm/bcm7360.dtsi
@@ -450,7 +450,8 @@ memc-arb@1000 {
 			};
 
 			memc-ddr@2000 {
-				compatible = "brcm,brcmstb-memc-ddr";
+				compatible = "brcm,brcmstb-memc-ddr-rev-a.0.0",
+					     "brcm,brcmstb-memc-ddr";
 				reg = <0x2000 0x300>;
 			};
 
diff --git a/arch/mips/boot/dts/brcm/bcm7362.dtsi b/arch/mips/boot/dts/brcm/bcm7362.dtsi
index 728b9e9f84b8..2d483cbf254f 100644
--- a/arch/mips/boot/dts/brcm/bcm7362.dtsi
+++ b/arch/mips/boot/dts/brcm/bcm7362.dtsi
@@ -446,7 +446,8 @@ memc-arb@1000 {
 			};
 
 			memc-ddr@2000 {
-				compatible = "brcm,brcmstb-memc-ddr";
+				compatible = "brcm,brcmstb-memc-ddr-rev-a.0.0",
+					     "brcm,brcmstb-memc-ddr";
 				reg = <0x2000 0x300>;
 			};
 
diff --git a/arch/mips/boot/dts/brcm/bcm7425.dtsi b/arch/mips/boot/dts/brcm/bcm7425.dtsi
index 62588c53d356..c3bb020ff2b5 100644
--- a/arch/mips/boot/dts/brcm/bcm7425.dtsi
+++ b/arch/mips/boot/dts/brcm/bcm7425.dtsi
@@ -542,7 +542,8 @@ memc-arb@1000 {
 			};
 
 			memc-ddr@2000 {
-				compatible = "brcm,brcmstb-memc-ddr";
+				compatible = "brcm,brcmstb-memc-ddr-rev-a.0.0",
+					     "brcm,brcmstb-memc-ddr";
 				reg = <0x2000 0x300>;
 			};
 
@@ -569,7 +570,8 @@ memc-arb@1000 {
 			};
 
 			memc-ddr@2000 {
-				compatible = "brcm,brcmstb-memc-ddr";
+				compatible = "brcm,brcmstb-memc-ddr-rev-a.0.0",
+					     "brcm,brcmstb-memc-ddr";
 				reg = <0x2000 0x300>;
 			};
 
diff --git a/arch/mips/boot/dts/brcm/bcm7435.dtsi b/arch/mips/boot/dts/brcm/bcm7435.dtsi
index cfdf9804e126..60cfa4074cce 100644
--- a/arch/mips/boot/dts/brcm/bcm7435.dtsi
+++ b/arch/mips/boot/dts/brcm/bcm7435.dtsi
@@ -558,7 +558,8 @@ memc-arb@1000 {
 			};
 
 			memc-ddr@2000 {
-				compatible = "brcm,brcmstb-memc-ddr";
+				compatible = "brcm,brcmstb-memc-ddr-rev-a.0.0",
+					     "brcm,brcmstb-memc-ddr";
 				reg = <0x2000 0x300>;
 			};
 
@@ -585,7 +586,8 @@ memc-arb@1000 {
 			};
 
 			memc-ddr@2000 {
-				compatible = "brcm,brcmstb-memc-ddr";
+				compatible = "brcm,brcmstb-memc-ddr-rev-a.0.0",
+					     "brcm,brcmstb-memc-ddr";
 				reg = <0x2000 0x300>;
 			};
 
-- 
2.43.0

Re: [PATCH 1/2] dt-bindings: memory: Update brcmstb-memc-ddr binding with older chips

[Rob Herring (Arm)]

On Tue, 29 Jul 2025 13:52:12 -0700, Florian Fainelli wrote:
> The older MIPS-based chips incorporated a memory controller with the
> revision A.0.0, update the binding to list that compatible.
> 
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
> ---
>  .../bindings/memory-controllers/brcm,brcmstb-memc-ddr.yaml    | 4 ++++
>  1 file changed, 4 insertions(+)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>

Re: (subset) [PATCH 1/2] dt-bindings: memory: Update brcmstb-memc-ddr binding with older chips

[Krzysztof Kozlowski]

On Tue, 29 Jul 2025 13:52:12 -0700, Florian Fainelli wrote:
> The older MIPS-based chips incorporated a memory controller with the
> revision A.0.0, update the binding to list that compatible.
> 
> 

Applied, thanks!

[1/2] dt-bindings: memory: Update brcmstb-memc-ddr binding with older chips
      https://git.kernel.org/krzk/linux-mem-ctrl/c/1aba1eab0bd896928ae20dbf1f60a175a6e1ad0f

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Re: [PATCH 0/2] brcmstb-memc-ddr binding updates for MIPS boards

[Thomas Bogendoerfer]

On Tue, Jul 29, 2025 at 01:52:11PM -0700, Florian Fainelli wrote:
> This patch series updates the MIPS-based Broadcom STB chips to use a
> proper compatible string for their memory controller node(s) after
> 501be7cecec9 ("dt-bindings: memory-controller: Define fallback
> compatible").
> 
> Florian Fainelli (2):
>   dt-bindings: memory: Update brcmstb-memc-ddr binding with older chips
>   MIPS: BMIPS: Properly define memory controller compatible
> 
>  .../bindings/memory-controllers/brcm,brcmstb-memc-ddr.yaml  | 4 ++++
>  arch/mips/boot/dts/brcm/bcm7346.dtsi                        | 3 ++-
>  arch/mips/boot/dts/brcm/bcm7360.dtsi                        | 3 ++-
>  arch/mips/boot/dts/brcm/bcm7362.dtsi                        | 3 ++-
>  arch/mips/boot/dts/brcm/bcm7425.dtsi                        | 6 ++++--
>  arch/mips/boot/dts/brcm/bcm7435.dtsi                        | 6 ++++--
>  6 files changed, 18 insertions(+), 7 deletions(-)

series applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

Re: [PATCH 0/2] brcmstb-memc-ddr binding updates for MIPS boards

[Krzysztof Kozlowski]

On 29/08/2025 12:21, Thomas Bogendoerfer wrote:
> On Tue, Jul 29, 2025 at 01:52:11PM -0700, Florian Fainelli wrote:
>> This patch series updates the MIPS-based Broadcom STB chips to use a
>> proper compatible string for their memory controller node(s) after
>> 501be7cecec9 ("dt-bindings: memory-controller: Define fallback
>> compatible").
>>
>> Florian Fainelli (2):
>>   dt-bindings: memory: Update brcmstb-memc-ddr binding with older chips
>>   MIPS: BMIPS: Properly define memory controller compatible
>>
>>  .../bindings/memory-controllers/brcm,brcmstb-memc-ddr.yaml  | 4 ++++
>>  arch/mips/boot/dts/brcm/bcm7346.dtsi                        | 3 ++-
>>  arch/mips/boot/dts/brcm/bcm7360.dtsi                        | 3 ++-
>>  arch/mips/boot/dts/brcm/bcm7362.dtsi                        | 3 ++-
>>  arch/mips/boot/dts/brcm/bcm7425.dtsi                        | 6 ++++--
>>  arch/mips/boot/dts/brcm/bcm7435.dtsi                        | 6 ++++--
>>  6 files changed, 18 insertions(+), 7 deletions(-)
> 
> series applied to mips-next.

Why entire series? You were notified two weeks ago that I already took
the driver subsystem patch.

Best regards,
Krzysztof

Re: [PATCH 0/2] brcmstb-memc-ddr binding updates for MIPS boards

[Krzysztof Kozlowski]

On 29/08/2025 12:37, Krzysztof Kozlowski wrote:
> On 29/08/2025 12:21, Thomas Bogendoerfer wrote:
>> On Tue, Jul 29, 2025 at 01:52:11PM -0700, Florian Fainelli wrote:
>>> This patch series updates the MIPS-based Broadcom STB chips to use a
>>> proper compatible string for their memory controller node(s) after
>>> 501be7cecec9 ("dt-bindings: memory-controller: Define fallback
>>> compatible").
>>>
>>> Florian Fainelli (2):
>>>   dt-bindings: memory: Update brcmstb-memc-ddr binding with older chips
>>>   MIPS: BMIPS: Properly define memory controller compatible
>>>
>>>  .../bindings/memory-controllers/brcm,brcmstb-memc-ddr.yaml  | 4 ++++
>>>  arch/mips/boot/dts/brcm/bcm7346.dtsi                        | 3 ++-
>>>  arch/mips/boot/dts/brcm/bcm7360.dtsi                        | 3 ++-
>>>  arch/mips/boot/dts/brcm/bcm7362.dtsi                        | 3 ++-
>>>  arch/mips/boot/dts/brcm/bcm7425.dtsi                        | 6 ++++--
>>>  arch/mips/boot/dts/brcm/bcm7435.dtsi                        | 6 ++++--
>>>  6 files changed, 18 insertions(+), 7 deletions(-)
>>
>> series applied to mips-next.
> 
> Why entire series? You were notified two weeks ago that I already took
> the driver subsystem patch.

...and you do not have even ack from memory-controllers for that patch.

Best regards,
Krzysztof

Re: [PATCH 0/2] brcmstb-memc-ddr binding updates for MIPS boards

[Thomas Bogendoerfer]

On Fri, Aug 29, 2025 at 12:39:00PM +0200, Krzysztof Kozlowski wrote:
> On 29/08/2025 12:37, Krzysztof Kozlowski wrote:
> > On 29/08/2025 12:21, Thomas Bogendoerfer wrote:
> >> On Tue, Jul 29, 2025 at 01:52:11PM -0700, Florian Fainelli wrote:
> >>> This patch series updates the MIPS-based Broadcom STB chips to use a
> >>> proper compatible string for their memory controller node(s) after
> >>> 501be7cecec9 ("dt-bindings: memory-controller: Define fallback
> >>> compatible").
> >>>
> >>> Florian Fainelli (2):
> >>>   dt-bindings: memory: Update brcmstb-memc-ddr binding with older chips
> >>>   MIPS: BMIPS: Properly define memory controller compatible
> >>>
> >>>  .../bindings/memory-controllers/brcm,brcmstb-memc-ddr.yaml  | 4 ++++
> >>>  arch/mips/boot/dts/brcm/bcm7346.dtsi                        | 3 ++-
> >>>  arch/mips/boot/dts/brcm/bcm7360.dtsi                        | 3 ++-
> >>>  arch/mips/boot/dts/brcm/bcm7362.dtsi                        | 3 ++-
> >>>  arch/mips/boot/dts/brcm/bcm7425.dtsi                        | 6 ++++--
> >>>  arch/mips/boot/dts/brcm/bcm7435.dtsi                        | 6 ++++--
> >>>  6 files changed, 18 insertions(+), 7 deletions(-)
> >>
> >> series applied to mips-next.
> > 
> > Why entire series? You were notified two weeks ago that I already took
> > the driver subsystem patch.

I haven't got a mail in this thread from you about taking the first patch.

> ...and you do not have even ack from memory-controllers for that patch.

sorry, I'll drop the patch then.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

Re: [PATCH 0/2] brcmstb-memc-ddr binding updates for MIPS boards

[Florian Fainelli]

On 8/29/25 08:36, Thomas Bogendoerfer wrote:
> On Fri, Aug 29, 2025 at 12:39:00PM +0200, Krzysztof Kozlowski wrote:
>> On 29/08/2025 12:37, Krzysztof Kozlowski wrote:
>>> On 29/08/2025 12:21, Thomas Bogendoerfer wrote:
>>>> On Tue, Jul 29, 2025 at 01:52:11PM -0700, Florian Fainelli wrote:
>>>>> This patch series updates the MIPS-based Broadcom STB chips to use a
>>>>> proper compatible string for their memory controller node(s) after
>>>>> 501be7cecec9 ("dt-bindings: memory-controller: Define fallback
>>>>> compatible").
>>>>>
>>>>> Florian Fainelli (2):
>>>>>    dt-bindings: memory: Update brcmstb-memc-ddr binding with older chips
>>>>>    MIPS: BMIPS: Properly define memory controller compatible
>>>>>
>>>>>   .../bindings/memory-controllers/brcm,brcmstb-memc-ddr.yaml  | 4 ++++
>>>>>   arch/mips/boot/dts/brcm/bcm7346.dtsi                        | 3 ++-
>>>>>   arch/mips/boot/dts/brcm/bcm7360.dtsi                        | 3 ++-
>>>>>   arch/mips/boot/dts/brcm/bcm7362.dtsi                        | 3 ++-
>>>>>   arch/mips/boot/dts/brcm/bcm7425.dtsi                        | 6 ++++--
>>>>>   arch/mips/boot/dts/brcm/bcm7435.dtsi                        | 6 ++++--
>>>>>   6 files changed, 18 insertions(+), 7 deletions(-)
>>>>
>>>> series applied to mips-next.
>>>
>>> Why entire series? You were notified two weeks ago that I already took
>>> the driver subsystem patch.
> 
> I haven't got a mail in this thread from you about taking the first patch.

That is curious, it was in response to patch #1 and you were copied:

https://lore.kernel.org/all/175508140104.40429.8279921018476182386.b4-ty@linaro.org/

> 
>> ...and you do not have even ack from memory-controllers for that patch.
> 
> sorry, I'll drop the patch then.

Thanks!
-- 
Florian