From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 279C2C47080 for ; Tue, 1 Jun 2021 12:02:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F04B0613F1 for ; Tue, 1 Jun 2021 12:02:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233818AbhFAMEf (ORCPT ); Tue, 1 Jun 2021 08:04:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:33644 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233779AbhFAMEd (ORCPT ); Tue, 1 Jun 2021 08:04:33 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 37F9660200; Tue, 1 Jun 2021 12:02:48 +0000 (UTC) Subject: Re: [PATCH 0/7] clk: clean up legacy clock interfaces To: Arnd Bergmann , linux-clk@vger.kernel.org Cc: Arnd Bergmann , Dmitry Osipenko , Florian Fainelli , Geert Uytterhoeven , John Crispin , Jonas Gorski , Krzysztof Kozlowski , Michael Turquette , Russell King , Stephen Boyd , Thomas Bogendoerfer , linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org References: <20210531184749.2475868-1-arnd@kernel.org> From: Greg Ungerer Message-ID: Date: Tue, 1 Jun 2021 22:02:46 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210531184749.2475868-1-arnd@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Hi Arnd, On 1/6/21 4:47 am, Arnd Bergmann wrote: > From: Arnd Bergmann > > A recent discussion about legacy clk interface users revealed > that there are only two platforms remaining that provide their own > clk_get()/clk_put() implementations, MIPS ar7 and and m68k coldfire. > > I managed to rework both of these to just use the normal clkdev code, > and fold CONFIG_CLKDEV_LOOKUP into CONFIG_HAVE_CLK as it is now shared > among all users. > > As I noticed that the ar7 clock implementation and the ralink version > are rather trivial, I ended up converting those to use the common-clk > interfaces as well, though this is unrelated to the other changes. > > Arnd > > Link: https://lore.kernel.org/lkml/CAK8P3a2XsrfUJQQAfnGknh8HiA-D9L_wmEoAgXU89KqagE31NQ@mail.gmail.com/ > > Arnd Bergmann (7): > mips: ar7: convert to clkdev_lookup > mips: ar7: convert to CONFIG_COMMON_CLK > mips: ralink: convert to CONFIG_COMMON_CLK > m68k: coldfire: use clkdev_lookup on most coldfire > m68k: coldfire: remove private clk_get/clk_put > clkdev: remove CONFIG_CLKDEV_LOOKUP > clkdev: remove unused clkdev_alloc() interfaces > > arch/arm/Kconfig | 2 - > arch/m68k/coldfire/clk.c | 21 ----- > arch/m68k/coldfire/m5206.c | 25 +++--- > arch/m68k/coldfire/m520x.c | 51 +++++------ > arch/m68k/coldfire/m523x.c | 42 ++++----- > arch/m68k/coldfire/m5249.c | 33 +++---- > arch/m68k/coldfire/m525x.c | 33 +++---- > arch/m68k/coldfire/m5272.c | 35 +++----- > arch/m68k/coldfire/m527x.c | 46 ++++------ > arch/m68k/coldfire/m528x.c | 42 ++++----- > arch/m68k/coldfire/m5307.c | 27 +++--- > arch/m68k/coldfire/m53xx.c | 80 ++++++++--------- > arch/m68k/coldfire/m5407.c | 25 +++--- > arch/m68k/coldfire/m5441x.c | 126 +++++++++++++-------------- > arch/m68k/coldfire/m54xx.c | 33 +++---- > arch/m68k/include/asm/mcfclk.h | 5 -- > arch/mips/Kconfig | 6 +- > arch/mips/ar7/clock.c | 113 ++++++------------------ > arch/mips/include/asm/mach-ar7/ar7.h | 4 - > arch/mips/pic32/Kconfig | 1 - > arch/mips/ralink/Kconfig | 5 -- > arch/mips/ralink/clk.c | 64 +------------- > arch/sh/Kconfig | 1 - > drivers/clk/Kconfig | 6 +- > drivers/clk/Makefile | 3 +- > drivers/clk/clkdev.c | 28 ------ > drivers/clocksource/Kconfig | 6 +- > drivers/mmc/host/Kconfig | 4 +- > drivers/staging/board/Kconfig | 2 +- > include/linux/clkdev.h | 5 -- > sound/soc/dwc/Kconfig | 2 +- > sound/soc/rockchip/Kconfig | 14 +-- > 32 files changed, 320 insertions(+), 570 deletions(-) Looks really good, thanks for doing this. I have test compiled and run some of the ColdFire targets with these changes. Everything checked out good. So for the m68k/Coldfire parts (with the one munged writew() change fixed): Acked-by: Greg Ungerer Tested-by: Greg Ungerer Regards Greg