From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: Jackie Liu <liu.yun@linux.dev>,
linus.walleij@linaro.org, ralf@linux-mips.org,
tsbogend@alpha.franken.de
Cc: linux-mips@vger.kernel.org, jic23@kernel.org, andy.shevchenko@gmail.com
Subject: Re: [PATCH v3] MIPS: rb532: move GPIOD definition into C-files
Date: Wed, 30 Mar 2022 11:52:53 +0300 [thread overview]
Message-ID: <cd575f70-5475-b2b0-1b71-93ebf3b14ccf@gmail.com> (raw)
In-Reply-To: <20220330020727.3303088-1-liu.yun@linux.dev>
On 3/30/22 5:07 AM, Jackie Liu wrote:
> From: Jackie Liu <liuyun01@kylinos.cn>
>
> My kernel robot report build error from drivers/iio/adc/da9150-gpadc.c,
Reports.
> We define GPIOD in rb.h, in fact it should only be used in gpio.c, but
> it affects the driver da9150-gpadc.c which goes against the original
> intention of the design, just move it to his scope.
s/his/its/.
> Suggested-by: Jonathan Cameron <jic23@kernel.org>
> Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Reported-by: k2ci <kernel-bot@kylinos.cn>
> Signed-off-by: Jackie Liu <liuyun01@kylinos.cn>
> ---
> v1->v2:
> Keep GPIONMIEN and IMASK6 as hardware document.
> v2->v3:
> he to it.
What? :-)
[...]
MBR, Sergey
prev parent reply other threads:[~2022-03-30 8:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 1:45 [PATCH] MIPS: rb532: move GPIOD definition into C-files Jackie Liu
2022-03-29 12:54 ` Andy Shevchenko
2022-03-30 1:46 ` Jackie Liu
2022-03-30 6:42 ` Thomas Bogendoerfer
2022-03-30 9:23 ` Andy Shevchenko
2022-03-30 9:32 ` Thomas Bogendoerfer
2022-03-30 9:41 ` Andy Shevchenko
2022-03-30 9:56 ` Jackie Liu
2022-03-30 10:01 ` Andy Shevchenko
2022-03-30 10:04 ` Jackie Liu
2022-03-30 10:02 ` Thomas Bogendoerfer
2022-03-30 2:01 ` [PATCH v2] " Jackie Liu
2022-03-30 2:07 ` [PATCH v3] " Jackie Liu
2022-03-30 8:52 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd575f70-5475-b2b0-1b71-93ebf3b14ccf@gmail.com \
--to=sergei.shtylyov@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=jic23@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-mips@vger.kernel.org \
--cc=liu.yun@linux.dev \
--cc=ralf@linux-mips.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).