From: Stephen Boyd <sboyd@kernel.org>
To: "Andy Shevchenko" <andriy.shevchenko@intel.com>,
"Théo Lebrun" <theo.lebrun@bootlin.com>
Cc: "Gregory CLEMENT" <gregory.clement@bootlin.com>,
"Michael Turquette" <mturquette@baylibre.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Rafał Miłecki" <rafal@milecki.pl>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Vladimir Kondratiev" <vladimir.kondratiev@mobileye.com>,
linux-mips@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Tawfik Bayouk" <tawfik.bayouk@mobileye.com>,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH v8 03/10] clk: eyeq5: add platform driver, and init routine at of_clk_init()
Date: Thu, 29 Feb 2024 17:33:10 -0800 [thread overview]
Message-ID: <cd72dbb31387cd4e2551189d8d10d3a6.sboyd@kernel.org> (raw)
In-Reply-To: <CZHOCV35A23S.14HL07U73EH6X@bootlin.com>
Quoting Théo Lebrun (2024-02-29 07:40:25)
> Hello,
>
> On Thu Feb 29, 2024 at 3:59 PM CET, Andy Shevchenko wrote:
> > On Thu, Feb 29, 2024 at 03:27:01PM +0100, Théo Lebrun wrote:
> > > On Wed, Feb 28, 2024 at 03:33:29PM +0100, Théo Lebrun wrote:
> > > > On Tue Feb 27, 2024 at 6:11 PM CET, Andy Shevchenko wrote:
> > > > > On Tue, Feb 27, 2024 at 03:55:24PM +0100, Théo Lebrun wrote:
>
> > 2) Still I see a benefit from using lo_hi_readq() and friends directly.
>
> So it is:
>
> u32 r0 = readl(base_plls + pll->reg64);
> u32 r1 = readl(base_plls + pll->reg64 + sizeof(r0));
>
> vs:
>
> u64 r = lo_hi_readq(base_plls + pll->regs64);
> u32 r0 = r;
> u32 r1 = r >> 32;
>
> One is straight forward, the other uses an obscure helper that code
> readers must understand and follows that with bit manipulation.
>
Just use readq() and include the correct header please. We know what
readq() is in the kernel.
next prev parent reply other threads:[~2024-03-01 1:33 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 14:55 [PATCH v8 00/10] Add support for Mobileye EyeQ5 system controller Théo Lebrun
2024-02-27 14:55 ` [PATCH v8 01/10] dt-bindings: pinctrl: mobileye,eyeq5-pinctrl: add bindings Théo Lebrun
2024-02-29 9:10 ` Linus Walleij
2024-02-27 14:55 ` [PATCH v8 02/10] dt-bindings: soc: mobileye: add EyeQ5 OLB system controller Théo Lebrun
2024-02-27 16:38 ` Rob Herring
2024-02-28 14:09 ` Théo Lebrun
2024-02-27 14:55 ` [PATCH v8 03/10] clk: eyeq5: add platform driver, and init routine at of_clk_init() Théo Lebrun
2024-02-27 17:11 ` Andy Shevchenko
2024-02-28 14:33 ` Théo Lebrun
2024-02-29 11:15 ` Andy Shevchenko
2024-02-29 14:27 ` Théo Lebrun
2024-02-29 14:59 ` Andy Shevchenko
2024-02-29 15:40 ` Théo Lebrun
2024-02-29 15:48 ` Andy Shevchenko
2024-02-29 15:57 ` Théo Lebrun
2024-03-01 1:33 ` Stephen Boyd [this message]
2024-02-27 14:55 ` [PATCH v8 04/10] reset: eyeq5: add platform driver Théo Lebrun
2024-02-27 17:27 ` Andy Shevchenko
2024-02-28 17:04 ` Théo Lebrun
2024-02-29 11:22 ` Andy Shevchenko
2024-02-29 12:18 ` Théo Lebrun
2024-02-29 13:48 ` Andy Shevchenko
2024-02-29 13:53 ` Andy Shevchenko
2024-02-29 15:23 ` Théo Lebrun
2024-02-29 15:33 ` Andy Shevchenko
2024-02-29 15:28 ` Philipp Zabel
2024-02-29 15:36 ` Andy Shevchenko
2024-03-01 11:36 ` Philipp Zabel
2024-02-27 14:55 ` [PATCH v8 05/10] pinctrl: " Théo Lebrun
2024-02-27 18:14 ` Andy Shevchenko
2024-02-28 18:15 ` Théo Lebrun
2024-02-29 11:35 ` Andy Shevchenko
2024-02-29 15:13 ` Théo Lebrun
2024-02-29 15:32 ` Andy Shevchenko
2024-02-29 21:02 ` Linus Walleij
2024-02-27 14:55 ` [PATCH v8 06/10] MAINTAINERS: Map OLB files to Mobileye SoCs Théo Lebrun
2024-02-27 14:55 ` [PATCH v8 07/10] MIPS: mobileye: eyeq5: add OLB syscon node Théo Lebrun
2024-02-27 14:55 ` [PATCH v8 08/10] MIPS: mobileye: eyeq5: use OLB clocks controller node Théo Lebrun
2024-02-27 14:55 ` [PATCH v8 09/10] MIPS: mobileye: eyeq5: add OLB reset " Théo Lebrun
2024-02-27 14:55 ` [PATCH v8 10/10] MIPS: mobileye: eyeq5: add pinctrl node & pinmux function nodes Théo Lebrun
2024-02-29 9:12 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd72dbb31387cd4e2551189d8d10d3a6.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
--cc=tawfik.bayouk@mobileye.com \
--cc=theo.lebrun@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tsbogend@alpha.franken.de \
--cc=vladimir.kondratiev@mobileye.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).