linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: afzal mohammed <afzal.mohd.ma@gmail.com>
To: Thomas Bogendoerfer <tbogendoerfer@suse.de>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org
Subject: [PATCH 0/3] Remove setup_percpu_irq() & remove_percpu_irq
Date: Sat, 11 Apr 2020 21:34:07 +0530	[thread overview]
Message-ID: <cover.1586434781.git.afzal.mohd.ma@gmail.com> (raw)

Hi,

While doing the removal of setup_irq(), it was observed that
setup_percpu_irq() also can be removed similarly by replacing it w/
request_percpu_irq(), which does allocate memory. In the initial
setup_irq() removal cover letters [1], it was mentioned that
setup_percpu_irq() is untouched.

After removing setup_irq(), it does not look good to let live
setup_percpu_irq(), especially since it being a low hanging fruit. Hence
replace setup_percpu_irq() by it's allocator equivalent.
request_percpu_irq() cannot be used since all the users need to pass
IRQF_TIMER flag, which it would not allow. Thus it's variant,
__request_percpu_irq() is used.

In addition to removing setup_percpu_irq() definition,
remove_percpu_irq(), unused, is also removed.

It seems setup_percpu_irq() is used only by MIPS (even the one outside
MIPS arch dir, i.e. the clocksource driver). The series has been build
tested, though i would have loved to do a qemu test as well, i do not
see a qemu machine type that can test the changes done here (in malta
machine, in which clocksource changes are getting built, the changes
done here are not being runtime tested).

Regards
afzal

[1] https://lkml.kernel.org/r/cover.1581478323.git.afzal.mohd.ma@gmail.com

afzal mohammed (3):
  MIPS: Replace setup_percpu_irq() by request_percpu_irq() variant
  clocksource/drivers/mips-gic-timer: Replace setup_percpu_irq() by
    request_percpu_irq() variant
  genirq: Remove setup_percpu_irq() and remove_percpu_irq()

 arch/mips/include/asm/cevt-r4k.h     |  1 -
 arch/mips/kernel/cevt-r4k.c          | 11 --------
 arch/mips/sgi-ip27/ip27-timer.c      | 13 ++++-----
 arch/mips/sgi-ip30/ip30-timer.c      |  6 ++--
 drivers/clocksource/mips-gic-timer.c | 10 ++-----
 include/linux/irq.h                  |  2 --
 kernel/irq/manage.c                  | 42 ----------------------------
 7 files changed, 10 insertions(+), 75 deletions(-)

-- 
2.18.0


             reply	other threads:[~2020-04-11 16:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-11 16:04 afzal mohammed [this message]
2020-04-11 16:04 ` [PATCH 1/3] MIPS: Replace setup_percpu_irq() by request_percpu_irq() variant afzal mohammed
2020-04-19 14:46 ` [PATCH 0/3] Remove setup_percpu_irq() & remove_percpu_irq afzal mohammed
2020-04-20 17:31   ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1586434781.git.afzal.mohd.ma@gmail.com \
    --to=afzal.mohd.ma@gmail.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=tbogendoerfer@suse.de \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).