Re: [PATCH v1 1/2] dt-binding: rtc: loongson: Document Loongson-2K0300 compatible

Binbin Zhou
2025-12-30T02:32:12Z

Hi Rob:

Thanks for your review.

On Tue, Dec 30, 2025 at 10:15 AM Rob Herring <robh@kernel.org> wrote:
>
> On Tue, Dec 23, 2025 at 02:42:12PM +0800, Binbin Zhou wrote:
> > Add "loongson,ls2k0300-rtc" dedicated compatible to represent the RTC
> > interface of the Loongson-2K0300 chip.
> >
> > Its hardware design is similar to that of the Loongson-1B, but it does
> > not support the alarm feature.
> >
> > Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn>
> > ---
> > .../devicetree/bindings/rtc/loongson,rtc.yaml | 13 +++++++++++++
> > 1 file changed, 13 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/rtc/loongson,rtc.yaml b/Documentation/devicetree/bindings/rtc/loongson,rtc.yaml
> > index f89c1f660aee..aac91c79ffdb 100644
> > --- a/Documentation/devicetree/bindings/rtc/loongson,rtc.yaml
> > +++ b/Documentation/devicetree/bindings/rtc/loongson,rtc.yaml
> > @@ -23,6 +23,7 @@ properties:
> > - loongson,ls1b-rtc
> > - loongson,ls1c-rtc
> > - loongson,ls7a-rtc
> > + - loongson,ls2k0300-rtc
> > - loongson,ls2k1000-rtc
> > - items:
> > - enum:
> > @@ -42,6 +43,18 @@ required:
> >
> > unevaluatedProperties: false
> >
> > +if:
> > + properties:
> > + compatible:
> > + contains:
> > + enum:
> > + - loongson,ls1c-rtc
>
> This seems unrelated?

Loongson-1C does not support the alarm feature, so the `interrupts`
property is not needed.

Technically, this is my fault and should have been described in the
binding before, just correcting it now.
Perhaps I should have mentioned this in the commit message.
>
> > + - loongson,ls2k0300-rtc
> > +
> > +then:
> > + properties:
> > + interrupts: false
> > +
> > examples:
> > - |
> > #include <dt-bindings/interrupt-controller/irq.h>
> > --
> > 2.47.3
> >

--
Thanks.
Binbin