From: "Nuno Sá" <noname.nuno@gmail.com>
To: "Andy Shevchenko" <andy.shevchenko@gmail.com>,
"Nuno Sá" <nuno.sa@analog.com>
Cc: linux-arm-msm <linux-arm-msm@vger.kernel.org>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
dl-linux-imx <linux-imx@nxp.com>,
"open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
linux-iio <linux-iio@vger.kernel.org>,
chrome-platform@lists.linux.dev,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
linux-stm32@st-md-mailman.stormreply.com,
Andy Gross <agross@kernel.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Benson Leung <bleung@chromium.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Tomer Maimon <tmaimon77@gmail.com>,
Zhang Rui <rui.zhang@intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Eugen Hristev <eugen.hristev@microchip.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Benjamin Fair <benjaminfair@google.com>,
Nancy Yuen <yuenn@google.com>,
Fabrice Gasnier <fabrice.gasnier@foss.st.com>,
Jishnu Prakash <quic_jprakash@quicinc.com>,
Christophe Branchereau <cbranchereau@gmail.com>,
Avi Fishman <avifishman70@gmail.com>,
Tali Perry <tali.perry1@gmail.com>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Thara Gopinath <thara.gopinath@linaro.org>,
Cai Huoqing <cai.huoqing@linux.dev>,
Fabio Estevam <festevam@gmail.com>,
Olivier Moysan <olivier.moysan@foss.st.com>,
Shawn Guo <shawnguo@kernel.org>, Haibo Chen <haibo.chen@nxp.com>,
Arnd Bergmann <arnd@arndb.de>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Patrick Venture <venture@google.com>,
Amit Kucheria <amitk@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Paul Cercueil <paul@crapouillou.net>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Gwendal Grignou <gwendal@chromium.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Saravanan Sekar <sravanhome@gmail.com>,
Guenter Roeck <groeck@chromium.org>,
Jonathan Cameron <jic23@kernel.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v2 15/15] iio: inkern: fix coding style warnings
Date: Mon, 11 Jul 2022 16:05:31 +0200 [thread overview]
Message-ID: <d060ab80fcf8ede50466069c9021eda97e239fb6.camel@gmail.com> (raw)
In-Reply-To: <CAHp75VcnuAtc+n+nhQ16yP9S-veX2c6ruquSewtPJdcqQwpyAQ@mail.gmail.com>
On Mon, 2022-07-11 at 15:15 +0200, Andy Shevchenko wrote:
> On Mon, Jul 11, 2022 at 2:40 PM Nuno Sá <nuno.sa@analog.com> wrote:
> >
> > Just cosmetics. No functional change intended...
>
> ...
>
> > - if (name == NULL && channel_name == NULL)
> > + if (!name && !channel_name)
> > return ERR_PTR(-ENODEV);
>
> After this change in place, I think it's better to convert it to
>
> if (!(name || channel_name))
>
> which shows intentions clearer.
>
No strong feelings from my side so I can do that if a v3 is needed
(which, most likely, will be needed).
- Nuno Sá
next prev parent reply other threads:[~2022-07-11 14:04 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 12:38 [PATCH v2 00/15] make iio inkern interface firmware agnostic Nuno Sá
2022-07-11 12:38 ` [PATCH v2 01/15] iio: inkern: only release the device node when done with it Nuno Sá
2022-07-11 13:09 ` Andy Shevchenko
2022-07-11 12:38 ` [PATCH v2 02/15] iio: inkern: fix return value in devm_of_iio_channel_get_by_name() Nuno Sá
2022-07-11 12:38 ` [PATCH v2 03/15] iio: inkern: only return error codes in iio_channel_get_*() APIs Nuno Sá
2022-07-11 13:29 ` Andy Shevchenko
2022-07-11 14:06 ` Nuno Sá
2022-07-11 12:38 ` [PATCH v2 04/15] iio: inkern: split of_iio_channel_get_by_name() Nuno Sá
2022-07-11 12:38 ` [PATCH v2 05/15] iio: inkern: move to fwnode properties Nuno Sá
2022-07-11 12:38 ` [PATCH v2 06/15] thermal: qcom: qcom-spmi-adc-tm5: convert to IIO fwnode API Nuno Sá
2022-07-11 12:38 ` [PATCH v2 07/15] iio: adc: ingenic-adc: convert to IIO fwnode interface Nuno Sá
2022-07-11 12:38 ` [PATCH v2 08/15] iio: adc: ab8500-gpadc: convert to device properties Nuno Sá
2022-07-11 12:38 ` [PATCH v2 09/15] iio: adc: at91-sama5d2_adc: " Nuno Sá
2022-07-11 12:38 ` [PATCH v2 10/15] iio: adc: qcom-pm8xxx-xoadc: " Nuno Sá
2022-07-11 12:38 ` [PATCH v2 11/15] iio: adc: qcom-spmi-vadc: " Nuno Sá
2022-07-11 12:38 ` [PATCH v2 12/15] iio: adc: qcom-spmi-adc5: " Nuno Sá
2022-07-11 12:38 ` [PATCH v2 13/15] iio: adc: stm32-adc: " Nuno Sá
2022-07-11 14:04 ` Fabrice Gasnier
2022-07-12 10:33 ` Nuno Sá
2022-07-13 15:48 ` Fabrice Gasnier
2022-07-15 11:22 ` Nuno Sá
2022-07-11 12:38 ` [PATCH v2 14/15] iio: inkern: remove OF dependencies Nuno Sá
2022-07-11 12:38 ` [PATCH v2 15/15] iio: inkern: fix coding style warnings Nuno Sá
2022-07-11 13:15 ` Andy Shevchenko
2022-07-11 13:28 ` Biju Das
2022-07-11 13:32 ` Andy Shevchenko
2022-07-11 13:37 ` Biju Das
2022-07-11 14:05 ` Nuno Sá [this message]
2022-07-11 13:22 ` [PATCH v2 00/15] make iio inkern interface firmware agnostic Andy Shevchenko
2022-07-11 14:04 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d060ab80fcf8ede50466069c9021eda97e239fb6.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=agross@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=amitk@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=bleung@chromium.org \
--cc=cai.huoqing@linux.dev \
--cc=cbranchereau@gmail.com \
--cc=chrome-platform@lists.linux.dev \
--cc=claudiu.beznea@microchip.com \
--cc=daniel.lezcano@linaro.org \
--cc=eugen.hristev@microchip.com \
--cc=fabrice.gasnier@foss.st.com \
--cc=festevam@gmail.com \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=haibo.chen@nxp.com \
--cc=jic23@kernel.org \
--cc=kernel@pengutronix.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=lorenzo@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=nicolas.ferre@microchip.com \
--cc=nuno.sa@analog.com \
--cc=olivier.moysan@foss.st.com \
--cc=openbmc@lists.ozlabs.org \
--cc=paul@crapouillou.net \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=quic_jprakash@quicinc.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=sravanhome@gmail.com \
--cc=tali.perry1@gmail.com \
--cc=thara.gopinath@linaro.org \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).