From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Serge Semin <fancer.lancer@gmail.com>
Cc: Keguang Zhang <keguang.zhang@gmail.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Serge Semin <Sergey.Semin@baikalelectronics.ru>
Subject: Re: [PATCH v3 2/4] dt-bindings: net: Add Loongson-1 Ethernet Controller
Date: Mon, 28 Aug 2023 09:15:17 +0200 [thread overview]
Message-ID: <d6f796aa-c468-037c-3f53-d0c4306c8890@linaro.org> (raw)
In-Reply-To: <q7o7wqodz5epyjdj7vlryaseugr2fjhef2cgsh65trw3r2jorm@5z5a5tyuyq4d>
On 27/08/2023 23:01, Serge Semin wrote:
> Hi Krzysztof
>
> On Sun, Aug 27, 2023 at 09:56:06AM +0200, Krzysztof Kozlowski wrote:
>> On 26/08/2023 23:04, Serge Semin wrote:
>>>> + clock-names:
>>>> + items:
>>>> + - const: stmmaceth
>>>
>>> clock-names:
>>> const: stmmaceth
>>> ?
>>
>
>> The existing syntax is correct. This is a string array.
>
> Could you please clarify whether it's a requirement (always specify
> items: property for an array) or just an acceptable option (another
> one is suggested in my comment)? I am asking because:
> 1. In this case the "clock-names" array is supposed to have only one
> item. Directly setting "const: stmmaceth" with no items: property
> shall simplify it.
> 2. There are single-entry "clock-names" property in the DT-bindings
> defined as I suggested.
> 3. There is a "compatible" property which is also a string array but
> it can be defined as I suggested (omitting the items property).
>
> so based on all of that using the "items:"-based constraint here seems
> redundant. Am I wrong to think like that? If so in what aspect?
Syntax is correct in both cases. However the single list compatible
*cannot grow*, while single list clock might, when developer notices
that the binding was incomplete. People add binding matching drivers,
not the hardware, thus having incomplete list of clocks is happening all
the time.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-08-28 7:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 12:50 [PATCH v3 0/4] Move Loongson1 MAC arch-code to the driver dir Keguang Zhang
2023-08-24 12:50 ` [PATCH v3 1/4] dt-bindings: mfd: syscon: Add compatibles for Loongson-1 syscon Keguang Zhang
2023-08-25 6:48 ` Krzysztof Kozlowski
2023-08-24 12:50 ` [PATCH v3 2/4] dt-bindings: net: Add Loongson-1 Ethernet Controller Keguang Zhang
2023-08-26 21:04 ` Serge Semin
2023-08-27 7:56 ` Krzysztof Kozlowski
2023-08-27 21:01 ` Serge Semin
2023-08-28 7:15 ` Krzysztof Kozlowski [this message]
2023-08-28 12:41 ` Serge Semin
2023-08-28 4:38 ` Keguang Zhang
2023-08-28 12:46 ` Serge Semin
2023-08-28 13:09 ` Keguang Zhang
2023-08-24 12:50 ` [PATCH v3 3/4] net: stmmac: Add glue layer for Loongson-1 SoC Keguang Zhang
2023-08-26 20:40 ` Serge Semin
2023-08-30 13:45 ` Keguang Zhang
2023-08-24 12:50 ` [PATCH v3 4/4] MAINTAINERS: Update MIPS/LOONGSON1 entry Keguang Zhang
2023-08-25 6:47 ` Krzysztof Kozlowski
2023-08-25 12:22 ` Keguang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6f796aa-c468-037c-3f53-d0c4306c8890@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=alexandre.torgue@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=fancer.lancer@gmail.com \
--cc=joabreu@synopsys.com \
--cc=keguang.zhang@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).