From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEBBBC76195 for ; Wed, 22 Mar 2023 14:51:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229589AbjCVOvW (ORCPT ); Wed, 22 Mar 2023 10:51:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230484AbjCVOvC (ORCPT ); Wed, 22 Mar 2023 10:51:02 -0400 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 970BE69050 for ; Wed, 22 Mar 2023 07:49:33 -0700 (PDT) Received: by mail-wm1-x32e.google.com with SMTP id m6-20020a05600c3b0600b003ee6e324b19so902748wms.1 for ; Wed, 22 Mar 2023 07:49:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679496572; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QgpnOGjVLEuypN3ErDTiOI3NLlX/0j8wRBIzyu6JHTA=; b=X4fwNuM+lvoCT0eDdhrh8qu0d3y8CTVo2fmzUHYgTsVwCWryX5ksmhn3yTXvLSCuAr ZqLivJqI7xfK3Y/fQajsIQapKLatPD2OZA7WnIOmZqMJuX0vmG5fgBgAZAzfEjtFaqqF 0ygbTqiK1sWJZIVWPfCzGJ3yY0TtYjm00Tc03VMP5QMq8gsB0HJwcGgCTjAIh2niCs1R iYCu7tcRl135CP8hLfhfwt6i3Ux5cCOqF61Soa/Xii7F7h3ql5RG9mPYNgoR6Ffmnvbl gp0PojSSjNZQm3RnK3A5o2A4IOJH10vJouXGQlA1ZpTf5dW+cJBApJ0lHl2u1onEQiQz YKlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679496572; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QgpnOGjVLEuypN3ErDTiOI3NLlX/0j8wRBIzyu6JHTA=; b=02bxlxwrKUaUpsLhRbO94lGydIS/Nd3/9dLDBYjVV4yPW8NI2sBS1/VJVQlmPhVKDS MBSweLyIQ52FPwAbk4KEndAmQA5M8mjCdwzl1quDLt8yCeIleKACHL41xICJYdOAaUDb tl+Dvfki+C42wvhHPGrQ9JjdASqj6hn/f0DvbdnqmVV+A/Ov+/bB+NTxhWWpa9hebNJv e3aKgfxQ6sP+aK7NRhIRuGHbwpJ1KjiBs0ybtECVIFsiWhJ2eTiWsfhhPaPdX3xoBXAU JncBoeUQucJzD5A9Sx+NchCwuOzctbBgp7I+bF0lXLHjqG95jGR/8t/r6VE07bRTbfPy /4qQ== X-Gm-Message-State: AO0yUKVU1adnOR0Qyty6qPo0YtcqfrZbQqopbrqOX+Y2BH3lNu4foPQG pmV+hkcHZHuIqEIZMK26cn2+0w== X-Google-Smtp-Source: AK7set+9XZgGgwvM+OLoRVwuVwrg4HkIiNlpgiPve/1U/yoqf+U/sCmAPCSUxB1b4JfefI4G4O7OFQ== X-Received: by 2002:a7b:c7c4:0:b0:3ea:ed4d:38f6 with SMTP id z4-20020a7bc7c4000000b003eaed4d38f6mr5600772wmk.4.1679496572162; Wed, 22 Mar 2023 07:49:32 -0700 (PDT) Received: from [192.168.30.216] ([81.0.6.76]) by smtp.gmail.com with ESMTPSA id p5-20020adfce05000000b002d64fcb362dsm8733633wrn.111.2023.03.22.07.49.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Mar 2023 07:49:31 -0700 (PDT) Message-ID: Date: Wed, 22 Mar 2023 15:49:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v2 01/14] mips: fix comment about pgtable_init() Content-Language: en-US To: Mike Rapoport , Andrew Morton Cc: David Hildenbrand , Doug Berger , Matthew Wilcox , Mel Gorman , Michal Hocko , Thomas Bogendoerfer , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org References: <20230321144842.2401182-1-rppt@kernel.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20230321144842.2401182-1-rppt@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On 21/3/23 15:48, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > Comment about fixrange_init() says that its called from pgtable_init() > while the actual caller is pagetabe_init(). > > Update comment to match the code. > > Signed-off-by: Mike Rapoport (IBM) > Reviewed-by: David Hildenbrand > --- > arch/mips/include/asm/fixmap.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/mips/include/asm/fixmap.h b/arch/mips/include/asm/fixmap.h > index beea14761cef..b037718d7e8b 100644 > --- a/arch/mips/include/asm/fixmap.h > +++ b/arch/mips/include/asm/fixmap.h > @@ -70,7 +70,7 @@ enum fixed_addresses { > #include > > /* > - * Called from pgtable_init() > + * Called from pagetable_init() I'm not sure about the usefulness of this comment; I suppose it predates git-grep. Anyhow, Reviewed-by: Philippe Mathieu-Daudé > */ > extern void fixrange_init(unsigned long start, unsigned long end, > pgd_t *pgd_base);